Opened 4 years ago
Closed 4 years ago
#19321 closed enhancement (fixed)
provide better hash functions
Reported by: | vdelecroix | Owned by: | |
---|---|---|---|
Priority: | critical | Milestone: | sage-6.9 |
Component: | misc | Keywords: | hash |
Cc: | ncohen, nbruin | Merged in: | |
Authors: | Nils Bruin, Vincent Delecroix | Reviewers: | Nathann Cohen |
Report Upstream: | N/A | Work issues: | |
Branch: | bebb8af (Commits) | Commit: | bebb8af5eaa7ff834a03e9c887da69b118a257af |
Dependencies: | Stopgaps: |
Description (last modified by )
Change History (6)
comment:1 Changed 4 years ago by
- Branch set to public/19321
- Status changed from new to needs_review
comment:2 Changed 4 years ago by
- Commit set to bebb8af5eaa7ff834a03e9c887da69b118a257af
comment:3 Changed 4 years ago by
comment:5 Changed 4 years ago by
- Reviewers set to Nathann Cohen
- Status changed from needs_review to positive_review
Yo !
To me, it seems good to go. I was a bit worried about the hash of polyhedra but the elements of your tuple are all integers, and the functions that return them are, well, 'not too scary' even though there is a bit of useless wrapping going on.
Nathann
comment:6 Changed 4 years ago by
- Branch changed from public/19321 to bebb8af5eaa7ff834a03e9c887da69b118a257af
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
Trac 19321: fix similarity classes
Trac 19321: fix Kleber tree hash value
Trac 19321: fix hash for Additive abelian group elements
Trac 19321: fix fgp vector conversion
Trac 19321: hash for polyhedra
Trac 19321: change output order in documentation
trac 19321: fix some non-deterministic doctests (and add some deterministic checks)
trac 19321: doctest fixes and making some code deterministic
trac 19321: fix some doctests in polynomial/plural.pyx
Trac 19321: fix a doctest