Opened 6 years ago

Closed 6 years ago

#19314 closed defect (fixed)

calling findstat with first argument being a FindStatCollection does not work

Reported by: mantepse Owned by:
Priority: major Milestone: sage-6.9
Component: interfaces Keywords: FindStat
Cc: stumpc5 Merged in:
Authors: Martin Rubey Reviewers: Christian Stump
Report Upstream: N/A Work issues:
Branch: dc390fc (Commits, GitHub, GitLab) Commit: dc390fc22a0c22b75ebd26ef0161bf0770142c48
Dependencies: Stopgaps:

Status badges

Description

sage: from sage.databases.findstat import FindStatCollection
sage: findstat(FindStatCollection("Permutations"), lambda pi: pi.length())

yields an error, which is fixed by this ticket.

Change History (7)

comment:1 Changed 6 years ago by stumpc5

Currently, FindStatCollection is purely internal, isn't it? Of course you can fix this issue, but I would not recommend to have this as a user point of entry to the findstat functionality...

comment:2 Changed 6 years ago by mantepse

  • Branch set to u/mantepse/calling_findstat_with_first_argument_being_a_findstatcollection_does_not_work

comment:3 Changed 6 years ago by mantepse

  • Commit set to dc390fc22a0c22b75ebd26ef0161bf0770142c48

I really do have to fix it, since it might be called internally... Also, personally, I use FindStatCollections quite a bit.


New commits:

dc390fcforgot an else

comment:4 Changed 6 years ago by stumpc5

This is ready to go, are you going to set it to needs review? Please also have a look at #19307 and #19296, both ready for review with green patchbot.

comment:5 Changed 6 years ago by mantepse

  • Status changed from new to needs_review

comment:6 Changed 6 years ago by stumpc5

  • Authors set to Martin Rubey
  • Reviewers set to Christian Stump
  • Status changed from needs_review to positive_review

comment:7 Changed 6 years ago by vbraun

  • Branch changed from u/mantepse/calling_findstat_with_first_argument_being_a_findstatcollection_does_not_work to dc390fc22a0c22b75ebd26ef0161bf0770142c48
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.