Opened 6 years ago

Closed 6 years ago

#19313 closed enhancement (fixed)

Reorganize compiler stuff in configure.ac

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-6.9
Component: build: configure Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: edb16b0 (Commits, GitHub, GitLab) Commit: edb16b0ed12c36dcc5e8d0e262ad38c3ca3f7ad8
Dependencies: #19292, #19293 Stopgaps:

Status badges

Description (last modified by jdemeyer)

Instead of first checking whether to install GCC and then checking the compilers, we should check the compilers and then decide whether to install GCC based on that information.

To do this, we introduce 2 new macros: SAGE_MUST_INSTALL_GCC() and SAGE_SHOULD_INSTALL_GCC().

Change History (10)

comment:1 Changed 6 years ago by jdemeyer

  • Description modified (diff)
  • Summary changed from Move compiler stuff together in configure.ac to Reorganize compiler stuff in configure.ac

comment:2 Changed 6 years ago by jdemeyer

  • Branch set to u/jdemeyer/move_compiler_stuff_together_in_configure_ac

comment:3 Changed 6 years ago by git

  • Commit set to f7b20da3550e0ab6ef32414179b47589252676af

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

f7b20daReorganize compiler checks in proper autoconf style

comment:4 Changed 6 years ago by git

  • Commit changed from f7b20da3550e0ab6ef32414179b47589252676af to 9d21de90392c4850c09ec05d70f4b0d07ed21445

Branch pushed to git repo; I updated commit sha1. New commits:

9d21de9Double-quote character ranges

comment:5 Changed 6 years ago by git

  • Commit changed from 9d21de90392c4850c09ec05d70f4b0d07ed21445 to bf6f9118956a7aac842f675e5a019d198a0fb2e0

Branch pushed to git repo; I updated commit sha1. New commits:

bf6f911Quote $1

comment:6 Changed 6 years ago by jdemeyer

  • Status changed from new to needs_review

comment:7 Changed 6 years ago by jdemeyer

  • Description modified (diff)

comment:8 Changed 6 years ago by git

  • Commit changed from bf6f9118956a7aac842f675e5a019d198a0fb2e0 to edb16b0ed12c36dcc5e8d0e262ad38c3ca3f7ad8

Branch pushed to git repo; I updated commit sha1. New commits:

edb16b0Typo

comment:9 Changed 6 years ago by vbraun

  • Reviewers set to Volker Braun
  • Status changed from needs_review to positive_review

comment:10 Changed 6 years ago by vbraun

  • Branch changed from u/jdemeyer/move_compiler_stuff_together_in_configure_ac to edb16b0ed12c36dcc5e8d0e262ad38c3ca3f7ad8
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.