Opened 7 years ago

Closed 7 years ago

#19313 closed enhancement (fixed)

Reorganize compiler stuff in configure.ac

Reported by: Jeroen Demeyer Owned by:
Priority: major Milestone: sage-6.9
Component: build: configure Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: edb16b0 (Commits, GitHub, GitLab) Commit: edb16b0ed12c36dcc5e8d0e262ad38c3ca3f7ad8
Dependencies: #19292, #19293 Stopgaps:

Status badges

Description (last modified by Jeroen Demeyer)

Instead of first checking whether to install GCC and then checking the compilers, we should check the compilers and then decide whether to install GCC based on that information.

To do this, we introduce 2 new macros: SAGE_MUST_INSTALL_GCC() and SAGE_SHOULD_INSTALL_GCC().

Change History (10)

comment:1 Changed 7 years ago by Jeroen Demeyer

Description: modified (diff)
Summary: Move compiler stuff together in configure.acReorganize compiler stuff in configure.ac

comment:2 Changed 7 years ago by Jeroen Demeyer

Branch: u/jdemeyer/move_compiler_stuff_together_in_configure_ac

comment:3 Changed 7 years ago by git

Commit: f7b20da3550e0ab6ef32414179b47589252676af

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

f7b20daReorganize compiler checks in proper autoconf style

comment:4 Changed 7 years ago by git

Commit: f7b20da3550e0ab6ef32414179b47589252676af9d21de90392c4850c09ec05d70f4b0d07ed21445

Branch pushed to git repo; I updated commit sha1. New commits:

9d21de9Double-quote character ranges

comment:5 Changed 7 years ago by git

Commit: 9d21de90392c4850c09ec05d70f4b0d07ed21445bf6f9118956a7aac842f675e5a019d198a0fb2e0

Branch pushed to git repo; I updated commit sha1. New commits:

bf6f911Quote $1

comment:6 Changed 7 years ago by Jeroen Demeyer

Status: newneeds_review

comment:7 Changed 7 years ago by Jeroen Demeyer

Description: modified (diff)

comment:8 Changed 7 years ago by git

Commit: bf6f9118956a7aac842f675e5a019d198a0fb2e0edb16b0ed12c36dcc5e8d0e262ad38c3ca3f7ad8

Branch pushed to git repo; I updated commit sha1. New commits:

edb16b0Typo

comment:9 Changed 7 years ago by Volker Braun

Reviewers: Volker Braun
Status: needs_reviewpositive_review

comment:10 Changed 7 years ago by Volker Braun

Branch: u/jdemeyer/move_compiler_stuff_together_in_configure_acedb16b0ed12c36dcc5e8d0e262ad38c3ca3f7ad8
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.