Opened 4 years ago

Closed 4 years ago

#19311 closed enhancement (fixed)

A (729,336,153,156)-strongly regular graph

Reported by: ncohen Owned by:
Priority: major Milestone: sage-6.9
Component: graph theory Keywords:
Cc: dimpase Merged in:
Authors: Nathann Cohen Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: 85e1bc1 (Commits) Commit: 85e1bc1a868e3906b073e08fb1507918ee484c14
Dependencies: Stopgaps:

Description

As the title says.

Change History (11)

comment:1 Changed 4 years ago by ncohen

  • Branch set to u/ncohen/19311
  • Commit set to 361c181045726352d7e51c84bdd8b149c3d7c16c
  • Status changed from new to needs_review

New commits:

361c181trac #19311: A (729,336,153,156)-strongly regular graph

comment:2 follow-up: Changed 4 years ago by dimpase

hmm, shouldn't we have a generic function to build a graph from a 2-intersection code? (you basically have it in the body already...)

comment:3 in reply to: ↑ 2 Changed 4 years ago by ncohen

hmm, shouldn't we have a generic function to build a graph from a 2-intersection code? (you basically have it in the body already...)

We can have one if you feel like adding it. What I fear the most is writing the doc, personally... e.g. define it properly.

So as it is only used once for the moment.

Nathann

comment:4 Changed 4 years ago by dimpase

I really would want a properly documented generic function. As you just wrote this code, you know what it does, and I don't. I'd help with improving the doc, no problem...

comment:5 Changed 4 years ago by git

  • Commit changed from 361c181045726352d7e51c84bdd8b149c3d7c16c to 1a435b640c89c5bb7643961804f5c754ec843fc5

Branch pushed to git repo; I updated commit sha1. New commits:

1a435b6trac #19311: Draft of an individual function

comment:6 Changed 4 years ago by ncohen

Here are my last 30 minutes, just because you requested it.

Since you wanted an independent function, there are holes that you can help fill: the matrix is currentl a matrix of homogeneous coordinates but the zeroes must not be anywhere (if I remember correctly), and that needs to be explained properly. There is also an obvious need of a doctest.

Feel free to change the function's arguments if you do not want a matrix but something else instead.

Nathann

comment:7 follow-up: Changed 4 years ago by dimpase

  • Reviewers set to Dima Pasechnik

please have a look at the public/19311 trac git branch. The last commit is the fix/docs etc. If you are happy with it please make it into positive reviewed one.

comment:8 Changed 4 years ago by git

  • Commit changed from 1a435b640c89c5bb7643961804f5c754ec843fc5 to 85e1bc1a868e3906b073e08fb1507918ee484c14

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

be0c14dtrac #19311: A (729,336,153,156)-strongly regular graph
59b3692trac #19311: Draft of an individual function
85e1bc1docs and example and optimisation/simplification

comment:9 in reply to: ↑ 7 Changed 4 years ago by ncohen

  • Status changed from needs_review to positive_review

please have a look at the public/19311 trac git branch. The last commit is the fix/docs etc. If you are happy with it please make it into positive reviewed one.

WOUHUUUUUUUUUUUUUUUUUUUUUUUU ! You finally learnt the workflow !! :-PPPPPP

Good to go. Thanks for that ;-)

Nathann

P.S.: Could you pease fill your name in th.... What the hell!!??? Really??? :-D

comment:10 Changed 4 years ago by dimpase

for the record, GQs of type T_2*(O) are a case of this construction (for O a 0-2 intersection set in PG(2,q)). This ought to be unified, eventually.

comment:11 Changed 4 years ago by vbraun

  • Branch changed from u/ncohen/19311 to 85e1bc1a868e3906b073e08fb1507918ee484c14
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.