Opened 4 years ago

Closed 4 years ago

#19306 closed enhancement (fixed)

common generators for asymptotic expansions

Reported by: dkrenn Owned by:
Priority: major Milestone: sage-7.1
Component: asymptotic expansions Keywords:
Cc: behackl, cheuberg Merged in:
Authors: Daniel Krenn Reviewers: Clemens Heuberger
Report Upstream: N/A Work issues:
Branch: 4d80eb3 (Commits) Commit: 4d80eb34881599216582ea4fb4b5eed2db8a0be1
Dependencies: #19259, #19305 Stopgaps:

Description (last modified by dkrenn)

Implement common asymptotic expansion generators.

See also meta ticket #17601.

Change History (22)

comment:1 Changed 4 years ago by dkrenn

  • Dependencies set to #19305

comment:2 Changed 4 years ago by dkrenn

  • Branch set to u/dkrenn/asy/subs

comment:3 Changed 4 years ago by dkrenn

  • Branch changed from u/dkrenn/asy/subs to u/dkrenn/asy/generators
  • Commit set to e83d82a88cd0d7abb8e355658f675d66257de200

Last 10 new commits:

30f7058write doctests for coercions, common_parent, pushout
a54b4afminor docstring rewriting of factory
fb2885csubring in index.rst
eab9513simplify a doctest
23352b2change ValueError to TypeError to make everything work with SR as it should
2d8b7c4typo in docstring
15ec40edocstring of SR.subring
7938d95module description of subring
852959arename only_constants --> no_variables
e83d82aMerge branch 'u/dkrenn/symbolic-subring' of trac.sagemath.org:sage into u/dakrenn/asy/subs

comment:4 Changed 4 years ago by dkrenn

  • Description modified (diff)

comment:5 Changed 4 years ago by dkrenn

  • Description modified (diff)

comment:6 Changed 4 years ago by dkrenn

  • Summary changed from generators for asymptotic expansions to common generators for asymptotic expansions

comment:7 Changed 4 years ago by git

  • Commit changed from e83d82a88cd0d7abb8e355658f675d66257de200 to 756ec6765ecb9dcec07318a5ce631fa862ec5e74

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

1ceba10Trac #19094/#19083 comment 66, 40: test conversion from multivariate polynomial ring
8006837Trac #19094/#19083 comment 66, 40: simplify test for empty data
4e5af11Trac #19094/#19083 comment 66, 36: delete ALGORITHM block
cb083d4Trac #19094/#19083 comment 66, 41: delete _create_exact_summands_ since not needed
cf228bbTrac #19094/#19083 comment 66, 42: make creating of exact summand with growth but without coefficient impossible
a848139Trac #19094/#19083 comment 66, 42: create_summands: add doctests for interesting `data`
de137d1Trac #19083: fix one ReSt error
f9fbccbTrac #19083: expand description of parameter "convert"
46af62dMerge branch 'u/cheuberg/asy/prototype' of trac.sagemath.org:sage into t/19305/asy/subs
756ec67Merge branch 'u/dkrenn/asy/subs' of trac.sagemath.org:sage into t/19306/asy/generators

comment:8 Changed 4 years ago by git

  • Commit changed from 756ec6765ecb9dcec07318a5ce631fa862ec5e74 to 7124f1385f271f9e563474da07e0dda4e19c777f

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

204e47cdocstrings of _substitute_ in term monoids
5cd22bfcomplete _substitute_ of asymptotic ring
9d3a6e3let __eq__ deal with noncomparable elements
5327238doctests: rewrite >>... to >...>
ef4ebb1rewrite main substitution method
2f434d7write doc and many doctests for substitute
975cea1Merge branch 't/19305/asy/subs' into t/19306/asy/generators
d08919cupdate copyright
fe5c176minor changes in docstrings
7124f13debug output (still work in progress)

comment:9 Changed 4 years ago by git

  • Commit changed from 7124f1385f271f9e563474da07e0dda4e19c777f to 532c41ce106ed691b6283f56611db3e08297b733

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

e4837e9correct parent of result of an_element
024ba1bMerge branch 'u/dkrenn/symbolic-subring' of trac.sagemath.org:sage into t/19306/asy/generators
f0c7440use symbolic constants subring (instead of SR)
0d6cce3remove automatic parenthesing in parent_to_repr_short
3f5e1b1fix bug in split_str_by_op
6e366a5binomial_kn_n: change to symbolic constants subring (WIP)
ae1877crename binomial* --> Binomial*
f0ab41adelete code of binomial* since it was
fd35046change base class to SageObject
532c41cwrite docstrings of Stirling generators

comment:10 Changed 4 years ago by dkrenn

  • Dependencies changed from #19305 to #19259, #19305

comment:11 Changed 4 years ago by dkrenn

  • Status changed from new to needs_review

comment:12 Changed 4 years ago by dkrenn

  • Authors set to Daniel Krenn

comment:13 Changed 4 years ago by cheuberg

  • Branch changed from u/dkrenn/asy/generators to u/cheuberg/asy/generators

comment:14 Changed 4 years ago by git

  • Commit changed from 532c41ce106ed691b6283f56611db3e08297b733 to a4c3f9d99c756c11a4c4be97e435eee1ff4511d9

Branch pushed to git repo; I updated commit sha1. New commits:

cc256c8Trac #19306: remove old code
31e4dc4Trac #19306: other variables than n
a3fad56Trac #19306: fix error terms for low precision
a4c3f9dTrac #19306: Fix low precision for Stirling

comment:15 follow-up: Changed 4 years ago by cheuberg

  • Milestone changed from sage-6.9 to sage-7.0
  • Reviewers set to Clemens Heuberger
  • Status changed from needs_review to needs_info

I reviewed this ticket (without looking at its dependency #19259). I added a commits, they need cross-review.

Two questions concerning misc.split_str_by_op:

  • Why += -1 instead of -= 1?
  • What is the purpose of the for...else construct: there is no break anyway.

comment:16 Changed 4 years ago by dkrenn

  • Branch changed from u/cheuberg/asy/generators to u/dkrenn/asy/generators

comment:17 in reply to: ↑ 15 Changed 4 years ago by dkrenn

  • Commit changed from a4c3f9d99c756c11a4c4be97e435eee1ff4511d9 to eac4977efef3ebebc16dce1cacf9c019dd4c236a
  • Status changed from needs_info to needs_review

Replying to cheuberg:

I reviewed this ticket (without looking at its dependency #19259). I added a commits, they need cross-review.

Done.

Two questions concerning misc.split_str_by_op:

  • Why += -1 instead of -= 1?

Changed.

  • What is the purpose of the for...else construct: there is no break anyway.

Changed. (else came from an old code)


New commits:

eac4977Trac #19306: minor changes (cross-review and incorporate reviewer comments)

comment:18 Changed 4 years ago by git

  • Commit changed from eac4977efef3ebebc16dce1cacf9c019dd4c236a to 946a828ef8c15933a0c67abb78190d958b3b1c8c

Branch pushed to git repo; I updated commit sha1. New commits:

946a828Trac #19306: change % to .format

comment:19 Changed 4 years ago by cheuberg

LGTM; consider this as a positive review modulo the dependency #19259.

comment:20 Changed 4 years ago by cheuberg

  • Branch changed from u/dkrenn/asy/generators to u/cheuberg/asy/generators

comment:21 Changed 4 years ago by cheuberg

  • Commit changed from 946a828ef8c15933a0c67abb78190d958b3b1c8c to 4d80eb34881599216582ea4fb4b5eed2db8a0be1
  • Milestone changed from sage-7.0 to sage-7.1
  • Status changed from needs_review to positive_review

#19259 is now positive, so this is positive, too.


New commits:

809d653Trac #19306: Merge tag '7.0' due to #19879
4d80eb3Trac #19306: sage.rings.arith -> sage.arith.all (after #19879)

comment:22 Changed 4 years ago by vbraun

  • Branch changed from u/cheuberg/asy/generators to 4d80eb34881599216582ea4fb4b5eed2db8a0be1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.