Opened 5 years ago
Closed 5 years ago
#19306 closed enhancement (fixed)
common generators for asymptotic expansions
Reported by:  dkrenn  Owned by:  

Priority:  major  Milestone:  sage7.1 
Component:  asymptotic expansions  Keywords:  
Cc:  behackl, cheuberg  Merged in:  
Authors:  Daniel Krenn  Reviewers:  Clemens Heuberger 
Report Upstream:  N/A  Work issues:  
Branch:  4d80eb3 (Commits)  Commit:  4d80eb34881599216582ea4fb4b5eed2db8a0be1 
Dependencies:  #19259, #19305  Stopgaps: 
Description (last modified by )
Implement common asymptotic expansion generators.
See also meta ticket #17601.
Change History (22)
comment:1 Changed 5 years ago by
 Dependencies set to #19305
comment:2 Changed 5 years ago by
 Branch set to u/dkrenn/asy/subs
comment:3 Changed 5 years ago by
 Branch changed from u/dkrenn/asy/subs to u/dkrenn/asy/generators
 Commit set to e83d82a88cd0d7abb8e355658f675d66257de200
comment:4 Changed 5 years ago by
 Description modified (diff)
comment:5 Changed 5 years ago by
 Description modified (diff)
comment:6 Changed 5 years ago by
 Summary changed from generators for asymptotic expansions to common generators for asymptotic expansions
comment:7 Changed 5 years ago by
 Commit changed from e83d82a88cd0d7abb8e355658f675d66257de200 to 756ec6765ecb9dcec07318a5ce631fa862ec5e74
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
1ceba10  Trac #19094/#19083 comment 66, 40: test conversion from multivariate polynomial ring

8006837  Trac #19094/#19083 comment 66, 40: simplify test for empty data

4e5af11  Trac #19094/#19083 comment 66, 36: delete ALGORITHM block

cb083d4  Trac #19094/#19083 comment 66, 41: delete _create_exact_summands_ since not needed

cf228bb  Trac #19094/#19083 comment 66, 42: make creating of exact summand with growth but without coefficient impossible

a848139  Trac #19094/#19083 comment 66, 42: create_summands: add doctests for interesting `data`

de137d1  Trac #19083: fix one ReSt error

f9fbccb  Trac #19083: expand description of parameter "convert"

46af62d  Merge branch 'u/cheuberg/asy/prototype' of trac.sagemath.org:sage into t/19305/asy/subs

756ec67  Merge branch 'u/dkrenn/asy/subs' of trac.sagemath.org:sage into t/19306/asy/generators

comment:8 Changed 5 years ago by
 Commit changed from 756ec6765ecb9dcec07318a5ce631fa862ec5e74 to 7124f1385f271f9e563474da07e0dda4e19c777f
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
204e47c  docstrings of _substitute_ in term monoids

5cd22bf  complete _substitute_ of asymptotic ring

9d3a6e3  let __eq__ deal with noncomparable elements

5327238  doctests: rewrite >>... to >...>

ef4ebb1  rewrite main substitution method

2f434d7  write doc and many doctests for substitute

975cea1  Merge branch 't/19305/asy/subs' into t/19306/asy/generators

d08919c  update copyright

fe5c176  minor changes in docstrings

7124f13  debug output (still work in progress)

comment:9 Changed 5 years ago by
 Commit changed from 7124f1385f271f9e563474da07e0dda4e19c777f to 532c41ce106ed691b6283f56611db3e08297b733
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
e4837e9  correct parent of result of an_element

024ba1b  Merge branch 'u/dkrenn/symbolicsubring' of trac.sagemath.org:sage into t/19306/asy/generators

f0c7440  use symbolic constants subring (instead of SR)

0d6cce3  remove automatic parenthesing in parent_to_repr_short

3f5e1b1  fix bug in split_str_by_op

6e366a5  binomial_kn_n: change to symbolic constants subring (WIP)

ae1877c  rename binomial* > Binomial*

f0ab41a  delete code of binomial* since it was

fd35046  change base class to SageObject

532c41c  write docstrings of Stirling generators

comment:10 Changed 5 years ago by
 Dependencies changed from #19305 to #19259, #19305
comment:11 Changed 5 years ago by
 Status changed from new to needs_review
comment:12 Changed 5 years ago by
comment:13 Changed 5 years ago by
 Branch changed from u/dkrenn/asy/generators to u/cheuberg/asy/generators
comment:14 Changed 5 years ago by
 Commit changed from 532c41ce106ed691b6283f56611db3e08297b733 to a4c3f9d99c756c11a4c4be97e435eee1ff4511d9
comment:15 followup: ↓ 17 Changed 5 years ago by
 Milestone changed from sage6.9 to sage7.0
 Reviewers set to Clemens Heuberger
 Status changed from needs_review to needs_info
I reviewed this ticket (without looking at its dependency #19259). I added a commits, they need crossreview.
Two questions concerning misc.split_str_by_op
:
 Why
+= 1
instead of= 1
?  What is the purpose of the
for...else
construct: there is nobreak
anyway.
comment:16 Changed 5 years ago by
 Branch changed from u/cheuberg/asy/generators to u/dkrenn/asy/generators
comment:17 in reply to: ↑ 15 Changed 5 years ago by
 Commit changed from a4c3f9d99c756c11a4c4be97e435eee1ff4511d9 to eac4977efef3ebebc16dce1cacf9c019dd4c236a
 Status changed from needs_info to needs_review
Replying to cheuberg:
I reviewed this ticket (without looking at its dependency #19259). I added a commits, they need crossreview.
Done.
Two questions concerning
misc.split_str_by_op
:
 Why
+= 1
instead of= 1
?
Changed.
 What is the purpose of the
for...else
construct: there is nobreak
anyway.
Changed. (else
came from an old code)
New commits:
eac4977  Trac #19306: minor changes (crossreview and incorporate reviewer comments)

comment:18 Changed 5 years ago by
 Commit changed from eac4977efef3ebebc16dce1cacf9c019dd4c236a to 946a828ef8c15933a0c67abb78190d958b3b1c8c
Branch pushed to git repo; I updated commit sha1. New commits:
946a828  Trac #19306: change % to .format

comment:19 Changed 5 years ago by
LGTM; consider this as a positive review modulo the dependency #19259.
comment:20 Changed 5 years ago by
 Branch changed from u/dkrenn/asy/generators to u/cheuberg/asy/generators
comment:21 Changed 5 years ago by
 Commit changed from 946a828ef8c15933a0c67abb78190d958b3b1c8c to 4d80eb34881599216582ea4fb4b5eed2db8a0be1
 Milestone changed from sage7.0 to sage7.1
 Status changed from needs_review to positive_review
comment:22 Changed 5 years ago by
 Branch changed from u/cheuberg/asy/generators to 4d80eb34881599216582ea4fb4b5eed2db8a0be1
 Resolution set to fixed
 Status changed from positive_review to closed
Last 10 new commits:
write doctests for coercions, common_parent, pushout
minor docstring rewriting of factory
subring in index.rst
simplify a doctest
change ValueError to TypeError to make everything work with SR as it should
typo in docstring
docstring of SR.subring
module description of subring
rename only_constants > no_variables
Merge branch 'u/dkrenn/symbolicsubring' of trac.sagemath.org:sage into u/dakrenn/asy/subs