Opened 5 years ago
Closed 5 years ago
#19305 closed enhancement (fixed)
substitution of asymptotic expansions
Reported by:  dkrenn  Owned by:  

Priority:  major  Milestone:  sage6.10 
Component:  asymptotic expansions  Keywords:  
Cc:  behackl, cheuberg  Merged in:  
Authors:  Daniel Krenn  Reviewers:  Clemens Heuberger 
Report Upstream:  N/A  Work issues:  
Branch:  bb7c104 (Commits)  Commit:  bb7c1046b3d7a7d4b18762028ee5230874582fcd 
Dependencies:  #19083  Stopgaps: 
Description (last modified by )
Insert an asymptotic expansion / a symbolic expression / whatever into an asymptotic expansion; method AsymptoticExpansion.subs
.
See also meta ticket #17601.
Change History (16)
comment:1 Changed 5 years ago by
 Description modified (diff)
comment:2 Changed 5 years ago by
 Description modified (diff)
comment:3 Changed 5 years ago by
 Work issues set to pull out code from #19306
comment:4 Changed 5 years ago by
 Branch set to u/dkrenn/asy/subs
comment:5 Changed 5 years ago by
 Commit set to 348b2483af1d85c4b8004e9c50f8879f1c76d3c2
 Work issues pull out code from #19306 deleted
comment:6 Changed 5 years ago by
 Commit changed from 348b2483af1d85c4b8004e9c50f8879f1c76d3c2 to 46af62db4bf480827d2f56261e643ab691b6efaa
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
7624627  Trac #19094/#19083 comment 66, 40: refer to trac tickets at OTerm from SR todo

1ceba10  Trac #19094/#19083 comment 66, 40: test conversion from multivariate polynomial ring

8006837  Trac #19094/#19083 comment 66, 40: simplify test for empty data

4e5af11  Trac #19094/#19083 comment 66, 36: delete ALGORITHM block

cb083d4  Trac #19094/#19083 comment 66, 41: delete _create_exact_summands_ since not needed

cf228bb  Trac #19094/#19083 comment 66, 42: make creating of exact summand with growth but without coefficient impossible

a848139  Trac #19094/#19083 comment 66, 42: create_summands: add doctests for interesting `data`

de137d1  Trac #19083: fix one ReSt error

f9fbccb  Trac #19083: expand description of parameter "convert"

46af62d  Merge branch 'u/cheuberg/asy/prototype' of trac.sagemath.org:sage into t/19305/asy/subs

comment:7 Changed 5 years ago by
 Commit changed from 46af62db4bf480827d2f56261e643ab691b6efaa to 2f434d7237bff661589d4fe75bf323cb9020a766
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
0fd249d  substitute_raise_exception: write docstring and tests

243a178  _substitute_ in growth groups: rewrite exceptions

17d0e2b  docstrings and tests in _substitute_ of growth groups

d2a599f  rewrite code of _substitute_ in term monoids

204e47c  docstrings of _substitute_ in term monoids

5cd22bf  complete _substitute_ of asymptotic ring

9d3a6e3  let __eq__ deal with noncomparable elements

5327238  doctests: rewrite >>... to >...>

ef4ebb1  rewrite main substitution method

2f434d7  write doc and many doctests for substitute

comment:8 Changed 5 years ago by
 Status changed from new to needs_review
comment:9 Changed 5 years ago by
 Dependencies set to #19083
 Milestone changed from sage6.9 to sage6.10
comment:10 Changed 5 years ago by
 Branch changed from u/dkrenn/asy/subs to u/cheuberg/asy/subs
comment:11 Changed 5 years ago by
 Commit changed from 2f434d7237bff661589d4fe75bf323cb9020a766 to bb7c1046b3d7a7d4b18762028ee5230874582fcd
comment:12 followup: ↓ 13 Changed 5 years ago by
 Reviewers set to Clemens Heuberger
 Status changed from needs_review to positive_review
Code seems to be fine; doctests pass, documentation builds. I have added two trivial commits.
comment:13 in reply to: ↑ 12 Changed 5 years ago by
Replying to cheuberg:
I have added two trivial commits.
Thanks; crossreviewed them, they look fine.
comment:14 followup: ↓ 15 Changed 5 years ago by
I think you may need to resolve the merge conflict, else the positive status will last a long time...
comment:15 in reply to: ↑ 14 Changed 5 years ago by
Replying to rws:
I think you may need to resolve the merge conflict, else the positive status will last a long time...
There is no merge conflict.
Trac's automerge sometimes yields false positives and colors a branch in red, but this is due to the fact that it does not use the "real" git for merging ...
comment:16 Changed 5 years ago by
 Branch changed from u/cheuberg/asy/subs to bb7c1046b3d7a7d4b18762028ee5230874582fcd
 Resolution set to fixed
 Status changed from positive_review to closed
Last 10 new commits:
revert changes in base_ring of category_object and adapt doctests
Merge remotetracking branch 'trac/u/dkrenn/18182/pushout' into t/19073/asy/groupscoercion
Merge branch 't/19073/asy/groupscoercion' into t/19094/asy/ringexplog
Merge remotetracking branch 'origin/u/dkrenn/asy/ringexplog' into t/19094/asy/ringexplog
Merge branch 't/19094/asy/ringexplog' into t/19083/asy/prototype
rename title
Merge remotetracking branch 'origin/u/dkrenn/asy/prototype' into t/19083/asy/prototype
fix bug (tower has only one entry which is None)
Merge branch 'u/dkrenn/18182/pushout' of trac.sagemath.org:sage into t/19083/asy/prototype
Merge remotetracking branch 'origin/u/dkrenn/asy/prototype' into u/dakrenn/asy/subs