Opened 4 years ago

Closed 4 years ago

#19305 closed enhancement (fixed)

substitution of asymptotic expansions

Reported by: dkrenn Owned by:
Priority: major Milestone: sage-6.10
Component: asymptotic expansions Keywords:
Cc: behackl, cheuberg Merged in:
Authors: Daniel Krenn Reviewers: Clemens Heuberger
Report Upstream: N/A Work issues:
Branch: bb7c104 (Commits) Commit: bb7c1046b3d7a7d4b18762028ee5230874582fcd
Dependencies: #19083 Stopgaps:

Description (last modified by dkrenn)

Insert an asymptotic expansion / a symbolic expression / whatever into an asymptotic expansion; method AsymptoticExpansion.subs.

See also meta ticket #17601.

Change History (16)

comment:1 Changed 4 years ago by dkrenn

  • Description modified (diff)

comment:2 Changed 4 years ago by dkrenn

  • Description modified (diff)

comment:3 Changed 4 years ago by dkrenn

  • Work issues set to pull out code from #19306

comment:4 Changed 4 years ago by dkrenn

  • Branch set to u/dkrenn/asy/subs

comment:5 Changed 4 years ago by dkrenn

  • Commit set to 348b2483af1d85c4b8004e9c50f8879f1c76d3c2
  • Work issues pull out code from #19306 deleted

Last 10 new commits:

60b9375revert changes in base_ring of category_object and adapt doctests
8d6de43Merge remote-tracking branch 'trac/u/dkrenn/18182/pushout' into t/19073/asy/groups-coercion
d50cc55Merge branch 't/19073/asy/groups-coercion' into t/19094/asy/ring-exp-log
44fbcccMerge remote-tracking branch 'origin/u/dkrenn/asy/ring-exp-log' into t/19094/asy/ring-exp-log
09032eeMerge branch 't/19094/asy/ring-exp-log' into t/19083/asy/prototype
2e4a415rename title
b0e228bMerge remote-tracking branch 'origin/u/dkrenn/asy/prototype' into t/19083/asy/prototype
c16587cfix bug (tower has only one entry which is None)
1109ce0Merge branch 'u/dkrenn/18182/pushout' of trac.sagemath.org:sage into t/19083/asy/prototype
348b248Merge remote-tracking branch 'origin/u/dkrenn/asy/prototype' into u/dakrenn/asy/subs

comment:6 Changed 4 years ago by git

  • Commit changed from 348b2483af1d85c4b8004e9c50f8879f1c76d3c2 to 46af62db4bf480827d2f56261e643ab691b6efaa

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

7624627Trac #19094/#19083 comment 66, 40: refer to trac tickets at O-Term from SR todo
1ceba10Trac #19094/#19083 comment 66, 40: test conversion from multivariate polynomial ring
8006837Trac #19094/#19083 comment 66, 40: simplify test for empty data
4e5af11Trac #19094/#19083 comment 66, 36: delete ALGORITHM block
cb083d4Trac #19094/#19083 comment 66, 41: delete _create_exact_summands_ since not needed
cf228bbTrac #19094/#19083 comment 66, 42: make creating of exact summand with growth but without coefficient impossible
a848139Trac #19094/#19083 comment 66, 42: create_summands: add doctests for interesting `data`
de137d1Trac #19083: fix one ReSt error
f9fbccbTrac #19083: expand description of parameter "convert"
46af62dMerge branch 'u/cheuberg/asy/prototype' of trac.sagemath.org:sage into t/19305/asy/subs

comment:7 Changed 4 years ago by git

  • Commit changed from 46af62db4bf480827d2f56261e643ab691b6efaa to 2f434d7237bff661589d4fe75bf323cb9020a766

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

0fd249dsubstitute_raise_exception: write docstring and tests
243a178_substitute_ in growth groups: rewrite exceptions
17d0e2bdocstrings and tests in _substitute_ of growth groups
d2a599frewrite code of _substitute_ in term monoids
204e47cdocstrings of _substitute_ in term monoids
5cd22bfcomplete _substitute_ of asymptotic ring
9d3a6e3let __eq__ deal with noncomparable elements
5327238doctests: rewrite >>... to >...>
ef4ebb1rewrite main substitution method
2f434d7write doc and many doctests for substitute

comment:8 Changed 4 years ago by dkrenn

  • Authors set to Daniel Krenn
  • Status changed from new to needs_review

comment:9 Changed 4 years ago by cheuberg

  • Dependencies set to #19083
  • Milestone changed from sage-6.9 to sage-6.10

comment:10 Changed 4 years ago by cheuberg

  • Branch changed from u/dkrenn/asy/subs to u/cheuberg/asy/subs

comment:11 Changed 4 years ago by git

  • Commit changed from 2f434d7237bff661589d4fe75bf323cb9020a766 to bb7c1046b3d7a7d4b18762028ee5230874582fcd

Branch pushed to git repo; I updated commit sha1. New commits:

e4f2a9dTrac #19305: simpler doctest
bb7c104Trac #19305: do not use variable "e" as it is special in asymptotics

comment:12 follow-up: Changed 4 years ago by cheuberg

  • Reviewers set to Clemens Heuberger
  • Status changed from needs_review to positive_review

Code seems to be fine; doctests pass, documentation builds. I have added two trivial commits.

comment:13 in reply to: ↑ 12 Changed 4 years ago by dkrenn

Replying to cheuberg:

I have added two trivial commits.

Thanks; cross-reviewed them, they look fine.

comment:14 follow-up: Changed 4 years ago by rws

I think you may need to resolve the merge conflict, else the positive status will last a long time...

EDIT: #19073 and #19083 as well.

Last edited 4 years ago by rws (previous) (diff)

comment:15 in reply to: ↑ 14 Changed 4 years ago by cheuberg

Replying to rws:

I think you may need to resolve the merge conflict, else the positive status will last a long time...

EDIT: #19073 and #19083 as well.

There is no merge conflict.

Trac's automerge sometimes yields false positives and colors a branch in red, but this is due to the fact that it does not use the "real" git for merging ...

Last edited 4 years ago by cheuberg (previous) (diff)

comment:16 Changed 4 years ago by vbraun

  • Branch changed from u/cheuberg/asy/subs to bb7c1046b3d7a7d4b18762028ee5230874582fcd
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.