Opened 6 years ago

Closed 6 years ago

#19298 closed enhancement (fixed)

Require C++11 in Sage

Reported by: rws Owned by:
Priority: major Milestone: sage-6.10
Component: build: configure Keywords:
Cc: ncohen, fbissey Merged in:
Authors: Jeroen Demeyer Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: 298ea50 (Commits, GitHub, GitLab) Commit: 298ea502e737df767ee4341761d9eff149a88cb4
Dependencies: #19292, #19293, #19313 Stopgaps:

Status badges

Description (last modified by rws)

Several packages need C++11:

They need different subsets of C++11. The first full featured C++11 gcc version is 4.8.1. The version shipped with Sage at the moment is 4.9.2. This ticket should implement install/usage of Sage's gcc if the native gcc version is less than 4.8.1. The resp. package tickets will depend on this ticket and activate the C++11 switch in their compile process.

Change History (15)

comment:1 Changed 6 years ago by rws

diff --git a/configure.ac b/configure.ac
index 5e320f7..ed26013 100644
--- a/configure.ac
+++ b/configure.ac
@@ -214,6 +214,10 @@ else
                     echo >&2 "gcc-4.7.0 has a serious bug on ia64."
                     need_to_install_gcc=yes
                 fi;;
+            4.7.*|4.8.0)
+                # GCC 4.8.1 is needed because Sage requires C++11
+                echo >&2 "Installing GCC because you have $CXX version $GCCVERSION, and Sage needs 4.8.1 for full C++11 support."
+                need_to_install_gcc=yes;;
         esac
     fi
 

I don't understand. With this patch and make it will start to build gcc (toolchain) although my native gcc is 4.8.3.

comment:2 Changed 6 years ago by jdemeyer

Can you please be more concrete? Because I find this too vague: "In #18323 and in a recent thread packages were identified"

comment:3 Changed 6 years ago by rws

  • Description modified (diff)

comment:4 Changed 6 years ago by jdemeyer

  • Description modified (diff)
  • Summary changed from require C++11 in Sage to Require C++11 in Sage

Is there a ticket for Pynac?

comment:5 Changed 6 years ago by jdemeyer

  • Priority changed from critical to major

comment:6 Changed 6 years ago by jdemeyer

  • Component changed from build to build: configure

comment:7 Changed 6 years ago by ncohen

  • Cc ncohen added

comment:8 Changed 6 years ago by rws

  • Description modified (diff)

comment:9 Changed 6 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Dependencies set to #19292, #19293, #19313
  • Milestone changed from sage-6.9 to sage-pending

comment:10 Changed 6 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/19298

comment:11 Changed 6 years ago by jdemeyer

  • Commit set to 298ea502e737df767ee4341761d9eff149a88cb4
  • Status changed from new to needs_review

New commits:

47e33daDo not source sage-env in configure
1c0e2f9Move generation of build/make/Makefile down in configure.ac
f7b20daReorganize compiler checks in proper autoconf style
9d21de9Double-quote character ranges
bf6f911Quote $1
298ea50Add check for C++11

comment:12 Changed 6 years ago by fbissey

  • Cc fbissey added

comment:13 Changed 6 years ago by vbraun

  • Reviewers set to Volker Braun
  • Status changed from needs_review to positive_review

lgtm

comment:14 Changed 6 years ago by rws

  • Milestone changed from sage-pending to sage-6.10

comment:15 Changed 6 years ago by vbraun

  • Branch changed from u/jdemeyer/ticket/19298 to 298ea502e737df767ee4341761d9eff149a88cb4
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.