Opened 6 years ago

Closed 6 years ago

#19260 closed defect (fixed)

documentation fix in tilings.py

Reported by: tmonteil Owned by:
Priority: major Milestone: sage-6.9
Component: documentation Keywords:
Cc: slabbe Merged in:
Authors: Thierry Monteil Reviewers: Nathann Cohen
Report Upstream: N/A Work issues:
Branch: c4ca8d4 (Commits, GitHub, GitLab) Commit: c4ca8d462014b464bfe539fe6c7682d36b2c89c6
Dependencies: Stopgaps:

Status badges

Description (last modified by tmonteil)

In the doc of combinat/tiling.py, the coordinates are required to be positive, while they should only be required to be nonnegative.

Change History (7)

comment:1 Changed 6 years ago by tmonteil

  • Branch set to u/tmonteil/documentation_fix_in_tilings_py

comment:2 Changed 6 years ago by tmonteil

  • Authors set to Thierry Monteil
  • Cc slabbe added
  • Commit set to c4ca8d462014b464bfe539fe6c7682d36b2c89c6
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

c4ca8d4#19260 : positive -> nonnegative.

comment:3 Changed 6 years ago by ncohen

  • Reviewers set to Nathann Cohen
  • Status changed from needs_review to positive_review

You people need something to keep you busy.

Nathann

comment:4 Changed 6 years ago by slabbe

Anyways, it was code to keep me busy:) http://planet.sagemath.org/

comment:5 Changed 6 years ago by ncohen

Wow, nice blog entry ;-)

comment:6 Changed 6 years ago by slabbe

I think this ticket will create a conflict with #19107. It might be easier for me to fix this inside #19107 rather than rebase my branch...

This has already been positively reviewed... Is it too late?

comment:7 Changed 6 years ago by vbraun

  • Branch changed from u/tmonteil/documentation_fix_in_tilings_py to c4ca8d462014b464bfe539fe6c7682d36b2c89c6
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.