LinearCode.basis() should be an immutable Sequence

[ncohen]

Right now the .basis() method returns just a list. This should instead be an immutable Sequence, retaining the type information in its .universe() method.

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​f49c204

trac #19251: A real matrix as LinearCode.basis()

[dlucas]

Hello,

Just a question: if you're not adding a deprecation warning to this (which I agree with), what do you think about adding extra info to the docstring, like "Returns a basis of self as a matrix of the ambient space of self"?

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​6cc755d

trac #19251: Better description

[ncohen]

Here it is!

Nathann

[dlucas]

Great!

As all tests pass, I'm giving the green bulb.

David

[ncohen]

Thanks!

[vbraun]

Doctests fail.

Also, a matrix is not a basis. Matrices have row and column spans, its not clear which one you mean if you just return a matrix. This is how it is supposed to work:

sage: (QQ^3).span([(1,2,3)]).basis()
[
(1, 2, 3)
]
sage: _.universe()
Vector space of degree 3 and dimension 1 over Rational Field
Basis matrix:
[1 2 3]

[ncohen]

Never discuss with a release manager.

Nathann

[jsrn]

There's still something of a bug, though, since the type returned by LinearCode.basis() is list, while what Volker writes about is a Sequence_generic, which exactly supports the universe method.

[vbraun]

+1 to returning an immutable Sequence instead of a list... are you going to implement that?

[jsrn]

Ok, I'm on it...

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​7e0416d	Revert basis() returning a matrix to returning a list
​91114c5	LinearCode.basis() returns a Sequence

[kdilks]

One failing test in documentation due to formatting.

File "src/doc/en/prep/Quickstarts/Graphs-and-Discrete.rst", line 325, in doc.en.prep.Quickstarts.Graphs-and-Discrete
Failed example:
    D.basis()
Expected:
    [(1, 0, 1, 0, 1, 0, 1), (0, 1, 1, 0, 0, 1, 1), (0, 0, 0, 1, 1, 1, 1)]
Got:
    [
    (1, 0, 1, 0, 1, 0, 1),
    (0, 1, 1, 0, 0, 1, 1),
    (0, 0, 0, 1, 1, 1, 1)
    ]

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​9ccbb3e	Merge remote-tracking branch 'trac/develop' into t/19251/public/19251
​69fb5c4	Fixed doctest in documentation text

[jsrn]

Missed that one - thanks. Rebased and doctest fixed.

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​b3dc9bf

fixed conflict

[danielaugot]

Hi

this is perfectly immutable in my session. Nevertheless, I add to resolve a conflict when pulling.

I set it to positive review

Daniel