Opened 4 years ago

Closed 4 years ago

#19248 closed enhancement (fixed)

Add declarations for gmp/mpir C++ classes

Reported by: jdemeyer Owned by:
Priority: minor Milestone: sage-6.9
Component: cython Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Vincent Delecroix
Report Upstream: N/A Work issues:
Branch: cb46337 (Commits) Commit: cb4633782fc4cc57f02b5212ea3e8973cbeeb289
Dependencies: Stopgaps:

Description

We should add declarations for mpz_class and mpq_class in the usual place and use them. I also do some trivial Cython cleanup.

Change History (7)

comment:1 Changed 4 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/19248

comment:2 Changed 4 years ago by git

  • Commit set to cb4633782fc4cc57f02b5212ea3e8973cbeeb289

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

cb46337Add declarations for gmp/mpir C++ classes

comment:3 Changed 4 years ago by jdemeyer

  • Status changed from new to needs_review

comment:4 follow-up: Changed 4 years ago by vdelecroix

Is that fine to remove the libraries keyword from Extension? Some people complained that it is mandatory under Cygwin. Declaring # distutils: libraries = gmpxx gmp in the corresponding .pyx file is enough to make them happy?

comment:5 in reply to: ↑ 4 Changed 4 years ago by jdemeyer

Replying to vdelecroix:

Declaring # distutils: libraries = gmpxx gmp in the corresponding .pyx file is enough to make them happy?

Yes, it's really the same. However, the # distutils thing is better because it's more local (you declare the library in the actual files which need it).

comment:6 Changed 4 years ago by vdelecroix

  • Reviewers set to Vincent Delecroix
  • Status changed from needs_review to positive_review

comment:7 Changed 4 years ago by vbraun

  • Branch changed from u/jdemeyer/ticket/19248 to cb4633782fc4cc57f02b5212ea3e8973cbeeb289
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.