Rename matrix_mod2e_dense to matrix_gf2e_dense

[jdemeyer]

The name matrix_mod2e_dense suggests that it's about matrices in ZZ/(2^e)ZZ, while it's really for matrices in GF(2^e).

Since the module and class names are non-public implementation details, there is no need for deprecation.

[jdemeyer]

New commits:

​1e6264d

Rename matrix_mod2e_dense to matrix_gf2e_dense

[SimonKing]

Even if you think that no deprecation is needed, I do believe that it is at least needed to be able to read old pickles of matrices over GF(2^e). Users are likely to have those stored somewhere, as part of ubiquitous applications.

I don't see how you take care of that in your commit.

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​fec4bf1

Fix unpickling old Matrix_mod2e_dense instances

[git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​26f359e

Fix unpickling old Matrix_mod2e_dense instances

[SimonKing]

Apparently there is a malformed docstring:

Error building the documentation.
Traceback (most recent call last):
  File "/home/king/Sage/git/sage/src/doc/common/builder.py", line 1626, in <module>
    getattr(get_builder(name), type)()
  File "/home/king/Sage/git/sage/src/doc/common/builder.py", line 292, in _wrapper
    getattr(get_builder(document), 'inventory')(*args, **kwds)
  File "/home/king/Sage/git/sage/src/doc/common/builder.py", line 503, in _wrapper
    x.get(99999)
  File "/home/king/Sage/git/sage/local/lib/python/multiprocessing/pool.py", line 558, in get
    raise self._value
OSError: [matrices ] docstring of sage.matrix.matrix_gf2e_dense.unpickle_matrix_gf2e_dense_v0:15: WARNING: Block quote ends without a blank line; unexpected unindent.

I try to fix it.

[SimonKing]

Done. Turn """ into r""".

[SimonKing]

Why is trac automatically changing the branch back to the old value?? Odd.

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​1e47929

Change old into new style raise statement

[SimonKing]

You didn't actually *introduce* the old-style raise statements that the plugin is complaining about, but anyway I'm fixing them...

[SimonKing]

Since tests pass and the code and docstrings now seem fine, I'm giving it a positive review.

Unless of course you don't like my reviewer commits, or unless you worry about the patchbot reporting a slowdown in startup time (which I find hard to believe, given that you merely rename a module).