Opened 3 years ago

Closed 3 years ago

#19216 closed enhancement (fixed)

Suzuki-related strongly regular graphs

Reported by: ncohen Owned by:
Priority: major Milestone: sage-6.9
Component: graph theory Keywords:
Cc: dimpase Merged in:
Authors: Nathann Cohen Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: 262998b (Commits) Commit: 262998b25997a8a60d62df98e2175f2f0ae067d1
Dependencies: #19184 Stopgaps:

Description

This ticket adds several Suzuki-related groups and graphs.

Change History (13)

comment:1 Changed 3 years ago by ncohen

  • Branch set to public/19216
  • Commit set to 6c56dda4eda61ae53bb683e22838f877ed1724ca
  • Status changed from new to needs_review

New commits:

006fa91trac #19184: HigmanSims design
a380d6dtrac #19184: SRG on 105 vertices for L(3,4)
6c56ddatrac #19216: Suzuki-related strongly regular graphs

comment:2 Changed 3 years ago by dimpase

this seems to be the place where using GAP instead of libGAP makes things much slower...

comment:3 Changed 3 years ago by dimpase

also, if we care about being fast, the faster way to build the graph on 416 vertices is from its automorphism group, which is available as Atlas group:

http://brauer.maths.qmul.ac.uk/Atlas/v3/exc/G24/

comment:4 Changed 3 years ago by git

  • Commit changed from 6c56dda4eda61ae53bb683e22838f877ed1724ca to 9fac0299c28a614d5d1ed797fd8cef0e36d5e19d

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

848a972trac #19184: the SRG at last !
fbe7bb9trac #19184: Broken doctest
2ceb7eeMerge branch 'public/19184' of git://trac.sagemath.org/sage into hs
a0eabd4cite [BvL84]
c07f2bcno need to take complement
994aa33SRG on 105 vertices for L(3,4)
8d615c2less crude code in SRG_176_49_12_14
717e356Merge branch 'public/19184' of git://trac.sagemath.org/sage into hs
e8c2668Merge remote-tracking branch 'trac/public/19216' into suz
9fac0293.5-fold speedup of SRG_560 using libgap

comment:5 Changed 3 years ago by git

  • Commit changed from 9fac0299c28a614d5d1ed797fd8cef0e36d5e19d to 4d8c73320da8c11d0be4e9474f5a0dfc87944a01

Branch pushed to git repo; I updated commit sha1. New commits:

4d8c733optimised constuction of SRG_416_100_36_20 and added SRG_144_39_6_12

comment:6 follow-up: Changed 3 years ago by ncohen

Merging this branch with the NO/NU branch was unnecessary (as was probably proved by the fact that there was no conflict) and results in a very unclean history, that I find very hard to read if I have to review the commits that you added.

comment:7 Changed 3 years ago by ncohen

  • Branch changed from public/19216 to u/ncohen/19216
  • Commit changed from 4d8c73320da8c11d0be4e9474f5a0dfc87944a01 to 262998b25997a8a60d62df98e2175f2f0ae067d1

I pushed back my original branch, on top of which I cherry-picked (git terminology) what I believe to be the only two commits that you added that are related to this branch. I also updated their message so that it contains the ticket number (please do this in the future).

I did not overwrite public/19216 but pushed everything to u/ncohen/19216, you can thus find your old branch if you need it. In the future, however, please ask me whenever you want to see one of my tickets merged with something else, as by doing it yourself you give me much more work.

I agree with your two commits, and I thank you for the improvements and addition. You also told me often to use libgap, and I often forget to. Sorry for that.

Please check that I did not miss any of the commits you wanted to see here, and set the ticket to positive_review if you agree with it. Please fill your name in the 'reviewer' field, or Volker will invalidate the ticket.

Nathann


New commits:

b049232trac #19216: 3.5-fold speedup of SRG_560 using libgap
262998btrac #19216: optimised constuction of SRG_416_100_36_20 and added SRG_144_39_6_12

comment:8 in reply to: ↑ 6 Changed 3 years ago by dimpase

Replying to ncohen:

Merging this branch with the NO/NU branch was unnecessary (as was probably proved by the fact that there was no conflict) and results in a very unclean history, that I find very hard to read if I have to review the commits that you added.

Apologies. Probably my develop branch is messed up, and messing up anything on top of it. Anyhow, I did not overwrite anything this time. (I looked what I did, and I merged it over Higman-Sims design ticket, as I didn't want to trigger a big recompile, and then, when I decided to add/change stuff, I forgot about it... :-[)

Last edited 3 years ago by dimpase (previous) (diff)

comment:9 Changed 3 years ago by dimpase

  • Reviewers set to Dima Pasechnik
  • Status changed from needs_review to positive_review

comment:10 Changed 3 years ago by dimpase

by the way, how about reorganising the source of strongly_regular_db: namely, moving all the graph constructions out of there, say, to generators/srg.py(x) ?

comment:11 Changed 3 years ago by ncohen

Hmmmmm... Everything in "generators/" is usually exposed in graphs.<tab>, and in this case I am not sure that we want that.

To me having this stuff in this file means that it is not very important of its own. What about only reorganizing the file by moving all the graph constructors at the end of it? It does not bother me much personally.

Nathann

comment:12 Changed 3 years ago by ncohen

Thank you for this review, by the way.

Nathann

comment:13 Changed 3 years ago by vbraun

  • Branch changed from u/ncohen/19216 to 262998b25997a8a60d62df98e2175f2f0ae067d1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.