Opened 5 years ago

Closed 5 years ago

#19194 closed defect (fixed)

doctest fix for inconsistencies with dbgprinttree of functions

Reported by: rws Owned by:
Priority: minor Milestone: sage-7.3
Component: symbolics Keywords:
Cc: Merged in:
Authors: Ralf Stephan Reviewers: Paul Masson
Report Upstream: N/A Work issues:
Branch: ee8d669 (Commits, GitHub, GitLab) Commit: ee8d669ba1d0475c434ae0e9b752320f032bd7d9
Dependencies: #18980 Stopgaps:

Status badges

Description 

sage: f=function('f')(x)
sage: f._dbgprint()
f(x)
sage: f._dbgprinttree()
f(x)sa(sin(x))._dbgprinttree()             <=========== sic!
function sin @0x38eccd0, hash=0x7fff, flags=0x3, nops=1
    x (symbol) @0x2a00bf0, serial=6, hash=0x4eb55146, flags=0xf, domain=0
    =====
sage: (f(x))._dbgprinttree()
/home/ralf/sage/local/lib/python2.7/site-packages/IPython/core/interactiveshell.py:3035: DeprecationWarning: Substitution using function-call syntax and unnamed arguments is deprecated and will be removed from a future release of Sage; you can use named arguments instead, like EXPR(x=..., y=...)
See http://trac.sagemath.org/5930 for details.
  exec(code_obj, self.user_global_ns, self.user_ns)
f(x)sage: (f(x))
f(x)

So a newline is missing somewhere and user-defined functions have no debug output at all.

​https://github.com/pynac/pynac/issues/93

Change History (4)

comment:1 Changed 5 years ago by rws

  • Branch set to u/rws/inconsistencies_with_dbgprinttree_of_functions

comment:2 Changed 5 years ago by rws

  • Authors set to Ralf Stephan
  • Commit set to ee8d669ba1d0475c434ae0e9b752320f032bd7d9
  • Dependencies changed from pynac-0.3.9.4 to #18980
  • Report Upstream changed from Fixed upstream, in a later stable release. to N/A
  • Status changed from new to needs_review
  • Summary changed from inconsistencies with dbgprinttree of functions to doctest fix for inconsistencies with dbgprinttree of functions

New commits:

​ee8d66919194: doctest fix for inconsistencies with dbgprinttree of functions

comment:3 Changed 5 years ago by paulmasson

  • Milestone changed from sage-6.9 to sage-7.3
  • Reviewers set to Paul Masson
  • Status changed from needs_review to positive_review

Doctests all pass. Since this ticket just adds a doctest, it looks good to go.

comment:4 Changed 5 years ago by vbraun

  • Branch changed from u/rws/inconsistencies_with_dbgprinttree_of_functions to ee8d669ba1d0475c434ae0e9b752320f032bd7d9
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.