Sage: Ticket #19190: LatticePoset: add atoms, coatoms, doubly irreducibles etc.
https://trac.sagemath.org/ticket/19190
<p>
Add <code>atoms()</code>, <code>coatoms()</code>, and <code>doubly_irreducibles()</code> to finite lattices.
</p>
en-usSagehttps://trac.sagemath.org/chrome/site/logo_sagemath_trac.png
https://trac.sagemath.org/ticket/19190
Trac 1.1.6jmantysaloSat, 19 Sep 2015 10:09:14 GMTdescription changed
https://trac.sagemath.org/ticket/19190#comment:1
https://trac.sagemath.org/ticket/19190#comment:1
<ul>
<li><strong>description</strong>
modified (<a href="/ticket/19190?action=diff&version=1">diff</a>)
</li>
</ul>
TicketjmantysaloSat, 19 Sep 2015 12:47:47 GMTdescription, summary changed
https://trac.sagemath.org/ticket/19190#comment:2
https://trac.sagemath.org/ticket/19190#comment:2
<ul>
<li><strong>description</strong>
modified (<a href="/ticket/19190?action=diff&version=2">diff</a>)
</li>
<li><strong>summary</strong>
changed from <em>LatticePoset: add atoms, coatoms, doubly irreducibles</em> to <em>LatticePoset: add atoms, coatoms, doubly irreducibles etc.</em>
</li>
</ul>
TicketjmantysaloWed, 13 Apr 2016 13:19:13 GMTbranch set
https://trac.sagemath.org/ticket/19190#comment:3
https://trac.sagemath.org/ticket/19190#comment:3
<ul>
<li><strong>branch</strong>
set to <em>u/jmantysalo/latticeposet__add_atoms__coatoms__doubly_irreducibles_etc_</em>
</li>
</ul>
TicketjmantysaloWed, 13 Apr 2016 13:21:31 GMTkeywords, status, description, milestone changed; commit set
https://trac.sagemath.org/ticket/19190#comment:4
https://trac.sagemath.org/ticket/19190#comment:4
<ul>
<li><strong>keywords</strong>
<em>latticeposet</em> added; <em>poset</em> removed
</li>
<li><strong>commit</strong>
set to <em>429b494b5f553952bf6ed88fe1f1d9dc744d2f15</em>
</li>
<li><strong>status</strong>
changed from <em>new</em> to <em>needs_review</em>
</li>
<li><strong>description</strong>
modified (<a href="/ticket/19190?action=diff&version=4">diff</a>)
</li>
<li><strong>milestone</strong>
changed from <em>sage-wishlist</em> to <em>sage-7.2</em>
</li>
</ul>
<p>
This patch will add three functions. Also this will make <code>LatticePoset()</code> to return the empty lattice; compare to <code>Poset()</code>.
</p>
<hr />
<p>
New commits:
</p>
<table class="wiki">
<tr><td><a class="ext-link" href="http://git.sagemath.org/sage.git/commit/?id=429b494b5f553952bf6ed88fe1f1d9dc744d2f15"><span class="icon"></span>429b494</a></td><td><code>Add atoms() etc.</code>
</td></tr></table>
TickettscrimWed, 13 Apr 2016 13:31:03 GMT
https://trac.sagemath.org/ticket/19190#comment:5
https://trac.sagemath.org/ticket/19190#comment:5
<p>
On my to-review list.
</p>
TickettscrimTue, 19 Apr 2016 14:20:01 GMTcommit, branch changed; reviewer set
https://trac.sagemath.org/ticket/19190#comment:6
https://trac.sagemath.org/ticket/19190#comment:6
<ul>
<li><strong>commit</strong>
changed from <em>429b494b5f553952bf6ed88fe1f1d9dc744d2f15</em> to <em>aa58591d18e75fd32ae3465a710c1d270e4d9e1f</em>
</li>
<li><strong>branch</strong>
changed from <em>u/jmantysalo/latticeposet__add_atoms__coatoms__doubly_irreducibles_etc_</em> to <em>public/posets/add_methods-19190</em>
</li>
<li><strong>reviewer</strong>
set to <em>Travis Scrimshaw</em>
</li>
</ul>
<p>
I did some (additional) touchups to the finite lattice category and minor tweaks. While I still prefer <code>``self``</code> over <code>this lattice</code>, <code>the lattice</code> is not correct as there is not a unique lattice. If you agree with my changes, then go ahead and set a positive review.
</p>
<hr />
<p>
New commits:
</p>
<table class="wiki">
<tr><td><a class="ext-link" href="http://git.sagemath.org/sage.git/commit/?id=376adfb05aab8454ea28a13986988149d84392cb"><span class="icon"></span>376adfb</a></td><td><code>Some cleanup in the category docstrings.</code>
</td></tr><tr><td><a class="ext-link" href="http://git.sagemath.org/sage.git/commit/?id=aa58591d18e75fd32ae3465a710c1d270e4d9e1f"><span class="icon"></span>aa58591</a></td><td><code>Some touchups of lattices.py.</code>
</td></tr></table>
TicketjmantysaloWed, 20 Apr 2016 05:45:28 GMT
https://trac.sagemath.org/ticket/19190#comment:7
https://trac.sagemath.org/ticket/19190#comment:7
<p>
In html documentation "See also: <a class="missing wiki">FinitePosets?</a>, <a class="missing wiki">LatticePosets?</a>, <a class="missing wiki">LatticePoset?</a>" the "<a class="missing wiki">LatticePoset?</a>" is a broken link. Where is it supposed to point?
</p>
<p>
About "the": I don't understand. For example docstring for <code>cardinality()</code> is "Return the number of elements in <em>the</em> poset." I have think that "the" means about same as "this" in that sentence.
</p>
TicketjmantysaloWed, 20 Apr 2016 05:46:50 GMT
https://trac.sagemath.org/ticket/19190#comment:8
https://trac.sagemath.org/ticket/19190#comment:8
<p>
Btw, I run doctests and they were successfull. So patchbots again give false errors.
</p>
TicketjmantysaloSat, 23 Apr 2016 12:58:03 GMTstatus changed
https://trac.sagemath.org/ticket/19190#comment:9
https://trac.sagemath.org/ticket/19190#comment:9
<ul>
<li><strong>status</strong>
changed from <em>needs_review</em> to <em>positive_review</em>
</li>
</ul>
<p>
Anyways, Sage with this patch is better than without, hence I mark this as <em>positive_review</em>.
</p>
<p>
Broken links are more general problem. Nathann give one suggestion at <a class="closed ticket" href="https://trac.sagemath.org/ticket/20095" title="enhancement: Report broken links in the doc of graphs/ (closed: fixed)">#20095</a>, but that should be talked separately.
</p>
TicketvbraunSat, 23 Apr 2016 19:52:39 GMTstatus, branch changed; resolution set
https://trac.sagemath.org/ticket/19190#comment:10
https://trac.sagemath.org/ticket/19190#comment:10
<ul>
<li><strong>status</strong>
changed from <em>positive_review</em> to <em>closed</em>
</li>
<li><strong>resolution</strong>
set to <em>fixed</em>
</li>
<li><strong>branch</strong>
changed from <em>public/posets/add_methods-19190</em> to <em>aa58591d18e75fd32ae3465a710c1d270e4d9e1f</em>
</li>
</ul>
TickettscrimSat, 23 Apr 2016 21:54:37 GMTcommit deleted
https://trac.sagemath.org/ticket/19190#comment:11
https://trac.sagemath.org/ticket/19190#comment:11
<ul>
<li><strong>commit</strong>
<em>aa58591d18e75fd32ae3465a710c1d270e4d9e1f</em> deleted
</li>
</ul>
<p>
"the" implies uniqueness, but there is not a unique poset. "this" within the context gives uniqueness. In fact, I would change all of those "the" to "this".
</p>
TicketjmantysaloSun, 24 Apr 2016 04:05:42 GMT
https://trac.sagemath.org/ticket/19190#comment:12
https://trac.sagemath.org/ticket/19190#comment:12
<p>
Replying to <a class="ticket" href="https://trac.sagemath.org/ticket/19190#comment:11" title="Comment 11">tscrim</a>:
</p>
<blockquote class="citation">
<p>
"the" implies uniqueness, but there is not a unique poset. "this" within the context gives uniqueness. In fact, I would change all of those "the" to "this".
</p>
</blockquote>
<p>
Trying to understand... There is no direct translation for a/an/the in Finnish.
</p>
<p>
I have learnt that if I say "Travis, open the window", it means that I have one specific window in my mind and I suppose that you also know what window I mean. "Open a window" means that there are several to choose one, and I don't care which one you open.
</p>
<p>
In "Return the number of elements in the poset." I suppose that it is clear what poset we are referring to.
</p>
TickettscrimSun, 24 Apr 2016 16:34:26 GMT
https://trac.sagemath.org/ticket/19190#comment:13
https://trac.sagemath.org/ticket/19190#comment:13
<p>
Replying to <a class="ticket" href="https://trac.sagemath.org/ticket/19190#comment:12" title="Comment 12">jmantysalo</a>:
</p>
<blockquote class="citation">
<p>
Replying to <a class="ticket" href="https://trac.sagemath.org/ticket/19190#comment:11" title="Comment 11">tscrim</a>:
</p>
<blockquote class="citation">
<p>
"the" implies uniqueness, but there is not a unique poset. "this" within the context gives uniqueness. In fact, I would change all of those "the" to "this".
</p>
</blockquote>
<p>
Trying to understand... There is no direct translation for a/an/the in Finnish.
</p>
</blockquote>
<p>
I have absolutely zero understanding of Finnish (I don't think I've ever really encountered any before).
</p>
<blockquote class="citation">
<p>
I have learnt that if I say "Travis, open the window", it means that I have one specific window in my mind and I suppose that you also know what window I mean. "Open a window" means that there are several to choose one, and I don't care which one you open.
</p>
</blockquote>
<p>
Yes, provided there is only one window we are discussing.
</p>
<blockquote class="citation">
<p>
In "Return the number of elements in the poset." I suppose that it is clear what poset we are referring to.
</p>
</blockquote>
<p>
In a way, yes, but it is more precise to say "this poset" as there might be one more poset around (especially when there is another input of a poset).
</p>
Ticket