Opened 6 years ago

Closed 6 years ago

#19188 closed enhancement (fixed)

Japanese translations of tutorial and tour

Reported by: kcrisman Owned by:
Priority: major Milestone: sage-6.10
Component: translations Keywords:
Cc: kini Merged in:
Authors: Takeo Sakai Reviewers: Tom Roby, Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 9a20a1e (Commits, GitHub, GitLab) Commit: 9a20a1e9474f925a3406a434ee62541b3dd2df51
Dependencies: Stopgaps:

Status badges

Description

Attachments (5)

tutorial-jp.pdf (406.8 KB) - added by dimpase 6 years ago.
ja.tgz (132.9 KB) - added by tsak 6 years ago.
.rst files of the japanese translations for a_tour_of_sage & tutorial
tutorial-jp_ipa.pdf (810.2 KB) - added by tsak 6 years ago.
.pdf kanji font embedded
a_tour_of_sage_ipa.pdf (127.6 KB) - added by tsak 6 years ago.
.pdf kanji font embedded
builder-ja.patch (1.8 KB) - added by tsak 6 years ago.

Download all attachments as: .zip

Change History (50)

comment:1 Changed 6 years ago by tsak

  • Branch set to ja

Changed 6 years ago by dimpase

comment:2 follow-up: Changed 6 years ago by dimpase

how about the rst sources of the translation, can you at least upload them as attachments?

comment:3 Changed 6 years ago by dimpase

  • Cc kini added

Changed 6 years ago by tsak

.rst files of the japanese translations for a_tour_of_sage & tutorial

Changed 6 years ago by tsak

.pdf kanji font embedded

Changed 6 years ago by tsak

.pdf kanji font embedded

comment:4 in reply to: ↑ 2 Changed 6 years ago by tsak

Replying to dimpase:

how about the rst sources of the translation, can you at least upload them as attachments?

I have attached .tgz file of the .rst source... and the kanji-font embedded pdfs.

comment:5 Changed 6 years ago by tsak

  • Branch changed from ja to public/19188
  • Commit set to b6d469db899c3e017d0a5d58efb08e25c66d0dd8

Last 10 new commits:

5fa0fc4Minor modification on index.rst
a3ce89fMerge branch 'a_tour' into ja
fc5821bsin_plot.png included.
c067ca6Merge branch 'a_tour' into ja
40a4f8dex attribute of files deleted from ja-branch
6b7367cdelete x-attribute of files from tutorial-branch
3d70166deletes x-attribute of *.{py,rst} from a_tour branch
745c5eaMerge branches 'tutorial' and 'a_tour' into ja
650ccb6Some line-formatting.
b6d469dMerge branch 'ja' into t/19188/japanese_translations_of_tutorial_and_tour

comment:6 Changed 6 years ago by kcrisman

Just a note from my experience with trying to get the Chinese doc to be passed... the html will probably work fine with a more or less normal compilation, but getting some standard set of Japanese fonts to work on all platforms Sage builds on for pdflatex may be a more difficult task. (I hope I'm wrong.) But please make sure to try building the pdf doc on both Linux and Mac, at the very least, when this is reviewed.

comment:7 Changed 6 years ago by tsak

  • Status changed from new to needs_review

comment:8 Changed 6 years ago by tsak

  • Authors set to Takeo Sakai

comment:9 follow-up: Changed 6 years ago by dimpase

Is the directory prefix 'ja/' for Japanese translations normal? I had expected 'jp'.

comment:10 Changed 6 years ago by kcrisman

If that's the usual (e.g. like zh for Chinese, de for German) then please let's use the one that a standards organization suggests!

comment:11 in reply to: ↑ 9 Changed 6 years ago by tsak

Replying to dimpase:

Is the directory prefix 'ja/' for Japanese translations normal? I had expected 'jp'.

The 'ja' prefix is not my choice: Sphinx determines it through the language option 'ja'. See conf.py.

comment:12 follow-up: Changed 6 years ago by kcrisman

Ok, that seems reasonable, see the ISO standards.

comment:13 Changed 6 years ago by kini

dimpase: Thanks for CCing me. While it's true that I can read Japanese, I think ideally the review should be done by a native Japanese speaker, especially since I'm not very familiar with mathematical or computer-related terminology in Japanese. Hopefully someone more appropriate can step up to the plate :)

comment:14 Changed 6 years ago by chapoton

please convert to the new-style doc-test continuation ....: instead of ...

also the bot complains about

+! LaTeX Error: This file needs format `pLaTeX2e'
+               but this is `LaTeX2e'.
+
+See the LaTeX manual or LaTeX Companion for explanation.
+Type  H <return>  for immediate help.
+ ...                                              
+                                                  
+l.38 \NeedsTeXFormat{pLaTeX2e}
+                              
+? 
+! Emergency stop.
+ ...                                              
+                                                  
+l.38 \NeedsTeXFormat{pLaTeX2e}

EDIT: but my latex install is broken, so maybe this second point is not a real error

Last edited 6 years ago by chapoton (previous) (diff)

comment:15 Changed 6 years ago by git

  • Commit changed from b6d469db899c3e017d0a5d58efb08e25c66d0dd8 to 0317b5d101edb2bc20c6ea1b17ae51c7550e3133

Branch pushed to git repo; I updated commit sha1. New commits:

258f4f3trac #19188 fixing doctest continuation ....: ; plus a few doctests fixed
8d5defdtrac #19188 some more doctests fixed
0317b5dtrac #19188 fixing all doctests

comment:16 follow-up: Changed 6 years ago by git

  • Commit changed from 0317b5d101edb2bc20c6ea1b17ae51c7550e3133 to f2a75adcd8d9bf5c9a9ff4bf512ce4faf48eb2e1

Branch pushed to git repo; I updated commit sha1. New commits:

f2a75adtrac #19188 fixing a few forgotten doctests

comment:17 in reply to: ↑ 16 Changed 6 years ago by tsak

Replying to git:

Branch pushed to git repo; I updated commit sha1. New commits:

f2a75adtrac #19188 fixing a few forgotten doctests

Thank you for your help. I have made some modifications with the four dots in the text. I would like to push them as soon as possible. (I'm a novice git/trac user and sorry to bother)

comment:18 in reply to: ↑ 12 Changed 6 years ago by tsak

Replying to kcrisman:

Ok, that seems reasonable, see the ISO standards.

If you say 'ok', I would like to keep the prefix to be 'ja'. I see one can feel uncomfortable with 'ja' not 'jp', I was at first. Thank you for your help.

comment:19 Changed 6 years ago by git

  • Commit changed from f2a75adcd8d9bf5c9a9ff4bf512ce4faf48eb2e1 to 8f9018f6f780dbdedd03dcd9bb9ae5af5d429693

Branch pushed to git repo; I updated commit sha1. New commits:

ce3d712Commit tour_assignment.rst(tutorial):
acca378Merge branch 'today' into ja
8f9018fCommit the modifications relating with the doctest line continuetion issue:

comment:20 Changed 6 years ago by git

  • Commit changed from 8f9018f6f780dbdedd03dcd9bb9ae5af5d429693 to 6eec443d7dc8e7cde8cdabc7e0b85cdb15ec8b84

Branch pushed to git repo; I updated commit sha1. New commits:

6eec443Commit a modification in tutorial/interactive_shell.rst

comment:21 Changed 6 years ago by git

  • Commit changed from 6eec443d7dc8e7cde8cdabc7e0b85cdb15ec8b84 to c82406924c97e4a7096db8b26e69b58eaf3ded43

Branch pushed to git repo; I updated commit sha1. New commits:

c824069A typo, and a misplaced space removed(interactive_shell.rst)

comment:22 Changed 6 years ago by git

  • Commit changed from c82406924c97e4a7096db8b26e69b58eaf3ded43 to f9c2cf07c33553cc7f4e513051b53faf461a4aee

Branch pushed to git repo; I updated commit sha1. New commits:

f9c2cf0Recovering a missing text line on the plotting capability.

comment:23 follow-up: Changed 6 years ago by troby

  • Status changed from needs_review to positive_review

I read through a few pages of the tutorial carefully and browsed the rest. Also sent it to a native speaker mathematician friend who said it looked good. This is not a careful line-by-line proofreading, of course, but it's not so easy to find someone with the time, interest, and expertise to do that. I believe it's ready for prime time, and I'm very glad someone had done this translation. --Tom Roby

comment:24 Changed 6 years ago by kcrisman

  • Reviewers set to Tom Roby

That sounds good. chapoton, agreed? Tom, if you want to change how your name is mentioned as reviewer, please just change it in that field, thank you so much!

comment:25 in reply to: ↑ 23 Changed 6 years ago by tsak

Thank you very much for having reviewed the translation with positive comments. I am most grateful to you for your kindness and your generosity with your time. Please pass my thanks to your Japanese friend. --Takeo Sakai

comment:26 Changed 6 years ago by vbraun

  • Status changed from positive_review to needs_work

Doctests fail

sage -t --long src/doc/ja/tutorial/latex.rst
**********************************************************************
File "src/doc/ja/tutorial/latex.rst", line 370, in doc.ja.tutorial.latex
Failed example:
    latex.extra_preamble() # システムで運用されているTeXの種類に依存
Expected:
    '\\usepackage{foo-bar-unchecked}\\usepackage{tikz}\n\\usepackage{tkz-graph}\n\\usepackage{tkz-berge}\n\\usetikzlibrary{arrows,shapes}'
Got:
    '\\usepackage{foo-bar-unchecked}'
**********************************************************************
1 item had failures:
   1 of  80 in doc.ja.tutorial.latex
    [69 tests, 1 failure, 1.60 s]

comment:27 Changed 6 years ago by vbraun

There is also a conflict with #18175, please merge the next beta

comment:28 Changed 6 years ago by git

  • Commit changed from f9c2cf07c33553cc7f4e513051b53faf461a4aee to 4b2f2bb78df9837b0a400f7b2dc38d4e1f3ad190

Branch pushed to git repo; I updated commit sha1. New commits:

4b2f2bbMaking latex.rst pass the doctest by:

comment:29 Changed 6 years ago by git

  • Commit changed from 4b2f2bb78df9837b0a400f7b2dc38d4e1f3ad190 to 519a75ed555ddc2bea1be0bec29f7ca75f8950dc

Branch pushed to git repo; I updated commit sha1. New commits:

519a75eRecovering mssing lines and the “random” comment keywords (programming.rst)

comment:30 Changed 6 years ago by tsak

Sorry to be ignorant about the meaning of "random" keyword for the doctest context. I have corrected/recovered the original word from the translated word/text. After the correction, I have tried the doctest by issuing command "sage -t --long /usr/local/sage/src/doc/ja/tutorial/*.rst", it seems ok.

comment:31 Changed 6 years ago by dimpase

  • Status changed from needs_work to needs_review

comment:32 follow-up: Changed 6 years ago by vbraun

One doctest in the tour_coercion.rst changed in the last beta (http://git.sagemath.org/sage.git/diff/src/doc/en/tutorial/tour_coercion.rst?id=9cd27e3f142ef1fed65306c4d3f55d86fa6806cb), this needs to be taken into account here.

comment:33 Changed 6 years ago by git

  • Commit changed from 519a75ed555ddc2bea1be0bec29f7ca75f8950dc to 7effc544d159a7249900499484a1d81244ddc364

Branch pushed to git repo; I updated commit sha1. New commits:

7effc54Updating doctest on the categories and correct a typo, both in tour_coercion.rst

comment:34 in reply to: ↑ 32 Changed 6 years ago by tsak

Replying to vbraun:

One doctest in the tour_coercion.rst changed in the last beta (http://git.sagemath.org/sage.git/diff/src/doc/en/tutorial/tour_coercion.rst?id=9cd27e3f142ef1fed65306c4d3f55d86fa6806cb), this needs to be taken into account here.

Thank you for the diff. I have included it into the tour_coercion.rst. Please do doctest it; the doctest failed with my sage-6.9.

comment:35 Changed 6 years ago by vbraun

  • Status changed from needs_review to positive_review

comment:36 follow-up: Changed 6 years ago by vbraun

  • Status changed from positive_review to needs_work

make doc-pdf from the Sage root fails with

! LaTeX Error: This file needs format `pLaTeX2e'
               but this is `LaTeX2e'.

This is because it, under the hood, runs make all-pdf in SAGE_ROOT/src/doc/output/latex/ja/a_tour_of_sage which runs pdflatex. Only the make all-pdf-ja target works.

The best fix would be to special-case the japanese docs in SAGE_ROOT/src/doc/common/builder.py to run the all-pdf-ja target.

Changed 6 years ago by tsak

comment:37 in reply to: ↑ 36 Changed 6 years ago by tsak

Following your suggestion, I have modified the pdf(...) function in the builder.py so that it recognizes the 'ja' language option to run “make all-pdf-ja” instead of “... all-pdf”. It is rough and ready, but it works with “make doc-pdf” and in the context of “sage –docbuild...”. I have made a patch file for builder.py of sage-6.9. The name is builder-ja.patch. Please look at it.

comment:38 Changed 6 years ago by git

  • Commit changed from 7effc544d159a7249900499484a1d81244ddc364 to 17f8167d89590a5b98febc5962ad1ea532656409

Branch pushed to git repo; I updated commit sha1. New commits:

17f8167Merge branch 'public/19188' of trac.sagemath.org:sage into public/19188

comment:39 Changed 6 years ago by git

  • Commit changed from 17f8167d89590a5b98febc5962ad1ea532656409 to 75a48608242e992a5c00a633dde7c421e7e9b12d

Branch pushed to git repo; I updated commit sha1. New commits:

75a4860Add special case for ja docs in pdf builder.

comment:40 Changed 6 years ago by tscrim

  • Branch changed from public/19188 to public/19188-II
  • Commit changed from 75a48608242e992a5c00a633dde7c421e7e9b12d to 019ac7badbabf9f1881bd84588673414940a006f
  • Milestone changed from sage-6.9 to sage-6.10
  • Reviewers changed from Tom Roby to Tom Roby, Travis Scrimshaw
  • Status changed from needs_work to needs_review

I've converted this into the git branch and did some changes to the patch provided. The branch I have just attached contains an alternative proposal which I think is a little cleaner in its approach. Please check.


New commits:

019ac7bAn alternative proposal for #19188 not using replace.

comment:41 Changed 6 years ago by vbraun

  • Status changed from needs_review to positive_review

comment:42 Changed 6 years ago by vbraun

  • Status changed from positive_review to needs_work

The # random annotation shouldn't be translated, the doctest framework uses it and treats the doctest specially:

sage -t --long src/doc/ja/tutorial/programming.rst
**********************************************************************
File "src/doc/ja/tutorial/programming.rst", line 641, in doc.ja.tutorial.programming
Failed example:
    5 < VectorSpace(QQ,3)   # 出力は一定しない。
Expected:
    False
Got:
    True
**********************************************************************
1 item had failures:
   1 of 146 in doc.ja.tutorial.programming
    [116 tests, 1 failure, 0.34 s]

comment:43 Changed 6 years ago by git

  • Commit changed from 019ac7badbabf9f1881bd84588673414940a006f to 9a20a1e9474f925a3406a434ee62541b3dd2df51

Branch pushed to git repo; I updated commit sha1. New commits:

9a20a1eAdding random marker in ascii.

comment:44 Changed 6 years ago by tscrim

  • Status changed from needs_work to positive_review

comment:45 Changed 6 years ago by vbraun

  • Branch changed from public/19188-II to 9a20a1e9474f925a3406a434ee62541b3dd2df51
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.