#19186 closed defect (duplicate)
Unicode use in HTML rich output
| Reported by: | novoselt | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | sage-duplicate/invalid/wontfix |
| Component: | interfaces | Keywords: | unicode |
| Cc: | vbraun, jdemeyer | Merged in: | |
| Authors: | Reviewers: | ||
| Report Upstream: | N/A | Work issues: | |
| Branch: | public/19186 (Commits, GitHub, GitLab) | Commit: | a3688437f78436dcd24360a193e6fb2a6ce89e6e |
| Dependencies: | Stopgaps: |
Status badges
Description
I'm pretty sure it should be get_unicode, not get here:
https://github.com/sagemath/sage/blob/6.9.beta6/src/sage/repl/rich_output/backend_ipython.py#L518
And while we are at it - how Unicode should be handled for HTML, i.e. should it be rich_output.html.get_unicode() for consistency?
Change History (14)
comment:1 Changed 4 years ago by
- Keywords unicode added
comment:2 Changed 4 years ago by
- Branch set to public/19186
- Commit set to a3688437f78436dcd24360a193e6fb2a6ce89e6e
comment:3 Changed 4 years ago by
- Milestone changed from sage-6.9 to sage-8.0
comment:4 Changed 4 years ago by
- Status changed from new to needs_review
comment:5 Changed 4 years ago by
Do you know by any chance what behaviour is affected by this change?
comment:6 Changed 4 years ago by
- Cc jdemeyer added
comment:7 Changed 4 years ago by
bot is morally green
comment:8 Changed 4 years ago by
ping ?
comment:9 Changed 4 years ago by
Ping indeed: what behaviour is affected by this change? I suspect that we just don't have tests where unicode or not matters. Also, should it be get_unicode for html as mentioned in the description?
comment:10 Changed 4 years ago by
Right, how are we supposed to test this? Something like
s = u"á" html(s)
raises an error with or without this branch.
comment:11 Changed 3 years ago by
- Milestone changed from sage-8.0 to sage-8.5
So, should we do this or not ?
comment:12 Changed 3 years ago by
I think there is some clean up to be done, more than the attached branch, but I don't understand what's going on well enough to do it properly. Presumably switching to Python 3 can make some difference and expose bugs if there are indeed any.
comment:13 Changed 2 years ago by
- Resolution set to duplicate
- Status changed from needs_review to closed
done instead in #27656...
comment:14 Changed 14 months ago by
- Milestone changed from sage-8.5 to sage-duplicate/invalid/wontfix
New commits:
trac 19186 get >>> get_unicode in html rich output