Opened 4 years ago

Closed 6 months ago

#19186 closed defect (duplicate)

Unicode use in HTML rich output

Reported by: novoselt Owned by:
Priority: major Milestone: sage-8.5
Component: interfaces Keywords: unicode
Cc: vbraun, jdemeyer Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: public/19186 (Commits) Commit: a3688437f78436dcd24360a193e6fb2a6ce89e6e
Dependencies: Stopgaps:

Description

I'm pretty sure it should be get_unicode, not get here: โ€‹https://github.com/sagemath/sage/blob/6.9.beta6/src/sage/repl/rich_output/backend_ipython.py#L518

And while we are at it - how Unicode should be handled for HTML, i.e. should it be rich_output.html.get_unicode() for consistency?

Change History (13)

comment:1 Changed 3 years ago by chapoton

  • Keywords unicode added

comment:2 Changed 2 years ago by chapoton

  • Branch set to public/19186
  • Commit set to a3688437f78436dcd24360a193e6fb2a6ce89e6e

New commits:

โ€‹a368843trac 19186 get >>> get_unicode in html rich output

comment:3 Changed 2 years ago by chapoton

  • Milestone changed from sage-6.9 to sage-8.0

comment:4 Changed 2 years ago by chapoton

  • Status changed from new to needs_review

comment:5 Changed 2 years ago by novoselt

Do you know by any chance what behaviour is affected by this change?

comment:6 Changed 2 years ago by chapoton

  • Cc jdemeyer added

comment:7 Changed 2 years ago by chapoton

bot is morally green

comment:8 Changed 2 years ago by chapoton

ping ?

comment:9 Changed 2 years ago by novoselt

Ping indeed: what behaviour is affected by this change? I suspect that we just don't have tests where unicode or not matters. Also, should it be get_unicode for html as mentioned in the description?

comment:10 Changed 2 years ago by jhpalmieri

Right, how are we supposed to test this? Something like

s = u"รก"
html(s)

raises an error with or without this branch.

comment:11 Changed 12 months ago by chapoton

  • Milestone changed from sage-8.0 to sage-8.5

So, should we do this or not ?

comment:12 Changed 12 months ago by novoselt

I think there is some clean up to be done, more than the attached branch, but I don't understand what's going on well enough to do it properly. Presumably switching to Python 3 can make some difference and expose bugs if there are indeed any.

comment:13 Changed 6 months ago by chapoton

  • Resolution set to duplicate
  • Status changed from needs_review to closed

done instead in #27656...

Note: See TracTickets for help on using tickets.