Opened 6 years ago
Closed 6 years ago
#19185 closed defect (fixed)
Avoid a %crun crash
Reported by:  ncohen  Owned by:  

Priority:  major  Milestone:  sage6.9 
Component:  performance  Keywords:  
Cc:  vbraun, SimonKing  Merged in:  
Authors:  Nathann Cohen  Reviewers:  Frédéric Chapoton 
Report Upstream:  N/A  Work issues:  
Branch:  28dd224 (Commits, GitHub, GitLab)  Commit:  28dd224d0a2f82bae3da4e455bbc921268b8174c 
Dependencies:  Stopgaps: 
Description
When typing several times in a row the following command (which is indeed incorrect)
sage: %crun s cumulative 1+1
Sage ends up crashing. That's apparently because the timer is started but not stopped (because of the exception).
This very small branch fixes the problem, and may possibly also fix the other occurrences of a crash due to this function. It happens from time to time on my computer, though the previous example at least is deterministic.
I do not know how exactly I should doctest it, though.
Change History (8)
comment:1 Changed 6 years ago by
 Branch set to public/19185
 Commit set to 94437a9daebb6b3df9574595038efc07859c93ce
 Status changed from new to needs_review
comment:2 Changed 6 years ago by
 Commit changed from 94437a9daebb6b3df9574595038efc07859c93ce to 28dd224d0a2f82bae3da4e455bbc921268b8174c
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
28dd224  trac #19185: Avoid a %crun crash

comment:3 Changed 6 years ago by
 Status changed from needs_review to positive_review
ok, bot is happy and this looks good enough
comment:4 Changed 6 years ago by
Thanks!
comment:5 Changed 6 years ago by
 Status changed from positive_review to needs_work
Reviewer name missing
comment:6 Changed 6 years ago by
 Reviewers set to Frédéric Chapoton
comment:7 Changed 6 years ago by
 Status changed from needs_work to positive_review
comment:8 Changed 6 years ago by
 Branch changed from public/19185 to 28dd224d0a2f82bae3da4e455bbc921268b8174c
 Resolution set to fixed
 Status changed from positive_review to closed
New commits:
trac #19133: Three Wittbased strongly regular graphs
trac #19133: Merged with 6.9.beta5
trac #19133: Broken doctests
trac #19180: A (220,84,38,28)strongly regular graph
trac #19185: Avoid a %crun crash