Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#19176 closed enhancement (fixed)

Make LiE a new-style spkg

Reported by: tscrim Owned by: tscrim
Priority: major Milestone: sage-6.9
Component: packages: optional Keywords:
Cc: vbraun, jdemeyer, jhpalmieri Merged in:
Authors: Travis Scrimshaw Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: b549677 (Commits, GitHub, GitLab) Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

Convert LiE over to a new-style spkg.

Tarball here (just a renamed version of the compile only version on the homepage).

Attachments (1)

lie-2.2.2.tar.gz (352.6 KB) - added by tscrim 6 years ago.
Renamed tarball of upstream

Download all attachments as: .zip

Change History (34)

Changed 6 years ago by tscrim

Renamed tarball of upstream

comment:1 Changed 6 years ago by tscrim

  • Authors set to Travis Scrimshaw
  • Branch set to u/tscrim/lie_new_style_spkg-19176
  • Cc vbraun jdemeyer jhpalmieri added
  • Commit set to 3e833f687ae881ee70f193cc1bbbe5a6e2911e41
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

3e833f6Making LiE an optional spkg.

comment:2 Changed 6 years ago by git

  • Commit changed from 3e833f687ae881ee70f193cc1bbbe5a6e2911e41 to a5d33184ca07794da9b39463ae85004bef272565

Branch pushed to git repo; I updated commit sha1. New commits:

a5d3318Revert change to GAP3 checksum.

comment:3 Changed 6 years ago by jdemeyer

This clearly should be removed:

== SPKG Maintainer ==

 * William Stein (?)
 * Michael Abshoff (?)

Similar to #19177, it's recommended to add a dependencies file.

comment:4 Changed 6 years ago by chapoton

  • Description modified (diff)

comment:5 Changed 6 years ago by git

  • Commit changed from a5d33184ca07794da9b39463ae85004bef272565 to 29b768be0e68e4cadc95bc629fe3ca2b28b66306

Branch pushed to git repo; I updated commit sha1. New commits:

cc194faMake cluster_seed-1.0 into database_mutation_class-1.0.
29b768bTweaks from Jeroen's comments.

comment:6 Changed 6 years ago by git

  • Commit changed from 29b768be0e68e4cadc95bc629fe3ca2b28b66306 to ac4c6be3bf3dc8b55e858cb3c312d612da55d9f5

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

ac4c6beTweaks from Jeroen's comments.

comment:7 Changed 6 years ago by tscrim

Whoops, don't know how cc194fa got in there.

Fixed.

comment:8 Changed 6 years ago by jdemeyer

  • Status changed from needs_review to needs_work

Is the package called lie or conlie? You should be consistent...

comment:9 Changed 6 years ago by jdemeyer

  • Description modified (diff)
  • Status changed from needs_work to needs_review

Sorry, too fast.

comment:10 follow-up: Changed 6 years ago by tscrim

The package is called LiE. The upstream tarball is the only thing that is called conlie AFAIK.

comment:11 Changed 6 years ago by jdemeyer

The package installs fine.

comment:12 in reply to: ↑ 10 Changed 6 years ago by jdemeyer

Replying to tscrim:

The package is called LiE. The upstream tarball is the only thing that is called conlie AFAIK.

Got it, it was just confusing with the links in the description.

comment:13 Changed 6 years ago by jdemeyer

  • Status changed from needs_review to needs_work
sage -t --long src/sage/interfaces/lie.py
**********************************************************************
File "src/sage/interfaces/lie.py", line 573, in sage.interfaces.lie.LiE.version
Failed example:
    lie.version() # optional - lie
Exception raised:
    Traceback (most recent call last):
      File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 496, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 858, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.interfaces.lie.LiE.version[0]>", line 1, in <module>
        lie.version() # optional - lie
      File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/sage/interfaces/lie.py", line 576, in version
        return lie_version()
      File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/sage/interfaces/lie.py", line 932, in lie_version
        f = open(SAGE_LOCAL + 'lib/LiE/INFO.0')
    IOError: [Errno 2] No such file or directory: '/usr/local/src/sage-config/locallib/LiE/INFO.0'
**********************************************************************
File "src/sage/interfaces/lie.py", line 929, in sage.interfaces.lie.lie_version
Failed example:
    lie_version() # optional - lie
Exception raised:
    Traceback (most recent call last):
      File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 496, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 858, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.interfaces.lie.lie_version[1]>", line 1, in <module>
        lie_version() # optional - lie
      File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/sage/interfaces/lie.py", line 932, in lie_version
        f = open(SAGE_LOCAL + 'lib/LiE/INFO.0')
    IOError: [Errno 2] No such file or directory: '/usr/local/src/sage-config/locallib/LiE/INFO.0'
**********************************************************************

comment:14 Changed 6 years ago by jdemeyer

A non-reproducible failure:

sage -t --long src/sage/interfaces/lie.py
**********************************************************************
File "src/sage/interfaces/lie.py", line 515, in sage.interfaces.lie.LiE.trait_names
Failed example:
    lie.trait_names() # optional - lie
Expected:
    ['Cartan_type',
     'cent_roots',
     ...
     'n_comp']
Got:
    ['history',
     'version',
[...snip...]

Sorting the list should solve this.

comment:15 Changed 6 years ago by git

  • Commit changed from ac4c6be3bf3dc8b55e858cb3c312d612da55d9f5 to 41370e65529c2fd63045374786afb993a707c262

Branch pushed to git repo; I updated commit sha1. New commits:

41370e6Fixing doctest failures for LiE spkg.

comment:16 Changed 6 years ago by tscrim

  • Status changed from needs_work to needs_review

Apparently SAGE_LOCAL previously had a trailing /, or this file was never really tested. Anyways, I added the / to the rest of the filepath. I also fixed the output of the one random failure.

comment:17 Changed 6 years ago by jhpalmieri

It would probably be better to use os.path.join.

comment:18 Changed 6 years ago by git

  • Commit changed from 41370e65529c2fd63045374786afb993a707c262 to 2df36fc4ab02435942549e23b7579c94023f7edf

Branch pushed to git repo; I updated commit sha1. New commits:

2df36fcChanging to use os.path.join.

comment:19 Changed 6 years ago by jdemeyer

  • Status changed from needs_review to needs_work

Also, I suggest to make lie.trait_names() itself sorted, instead of sorting in the doctest.

comment:20 Changed 6 years ago by jdemeyer

If you use os.path.join, it should be better be used as

os.path.join(SAGE_LOCAL, 'lib', 'LiE', 'INFO.0')

comment:21 Changed 6 years ago by git

  • Commit changed from 2df36fc4ab02435942549e23b7579c94023f7edf to 1f6966d027f8e1efab0030d94810ea1556570ce7

Branch pushed to git repo; I updated commit sha1. New commits:

1f6966dImplementing Jeroen's comments.

comment:22 Changed 6 years ago by tscrim

  • Status changed from needs_work to needs_review

comment:23 Changed 6 years ago by jdemeyer

  • Status changed from needs_review to needs_work

Despite the claim that the package has no dependencies, it seems to depend at least on readline and ncurses:

gcc -o Lie.exe lexer.o parser.o non-ANSI.o bigint.o binmat.o creatop.o gettype.o getvalue.o init.o learn.o main.o mem.o node.o onoff.o output.o poly.o sym.o print.o get
l.o date.o static/*.o box/*.o -lreadline -lncurses

comment:24 follow-up: Changed 6 years ago by tscrim

It also depends on bison, but that can be a system-wide installation (instead of the experimental spkg).

So what should I do at this point, just put readline and ncurses (and bison) in the dependency part of the SPKG.txt or do I need to add things to the dependencies file?

comment:25 in reply to: ↑ 24 Changed 6 years ago by jdemeyer

  • Reviewers set to Jeroen Demeyer

Replying to tscrim:

So what should I do at this point, just put readline and ncurses (and bison) in the dependency part of the SPKG.txt or do I need to add things to the dependencies file?

Both please.

The package installs and doctests pass, so for the rest it's good for me.

comment:26 Changed 6 years ago by git

  • Commit changed from 1f6966d027f8e1efab0030d94810ea1556570ce7 to dda134f3405ca5a5414225522479414de27edb84

Branch pushed to git repo; I updated commit sha1. New commits:

dda134fAdded dependencies for LiE.

comment:27 Changed 6 years ago by tscrim

  • Status changed from needs_work to needs_review

Done. Thanks for walking me though things.

comment:28 Changed 6 years ago by git

  • Commit changed from dda134f3405ca5a5414225522479414de27edb84 to b54967773573bc439b3a32d1b54c65fb8d34f1db

Branch pushed to git repo; I updated commit sha1. New commits:

b549677Making the dependencies file more standard.

comment:29 Changed 6 years ago by jdemeyer

Dependencies look good. I will do one final check with make distclean.

comment:30 Changed 6 years ago by jdemeyer

  • Status changed from needs_review to positive_review

comment:31 Changed 6 years ago by tscrim

Thanks again.

comment:32 Changed 6 years ago by vbraun

  • Branch changed from u/tscrim/lie_new_style_spkg-19176 to b54967773573bc439b3a32d1b54c65fb8d34f1db
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:33 Changed 6 years ago by jdemeyer

  • Commit b54967773573bc439b3a32d1b54c65fb8d34f1db deleted

Breakage: #19239

Note: See TracTickets for help on using tickets.