Make LiE a new-style spkg

[tscrim]

Convert LiE over to a new-style spkg.

Tarball here​ (just a renamed version of the ​compile only version on ​the homepage).

[tscrim]

Renamed tarball of upstream

[tscrim]

New commits:

​3e833f6

Making LiE an optional spkg.

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​a5d3318

Revert change to GAP3 checksum.

[jdemeyer]

This clearly should be removed:

== SPKG Maintainer ==

 * William Stein (?)
 * Michael Abshoff (?)

Similar to #19177, it's recommended to add a dependencies file.

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​cc194fa	Make cluster_seed-1.0 into database_mutation_class-1.0.
​29b768b	Tweaks from Jeroen's comments.

[git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​ac4c6be

Tweaks from Jeroen's comments.

[tscrim]

Whoops, don't know how cc194fa got in there.

Fixed.

[jdemeyer]

Is the package called lie or conlie? You should be consistent...

[jdemeyer]

Sorry, too fast.

[tscrim]

The package is called LiE. The upstream tarball is the only thing that is called conlie AFAIK.

[jdemeyer]

The package installs fine.

[jdemeyer]

Replying to tscrim:

The package is called LiE. The upstream tarball is the only thing that is called conlie AFAIK.

Got it, it was just confusing with the links in the description.

[jdemeyer]

sage -t --long src/sage/interfaces/lie.py
**********************************************************************
File "src/sage/interfaces/lie.py", line 573, in sage.interfaces.lie.LiE.version
Failed example:
    lie.version() # optional - lie
Exception raised:
    Traceback (most recent call last):
      File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 496, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 858, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.interfaces.lie.LiE.version[0]>", line 1, in <module>
        lie.version() # optional - lie
      File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/sage/interfaces/lie.py", line 576, in version
        return lie_version()
      File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/sage/interfaces/lie.py", line 932, in lie_version
        f = open(SAGE_LOCAL + 'lib/LiE/INFO.0')
    IOError: [Errno 2] No such file or directory: '/usr/local/src/sage-config/locallib/LiE/INFO.0'
**********************************************************************
File "src/sage/interfaces/lie.py", line 929, in sage.interfaces.lie.lie_version
Failed example:
    lie_version() # optional - lie
Exception raised:
    Traceback (most recent call last):
      File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 496, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 858, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.interfaces.lie.lie_version[1]>", line 1, in <module>
        lie_version() # optional - lie
      File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/sage/interfaces/lie.py", line 932, in lie_version
        f = open(SAGE_LOCAL + 'lib/LiE/INFO.0')
    IOError: [Errno 2] No such file or directory: '/usr/local/src/sage-config/locallib/LiE/INFO.0'
**********************************************************************

[jdemeyer]

A non-reproducible failure:

sage -t --long src/sage/interfaces/lie.py
**********************************************************************
File "src/sage/interfaces/lie.py", line 515, in sage.interfaces.lie.LiE.trait_names
Failed example:
    lie.trait_names() # optional - lie
Expected:
    ['Cartan_type',
     'cent_roots',
     ...
     'n_comp']
Got:
    ['history',
     'version',
[...snip...]

Sorting the list should solve this.

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​41370e6

Fixing doctest failures for LiE spkg.

[tscrim]

Apparently SAGE_LOCAL previously had a trailing /, or this file was never really tested. Anyways, I added the / to the rest of the filepath. I also fixed the output of the one random failure.

[jhpalmieri]

It would probably be better to use os.path.join.

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​2df36fc

Changing to use os.path.join.

[jdemeyer]

Also, I suggest to make lie.trait_names() itself sorted, instead of sorting in the doctest.

[jdemeyer]

If you use os.path.join, it should be better be used as

os.path.join(SAGE_LOCAL, 'lib', 'LiE', 'INFO.0')

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​1f6966d

Implementing Jeroen's comments.

[jdemeyer]

Despite the claim that the package has no dependencies, it seems to depend at least on readline and ncurses:

gcc -o Lie.exe lexer.o parser.o non-ANSI.o bigint.o binmat.o creatop.o gettype.o getvalue.o init.o learn.o main.o mem.o node.o onoff.o output.o poly.o sym.o print.o get
l.o date.o static/*.o box/*.o -lreadline -lncurses

[tscrim]

It also depends on bison, but that can be a system-wide installation (instead of the experimental spkg).

So what should I do at this point, just put readline and ncurses (and bison) in the dependency part of the SPKG.txt or do I need to add things to the dependencies file?

[jdemeyer]

Replying to tscrim:

So what should I do at this point, just put readline and ncurses (and bison) in the dependency part of the SPKG.txt or do I need to add things to the dependencies file?

Both please.

The package installs and doctests pass, so for the rest it's good for me.

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​dda134f

Added dependencies for LiE.

[tscrim]

Done. Thanks for walking me though things.

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​b549677

Making the dependencies file more standard.

[jdemeyer]

Dependencies look good. I will do one final check with make distclean.

[tscrim]

Thanks again.

[jdemeyer]

Breakage: #19239