Opened 7 years ago

Closed 7 years ago

#19175 closed enhancement (fixed)

Convert ore_algebra into a new-style package

Reported by: jhpalmieri Owned by:
Priority: major Milestone: sage-6.9
Component: packages: optional Keywords:
Cc: zieglerk, mkauers Merged in:
Authors: John Palmieri Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: d630905 (Commits, GitHub, GitLab) Commit: d63090541e55c6d8c12559aa95d3a9cad307aa56
Dependencies: Stopgaps:

GitHub link to the corresponding issue

Description

Change History (6)

comment:1 Changed 7 years ago by jhpalmieri

Cc: zieglerk mkauers added
Status: newneeds_review

comment:2 Changed 7 years ago by jhpalmieri

Branch: u/jhpalmieri/ore_algebra

comment:3 Changed 7 years ago by tscrim

Commit: d63090541e55c6d8c12559aa95d3a9cad307aa56
Component: PLEASE CHANGEpackages: optional
Type: PLEASE CHANGEenhancement

New commits:

d630905Make ore_algebra into a new-style spkg.

comment:4 Changed 7 years ago by tscrim

Reviewers: Travis Scrimshaw

LGTM. (Although at the end of the day we should just move this into the Sage code properly (mainly adding doctests) since all it consists of is just a bunch of python files for importing into Sage. However that's for later)

comment:5 Changed 7 years ago by tscrim

Status: needs_reviewpositive_review

Need to select positive review...

comment:6 Changed 7 years ago by vbraun

Branch: u/jhpalmieri/ore_algebrad63090541e55c6d8c12559aa95d3a9cad307aa56
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.