Opened 7 years ago

Closed 5 years ago

#19170 closed enhancement (wontfix)

Comparison modifications in algebras/

Reported by: Vincent Delecroix Owned by:
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: python3 Keywords:
Cc: Merged in:
Authors: Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: u/vdelecroix/19170 (Commits, GitHub, GitLab) Commit: 861cce24b8301821e3291ae53b22dccc094d9ebc
Dependencies: Stopgaps:

Status badges

Description

Modify some comparisons in sage.algebras to use the _cmp_ and _richcmp_ involving the coercion framework.

This ticket was initially part of #18305.

Change History (11)

comment:1 Changed 7 years ago by Vincent Delecroix

Branch: u/vdelecroix/19170
Commit: 861cce24b8301821e3291ae53b22dccc094d9ebc
Dependencies: #18305
Status: newneeds_review

New commits:

a9283cbTrac 18305: py_rich_to_bool(_sgn) and operators
e8b8182Trac 18305: _richcmp_ for indexed monoids and groups
950f3ecTrac 18305: _richcmp_ for Newton polygons
490de42Trac 18305: comments about Python comparisons
3f6ea84Trac 18305: rephrased sentence in doc
4949e17Trac 19170: use _cmp_ for ideals of finite dimensional algebras
861cce2Trac 19170: _richcmp_ for `finite dimensional algebra elements

comment:2 Changed 7 years ago by Kevin Dilks

Milestone: sage-6.9sage-6.10

Merge conflicts.

comment:3 Changed 6 years ago by Frédéric Chapoton

Status: needs_reviewneeds_work

does not apply

comment:4 Changed 5 years ago by Frédéric Chapoton

Component: coercionpython3
Milestone: sage-6.10sage-8.1

comment:5 Changed 5 years ago by Frédéric Chapoton

Dependencies: #18305

comment:6 Changed 5 years ago by Frédéric Chapoton

Status: needs_workneeds_info

This is probably obsolete.

comment:7 Changed 5 years ago by Frédéric Chapoton

Milestone: sage-8.1sage-duplicate/invalid/wontfix

comment:8 Changed 5 years ago by Frédéric Chapoton

Status: needs_infopositive_review

Ok, let us consider that this one also is way outdated.

comment:9 Changed 5 years ago by Travis Scrimshaw

Authors: Vincent Delecroix
Reviewers: Frédéric Chapoton

There is not a def __cmp__ in sage/algebras/ from grepping, so this has been taken care of.

comment:10 Changed 5 years ago by Frédéric Chapoton

Yes, I wonder by who. But there remains to handle comparison of "ideals" in rings. I will work on that once the current py3 tickets have been included in sage.

comment:11 Changed 5 years ago by Erik Bray

Resolution: wontfix
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.