Opened 7 years ago

Closed 7 years ago

#19164 closed defect (fixed)

Remove GAP3 package

Reported by: tscrim Owned by: sage-combinat
Priority: blocker Milestone: sage-6.9
Component: packages: optional Keywords: GAP3
Cc: sage-combinat, nthiery, saliola, stumpc5 Merged in:
Authors: Dima Pasechnik Reviewers: Travis Scrimshaw, Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: 35ee338 (Commits, GitHub, GitLab) Commit: 35ee33898aa47313deeb80fd844083816099377e
Dependencies: Stopgaps:

Status badges

Description (last modified by ncohen)

The GAP3 package (#8906) contains binaries instead of installing from source. This is not acceptable.

This branch reverts the merge of #8906, as it would have brought binary executables from an external source into Sage.

sage-devel thread: https://groups.google.com/d/topic/sage-devel/EhW0nKGoKHU/discussion

Change History (9)

comment:1 Changed 7 years ago by tscrim

  • Branch set to public/optional_spkg/fix_GAP3_checksum-19164
  • Commit set to 94fc48363bec98be049a80021d7f5f85e1641647
  • Status changed from new to needs_review

New commits:

94fc483Fix checksum for GAP3.

comment:2 Changed 7 years ago by dimpase

  • Status changed from needs_review to positive_review

LGTM

comment:3 Changed 7 years ago by dimpase

  • Status changed from positive_review to needs_work

Let us remove stuff from bin/ subdir while we're at it

comment:4 Changed 7 years ago by dimpase

Oh dear, this package distributes executables!!!

comment:5 Changed 7 years ago by vbraun

It should probably be "experimental", too

comment:6 Changed 7 years ago by dimpase

  • Branch changed from public/optional_spkg/fix_GAP3_checksum-19164 to public/removegap3
  • Commit changed from 94fc48363bec98be049a80021d7f5f85e1641647 to 35ee33898aa47313deeb80fd844083816099377e
  • Description modified (diff)
  • Reviewers set to Dima Pasechnik
  • Status changed from needs_work to needs_review

New commits:

35ee338Revert "Trac #8906: Optional package for gap3"

comment:7 Changed 7 years ago by jdemeyer

  • Authors changed from Travis Scrimshaw to Dima Pasechnik
  • Description modified (diff)
  • Reviewers changed from Dima Pasechnik to Travis Scrimshaw, Jeroen Demeyer
  • Status changed from needs_review to positive_review
  • Summary changed from Update GAP3 checksum to Remove GAP3 package

comment:8 Changed 7 years ago by ncohen

  • Description modified (diff)

comment:9 Changed 7 years ago by vbraun

  • Branch changed from public/removegap3 to 35ee33898aa47313deeb80fd844083816099377e
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.