Opened 4 years ago

Closed 4 years ago

#19148 closed enhancement (fixed)

Get rid of signals.pxi

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-6.9
Component: cython Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Vincent Delecroix
Report Upstream: Fixed upstream, but not in a stable release. Work issues:
Branch: d1941b8 (Commits) Commit: d1941b893f8aade6fba7c3242f19914c019b5c7d
Dependencies: Stopgaps:

Description

As part of the process of cleaning up .pxi files, we should remove sage/ext/signals.pxi.

Upstream patch needed: ​https://github.com/cython/cython/pull/438

Change History (7)

comment:1 Changed 4 years ago by jdemeyer

  • Branch set to u/jdemeyer/get_rid_of_signals_pxi

comment:2 Changed 4 years ago by jdemeyer

  • Commit set to d1941b893f8aade6fba7c3242f19914c019b5c7d
  • Status changed from new to needs_review

New commits:

​d1941b8Get rid of signals.pxi

comment:3 follow-up: Changed 4 years ago by vdelecroix

  • Reviewers set to Vincent Delecroix
  • Status changed from needs_review to needs_info

Sometimes in the code we found 

from foo cimport bar
from foo import bar

or 

cimport foo
import foo

Do you know if there is (there was) a reason to do that? You removed one instance of that in sage.libs.ecl.

comment:4 in reply to: ↑ 3 Changed 4 years ago by jdemeyer

  • Status changed from needs_info to needs_review

Replying to vdelecroix:

Sometimes in the code we found 

from foo cimport bar
from foo import bar

or 

cimport foo
import foo

Do you know if there is (there was) a reason to do that?

Well, I assume there once was a reason to do that in earlier versions of Pyrex or Cython. However, I don't know of any reason to do it currently (except for numpy, the Cython interface doesn't cover everything).

comment:5 Changed 4 years ago by vdelecroix

  • Status changed from needs_review to positive_review

comment:6 Changed 4 years ago by jdemeyer

Thanks!

comment:7 Changed 4 years ago by vbraun

  • Branch changed from u/jdemeyer/get_rid_of_signals_pxi to d1941b893f8aade6fba7c3242f19914c019b5c7d
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.