Opened 7 years ago

Closed 7 years ago

#19132 closed defect (fixed)

Start a single process when running Sage

Reported by: Jeroen Demeyer Owned by:
Priority: major Milestone: sage-6.9
Component: interfaces Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: a281e34 (Commits, GitHub, GitLab) Commit: a281e344e30955987df1d696b25b18f452c5a218
Dependencies: Stopgaps:

Status badges

Description (last modified by Jeroen Demeyer)

Jupyter assumes that it is running a single process, otherwise interrupts get sent to the wrong process. With Sage, this assumption is currently not true due to the "front-end" $SAGE_ROOT/sage script. If we instead use exec there and apply #19135, this is no longer a problem and Sage Jupyter notebooks can be interrupted properly.

Change History (10)

comment:1 Changed 7 years ago by Jeroen Demeyer

Branch: → u/jdemeyer/fix_interrupts_in_jupyter

comment:2 Changed 7 years ago by Jeroen Demeyer

Commit: → af48d8b6c3c9f9e6de65628ff7fdd77ec89b2fb3
Description: modified (diff)
Report Upstream: N/A → Reported upstream. No feedback yet.

New commits:

​af48d8bFix interrupts in Jupyter

comment:3 Changed 7 years ago by Jeroen Demeyer

Status: new → needs_review

comment:4 Changed 7 years ago by Jeroen Demeyer

Description: modified (diff)
Report Upstream: Reported upstream. No feedback yet. → None of the above - read trac for reasoning.

comment:5 Changed 7 years ago by Jeroen Demeyer

Description: modified (diff)
Report Upstream: None of the above - read trac for reasoning. → N/A
Status: needs_review → needs_work
Summary: Fix interrupts in Jupyter → Start a single process when running Sage

comment:6 Changed 7 years ago by git

Commit: af48d8b6c3c9f9e6de65628ff7fdd77ec89b2fb3 → a281e344e30955987df1d696b25b18f452c5a218

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​a281e34Start a single process when running Sage

comment:7 Changed 7 years ago by Jeroen Demeyer

Description: modified (diff)
Status: needs_work → needs_review

comment:8 Changed 7 years ago by Jeroen Demeyer

Description: modified (diff)

comment:9 Changed 7 years ago by Travis Scrimshaw

Reviewers: → Travis Scrimshaw
Status: needs_review → positive_review

LGTM; we don't need the extra process from the shell running around.

comment:10 Changed 7 years ago by Volker Braun

Branch: u/jdemeyer/fix_interrupts_in_jupyter → a281e344e30955987df1d696b25b18f452c5a218
Resolution: → fixed
Status: positive_review → closed
Note: See TracTickets for help on using tickets.