Opened 6 years ago
Closed 6 years ago
#19132 closed defect (fixed)
Start a single process when running Sage
Reported by: | jdemeyer | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-6.9 |
Component: | interfaces | Keywords: | |
Cc: | Merged in: | ||
Authors: | Jeroen Demeyer | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | a281e34 (Commits, GitHub, GitLab) | Commit: | a281e344e30955987df1d696b25b18f452c5a218 |
Dependencies: | Stopgaps: |
Description (last modified by )
Jupyter assumes that it is running a single process, otherwise interrupts get sent to the wrong process. With Sage, this assumption is currently not true due to the "front-end" $SAGE_ROOT/sage
script. If we instead use exec
there and apply #19135, this is no longer a problem and Sage Jupyter notebooks can be interrupted properly.
Change History (10)
comment:1 Changed 6 years ago by
- Branch set to u/jdemeyer/fix_interrupts_in_jupyter
comment:2 Changed 6 years ago by
- Commit set to af48d8b6c3c9f9e6de65628ff7fdd77ec89b2fb3
- Description modified (diff)
- Report Upstream changed from N/A to Reported upstream. No feedback yet.
comment:3 Changed 6 years ago by
- Status changed from new to needs_review
comment:4 Changed 6 years ago by
- Description modified (diff)
- Report Upstream changed from Reported upstream. No feedback yet. to None of the above - read trac for reasoning.
comment:5 Changed 6 years ago by
- Description modified (diff)
- Report Upstream changed from None of the above - read trac for reasoning. to N/A
- Status changed from needs_review to needs_work
- Summary changed from Fix interrupts in Jupyter to Start a single process when running Sage
comment:6 Changed 6 years ago by
- Commit changed from af48d8b6c3c9f9e6de65628ff7fdd77ec89b2fb3 to a281e344e30955987df1d696b25b18f452c5a218
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
a281e34 | Start a single process when running Sage
|
comment:7 Changed 6 years ago by
- Description modified (diff)
- Status changed from needs_work to needs_review
comment:8 Changed 6 years ago by
- Description modified (diff)
comment:9 Changed 6 years ago by
- Reviewers set to Travis Scrimshaw
- Status changed from needs_review to positive_review
LGTM; we don't need the extra process from the shell running around.
comment:10 Changed 6 years ago by
- Branch changed from u/jdemeyer/fix_interrupts_in_jupyter to a281e344e30955987df1d696b25b18f452c5a218
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
Fix interrupts in Jupyter