Opened 5 years ago

Closed 5 years ago

#19128 closed enhancement (fixed)

Upgrade to IPython 4.0.0 + Jupyter

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-6.9
Component: packages: standard Keywords:
Cc: fbissey Merged in:
Authors: Jeroen Demeyer Reviewers: François Bissey, Volker Braun
Report Upstream: Fixed upstream, but not in a stable release. Work issues:
Branch: 06fd647 (Commits) Commit: 06fd647d7aaa0e80deef0611ce9e4c97a0c2f5b3
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

The old IPython package was split up in many packages and various dependencies were added. The IPython notebook is now called Jupyter.

Upstream packages:

Note: for path.py, we are intentionally not using the latest upstream version 8.1 since that is imcompatible with IPython 3.x. Instead, we use path.py 7.1 which is compatible with the old and new IPython/Jupyter.

Upstream patch included: https://github.com/ipython/ipykernel/pull/49

Change History (24)

comment:1 Changed 5 years ago by fbissey

  • Cc fbissey added

comment:2 Changed 5 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Description modified (diff)

comment:3 Changed 5 years ago by jdemeyer

  • Description modified (diff)

comment:4 Changed 5 years ago by jdemeyer

  • Description modified (diff)
  • Summary changed from Upgrade to IPython 4.0.0 to Upgrade to IPython 4.0.0 + Jupyter

comment:5 Changed 5 years ago by jdemeyer

  • Description modified (diff)

comment:6 Changed 5 years ago by jdemeyer

  • Description modified (diff)

comment:7 Changed 5 years ago by jdemeyer

  • Branch set to u/jdemeyer/upgrade_to_ipython_4_0_0

comment:8 Changed 5 years ago by jdemeyer

  • Commit set to 98c15faf597fef597573bca89975a7b3a67d45ae
  • Status changed from new to needs_review

New commits:

98c15faUpgrade to IPython 4.0.0 + Jupyter

comment:9 Changed 5 years ago by jdemeyer

  • Status changed from needs_review to needs_work

Sorry, too fast...

comment:10 Changed 5 years ago by git

  • Commit changed from 98c15faf597fef597573bca89975a7b3a67d45ae to e4748ba994f11059bb17c83d277b983eb7cdba6b

Branch pushed to git repo; I updated commit sha1. New commits:

e4748baFix import path

comment:11 Changed 5 years ago by jdemeyer

  • Status changed from needs_work to needs_review

comment:12 Changed 5 years ago by git

  • Commit changed from e4748ba994f11059bb17c83d277b983eb7cdba6b to 3f13fecf2b9f03d39852d041a53287529ee0005c

Branch pushed to git repo; I updated commit sha1. New commits:

3f13fecAdd ipython_genutils package

comment:13 Changed 5 years ago by jdemeyer

  • Description modified (diff)

comment:14 Changed 5 years ago by jdemeyer

  • Description modified (diff)
  • Status changed from needs_review to needs_work

comment:15 Changed 5 years ago by git

  • Commit changed from 3f13fecf2b9f03d39852d041a53287529ee0005c to 06fd647d7aaa0e80deef0611ce9e4c97a0c2f5b3

Branch pushed to git repo; I updated commit sha1. New commits:

06fd647Various fixes for Jupyter

comment:16 Changed 5 years ago by jdemeyer

  • Description modified (diff)
  • Report Upstream changed from N/A to Fixed upstream, but not in a stable release.

comment:17 Changed 5 years ago by jdemeyer

  • Status changed from needs_work to needs_review

comment:18 follow-up: Changed 5 years ago by fbissey

Could you explain the rational for path.py a little bit more clearly? Why do we need a version that is compatible with ipython-3.x?

comment:19 in reply to: ↑ 18 Changed 5 years ago by jdemeyer

Replying to fbissey:

Why do we need a version that is compatible with ipython-3.x?

Just to make Sage development easier. Imagine the following situation:

  • You test this ticket
  • You are done with reviewing this ticket, so you checkout some other branch
  • That branch has IPython 3.x
  • Sage breaks because path.py 8.1 is still installed

This actually happened to me. It's nothing serious, but it's at least annoying.

comment:20 follow-up: Changed 5 years ago by fbissey

It has some merit. For big review like this one I create a clone first and build it from scratch, no other branch present unless I test a follow up ticket. I probably should do a build of this on my mac.

comment:21 in reply to: ↑ 20 Changed 5 years ago by jdemeyer

Replying to fbissey:

For big review like this one I create a clone first and build it from scratch

I intentionally don't do this, just because it highlights issues like these.

comment:22 Changed 5 years ago by fbissey

All tests passed on OS X. Something odd that happened before (a long time ago) running the test with nohup just hung.

nohup ./sage -t --long --all &

it just sit idle on my mac. I have not tested on a linux machine yet.

comment:23 Changed 5 years ago by vbraun

  • Reviewers set to François Bissey, Volker Braun
  • Status changed from needs_review to positive_review

comment:24 Changed 5 years ago by vbraun

  • Branch changed from u/jdemeyer/upgrade_to_ipython_4_0_0 to 06fd647d7aaa0e80deef0611ce9e4c97a0c2f5b3
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.