Opened 6 years ago
Closed 6 years ago
#19128 closed enhancement (fixed)
Upgrade to IPython 4.0.0 + Jupyter
Reported by:  jdemeyer  Owned by:  

Priority:  major  Milestone:  sage6.9 
Component:  packages: standard  Keywords:  
Cc:  fbissey  Merged in:  
Authors:  Jeroen Demeyer  Reviewers:  François Bissey, Volker Braun 
Report Upstream:  Fixed upstream, but not in a stable release.  Work issues:  
Branch:  06fd647 (Commits, GitHub, GitLab)  Commit:  06fd647d7aaa0e80deef0611ce9e4c97a0c2f5b3 
Dependencies:  Stopgaps: 
Description (last modified by )
The old IPython package was split up in many packages and various dependencies were added. The IPython notebook is now called Jupyter.
Upstream packages:
 https://pypi.python.org/packages/source/i/ipython_genutils/ipython_genutils0.1.0.tar.gz
 https://pypi.python.org/packages/source/i/ipython/ipython4.0.0.tar.gz
 http://sage.ugent.be/www/jdemeyer/sage/pathpy7.1.tar.bz2
 http://sage.ugent.be/www/jdemeyer/sage/simplegeneric0.8.1.tar.bz2
 https://pypi.python.org/packages/source/p/pickleshare/pickleshare0.5.tar.gz
 https://pypi.python.org/packages/source/s/setuptools_scm/setuptools_scm1.7.0.tar.gz
 https://pypi.python.org/packages/source/t/traitlets/traitlets4.0.0.tar.gz
 https://pypi.python.org/packages/source/d/decorator/decorator4.0.2.tar.gz
 https://pypi.python.org/packages/source/n/notebook/notebook4.0.4.tar.gz
 https://pypi.python.org/packages/source/j/jupyter_client/jupyter_client4.0.0.tar.gz
 https://pypi.python.org/packages/source/j/jupyter_core/jupyter_core4.0.4.tar.gz
 https://pypi.python.org/packages/source/i/ipykernel/ipykernel4.0.3.tar.gz
 https://pypi.python.org/packages/source/i/ipywidgets/ipywidgets4.0.2.tar.gz
 https://pypi.python.org/packages/source/n/nbformat/nbformat4.0.0.tar.gz
 https://pypi.python.org/packages/source/n/nbconvert/nbconvert4.0.0.tar.gz
Note: for path.py
, we are intentionally not using the latest upstream version 8.1 since that is imcompatible with IPython 3.x. Instead, we use path.py
7.1 which is compatible with the old and new IPython/Jupyter.
Upstream patch included: https://github.com/ipython/ipykernel/pull/49
Change History (24)
comment:1 Changed 6 years ago by
 Cc fbissey added
comment:2 Changed 6 years ago by
 Description modified (diff)
comment:3 Changed 6 years ago by
 Description modified (diff)
comment:4 Changed 6 years ago by
 Description modified (diff)
 Summary changed from Upgrade to IPython 4.0.0 to Upgrade to IPython 4.0.0 + Jupyter
comment:5 Changed 6 years ago by
 Description modified (diff)
comment:6 Changed 6 years ago by
 Description modified (diff)
comment:7 Changed 6 years ago by
 Branch set to u/jdemeyer/upgrade_to_ipython_4_0_0
comment:8 Changed 6 years ago by
 Commit set to 98c15faf597fef597573bca89975a7b3a67d45ae
 Status changed from new to needs_review
comment:10 Changed 6 years ago by
 Commit changed from 98c15faf597fef597573bca89975a7b3a67d45ae to e4748ba994f11059bb17c83d277b983eb7cdba6b
Branch pushed to git repo; I updated commit sha1. New commits:
e4748ba  Fix import path

comment:11 Changed 6 years ago by
 Status changed from needs_work to needs_review
comment:12 Changed 6 years ago by
 Commit changed from e4748ba994f11059bb17c83d277b983eb7cdba6b to 3f13fecf2b9f03d39852d041a53287529ee0005c
Branch pushed to git repo; I updated commit sha1. New commits:
3f13fec  Add ipython_genutils package

comment:13 Changed 6 years ago by
 Description modified (diff)
comment:14 Changed 6 years ago by
 Description modified (diff)
 Status changed from needs_review to needs_work
comment:15 Changed 6 years ago by
 Commit changed from 3f13fecf2b9f03d39852d041a53287529ee0005c to 06fd647d7aaa0e80deef0611ce9e4c97a0c2f5b3
Branch pushed to git repo; I updated commit sha1. New commits:
06fd647  Various fixes for Jupyter

comment:16 Changed 6 years ago by
 Description modified (diff)
 Report Upstream changed from N/A to Fixed upstream, but not in a stable release.
comment:17 Changed 6 years ago by
 Status changed from needs_work to needs_review
comment:18 followup: ↓ 19 Changed 6 years ago by
Could you explain the rational for path.py
a little bit more clearly? Why do we need a version that is compatible with ipython3.x
?
comment:19 in reply to: ↑ 18 Changed 6 years ago by
Replying to fbissey:
Why do we need a version that is compatible with
ipython3.x
?
Just to make Sage development easier. Imagine the following situation:
 You test this ticket
 You are done with reviewing this ticket, so you checkout some other branch
 That branch has IPython 3.x
 Sage breaks because
path.py
8.1 is still installed
This actually happened to me. It's nothing serious, but it's at least annoying.
comment:20 followup: ↓ 21 Changed 6 years ago by
It has some merit. For big review like this one I create a clone first and build it from scratch, no other branch present unless I test a follow up ticket. I probably should do a build of this on my mac.
comment:21 in reply to: ↑ 20 Changed 6 years ago by
Replying to fbissey:
For big review like this one I create a clone first and build it from scratch
I intentionally don't do this, just because it highlights issues like these.
comment:22 Changed 6 years ago by
All tests passed on OS X. Something odd that happened before (a long time ago) running the test with nohup
just hung.
nohup ./sage t long all &
it just sit idle on my mac. I have not tested on a linux machine yet.
comment:23 Changed 6 years ago by
 Reviewers set to François Bissey, Volker Braun
 Status changed from needs_review to positive_review
comment:24 Changed 6 years ago by
 Branch changed from u/jdemeyer/upgrade_to_ipython_4_0_0 to 06fd647d7aaa0e80deef0611ce9e4c97a0c2f5b3
 Resolution set to fixed
 Status changed from positive_review to closed
New commits:
Upgrade to IPython 4.0.0 + Jupyter