Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#19101 closed enhancement (fixed)

Change sage -i to install with dependencies

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-6.9
Component: scripts Keywords:
Cc: rws, ncohen Merged in:
Authors: Jeroen Demeyer Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: e856a8e (Commits) Commit:
Dependencies: #19103, #19104 Stopgaps:

Description (last modified by jdemeyer)

  • Move the current functionality of sage -i to sage -p (without any functional changes).
  • Add a new implementation for sage -i which installs new-style packages with dependencies.
  • Make sage -f equivalent to sage -i -f, which installs dependencies and force-reinstalls a package.

For documentation changes, see #18859.

Change History (15)

comment:1 Changed 4 years ago by jdemeyer

  • Description modified (diff)

comment:2 Changed 4 years ago by jdemeyer

  • Description modified (diff)

comment:3 Changed 4 years ago by jdemeyer

  • Dependencies set to #19103

comment:4 Changed 4 years ago by jdemeyer

  • Dependencies changed from #19103 to #19103, #19104

comment:5 Changed 4 years ago by jdemeyer

  • Description modified (diff)

comment:6 Changed 4 years ago by jdemeyer

  • Branch set to u/jdemeyer/change_sage__i_to_install_with_dependencies

comment:7 Changed 4 years ago by jdemeyer

  • Commit set to e856a8e872282fe7f059900559f5e589f1b016aa
  • Status changed from new to needs_review

New commits:

31ff6e7Parse sage-spkg options in sage-spkg
cb05746Add sage --location option to run sage-location
e856a8eChange sage -i to install with dependencies

comment:8 Changed 4 years ago by vbraun

  • Reviewers set to Volker Braun
  • Status changed from needs_review to positive_review

comment:9 Changed 4 years ago by vbraun

  • Branch changed from u/jdemeyer/change_sage__i_to_install_with_dependencies to e856a8e872282fe7f059900559f5e589f1b016aa
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:10 Changed 4 years ago by vbraun

  • Branch changed from e856a8e872282fe7f059900559f5e589f1b016aa to u/jdemeyer/change_sage__i_to_install_with_dependencies
  • Resolution fixed deleted
  • Status changed from closed to new

Reopening because of #19104

comment:11 Changed 4 years ago by jdemeyer

  • Status changed from new to needs_review

comment:12 Changed 4 years ago by jdemeyer

  • Status changed from needs_review to positive_review

comment:13 Changed 4 years ago by vbraun

  • Branch changed from u/jdemeyer/change_sage__i_to_install_with_dependencies to e856a8e872282fe7f059900559f5e589f1b016aa
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:14 Changed 4 years ago by jhpalmieri

  • Commit e856a8e872282fe7f059900559f5e589f1b016aa deleted

The new doctest added in this ticket creates a log file logs/pkgs/sqlite.log. This means that it will fail if the user does not have the appropriate permissions in logs/pkgs/. This probably needs to be fixed.

comment:15 Changed 4 years ago by jdemeyer

It's really #19104, but I guess you're right.

Note: See TracTickets for help on using tickets.