Opened 3 years ago

Closed 3 years ago

#19099 closed enhancement (fixed)

Always check output in strongly_regular_graph

Reported by: ncohen Owned by:
Priority: major Milestone: sage-6.9
Component: graph theory Keywords:
Cc: dimpase Merged in:
Authors: Nathann Cohen Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: 56d98a3 (Commits) Commit: 56d98a309dcac30d183784ae7fb66bb39a1d29a1
Dependencies: Stopgaps:

Description

With this branch, the function strongly_regular_graph will not return any graph whose parameters have not been checked. As it is rather cheap to compute those parameters it should neve rbe a problem, and it can obviously be disabled whenever convenient.

Nathann

Change History (7)

comment:1 Changed 3 years ago by ncohen

  • Branch set to u/ncohen/19099
  • Status changed from new to needs_review

comment:2 Changed 3 years ago by git

  • Commit set to 56d98a309dcac30d183784ae7fb66bb39a1d29a1

Branch pushed to git repo; I updated commit sha1. New commits:

​56d98a3trac #19099: Always check output in strongly_regular_graph

comment:3 Changed 3 years ago by dimpase

  • Status changed from needs_review to positive_review

LGTM

comment:4 Changed 3 years ago by ncohen

Thanks !

comment:5 Changed 3 years ago by vbraun

  • Status changed from positive_review to needs_work

Reviewer name

comment:6 Changed 3 years ago by dimpase

  • Reviewers set to Dima Pasechnik
  • Status changed from needs_work to positive_review

comment:7 Changed 3 years ago by vbraun

  • Branch changed from u/ncohen/19099 to 56d98a309dcac30d183784ae7fb66bb39a1d29a1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.