Opened 3 years ago

Closed 3 years ago

#19096 closed defect (fixed)

Remove three class constructors from designs.<tab>

Reported by: ncohen Owned by:
Priority: major Milestone: sage-6.9
Component: combinatorial designs Keywords:
Cc: dimpase Merged in:
Authors: Nathann Cohen Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: d21a20d (Commits) Commit: d21a20de2f252408f4a6f9f2c34be8df70eaa47a
Dependencies: #18972 Stopgaps:

Description (last modified by ncohen)

As discussed on #18972, the following three entries should not be in designs.<tab>, which is for the moment meant to hold the constructors of our database of designs, i.e. OA, TD, t-designs, etc ...

designs.IncidenceStructure
designs.Hypergraph
designs.BlockDesign

While our policy may eventually change on this respect, this branch enforces what I believe is the current standard.

Nathann

Change History (9)

comment:1 Changed 3 years ago by ncohen

  • Branch set to public/19096
  • Commit set to 04200c4164cbcc59083037ef6e40c517835ae153
  • Description modified (diff)
  • Status changed from new to needs_review

Last 10 new commits:

3350efcinplace has arrived here too
4e077dbmaking internet and gap_packages tests optional
0d20a94inplace has arrived here too
7d15addtrac #18972: Speedup is_twograph
7a690detrac #18972: speedup Graph.twograph
4e3a0eaMerge branch 'public/18972' of git://trac.sagemath.org/sage into HEAD
95fe0f2Merge remote-tracking branch 'trac/public/18972' into seidelsw
25eec1buniformity, but no regularity
a729b27the reviwer has cooked and has eaten my brain (removed stuff from designs.*)
04200c4trac #19096: Remove three class constructors from designs.<tab>

comment:2 Changed 3 years ago by chapoton

  • Status changed from needs_review to needs_work

2 failing doctests

comment:3 Changed 3 years ago by git

  • Commit changed from 04200c4164cbcc59083037ef6e40c517835ae153 to d21a20de2f252408f4a6f9f2c34be8df70eaa47a

Branch pushed to git repo; I updated commit sha1. New commits:

d21a20dtrac #19096: Broken doctests

comment:4 Changed 3 years ago by ncohen

  • Status changed from needs_work to needs_review

comment:5 Changed 3 years ago by chapoton

  • Status changed from needs_review to positive_review

ok, looks good to me.

comment:6 Changed 3 years ago by ncohen

Thanks !

Nathann

comment:7 Changed 3 years ago by vbraun

  • Status changed from positive_review to needs_work

Reviewer name

comment:8 Changed 3 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_work to positive_review

comment:9 Changed 3 years ago by vbraun

  • Branch changed from public/19096 to d21a20de2f252408f4a6f9f2c34be8df70eaa47a
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.