Opened 4 years ago

Closed 4 years ago

#19079 closed defect (fixed)

ConstructionFunctor: remove __str__

Reported by: dkrenn Owned by:
Priority: major Milestone: sage-6.9
Component: coercion Keywords:
Cc: Merged in:
Authors: Daniel Krenn Reviewers: Marc Mezzarobba
Report Upstream: N/A Work issues:
Branch: bc2f089 (Commits) Commit: bc2f089576a6aa4b16d53adb7a4518a08b4942d9
Dependencies: Stopgaps:

Description

sage.categories.pushout.ConstructionFunctor? still uses str and _repr_ calls this str. It should be the other way round as for SageObject?.

Change History (7)

comment:1 Changed 4 years ago by dkrenn

  • Branch set to u/dkrenn/functor-str-on-6.8

comment:2 Changed 4 years ago by git

  • Commit set to 6a6a40b0d1320952c5ee755ba8ad217efa8645f5

Branch pushed to git repo; I updated commit sha1. New commits:

19247a5fix derived classes
6a6a40bMerge remote-tracking branch 'origin/u/dkrenn/pushout/functor-str' into u/dkrenn/functor-str-on-6.8

comment:3 Changed 4 years ago by git

  • Commit changed from 6a6a40b0d1320952c5ee755ba8ad217efa8645f5 to bc2f089576a6aa4b16d53adb7a4518a08b4942d9

Branch pushed to git repo; I updated commit sha1. New commits:

dacbfcbmore replacements of __str__ by _repr_
bc2f089Merge remote-tracking branch 'origin/u/dkrenn/pushout/functor-str' into u/dkrenn/functor-str-on-6.8

comment:4 Changed 4 years ago by dkrenn

  • Status changed from new to needs_review

comment:5 Changed 4 years ago by mmezzarobba

  • Reviewers set to Marc Mezzarobba

Sounds reasonable. I kicked the patchbot as it says TestsFailed? with errors that look unrelated to your changes.

comment:6 Changed 4 years ago by mmezzarobba

  • Status changed from needs_review to positive_review

comment:7 Changed 4 years ago by vbraun

  • Branch changed from u/dkrenn/functor-str-on-6.8 to bc2f089576a6aa4b16d53adb7a4518a08b4942d9
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.