Changes between Version 4 and Version 20 of Ticket #19073

Timestamp:

Oct 4, 2015, 2:58:19 PM (7 years ago)

Author:

cheuberg

Comment:

I reviewed this ticket without reviewing its dependency #18182. I have added a few reviewer commits.

Here are some further comments.

1. growth_group.combine_exceptions: missing INPUT and OUTPUT blocks
2. Why is the default category now a monoid instead of a group?
3. GenericGrowthGroup._pushout_:
   • explain why there is no common canonical parent for objects with parents: Growth Group QQ^x and Growth Group x^QQ (commutativity of pushouts vs. non-commutativity of cartesian products of growth groups with the same generator?)
   • What is the role of the lines

             if isinstance(other, GenericGrowthGroup):
                 pass
     

4. growth_group_cartesian.merge_overlapping:
   • add more information to docstring: missing INPUT: and OUTPUT: blocks
   • find_mergedoverlapping_index: key is evaluated frequently
5. _convert_factors_: remove list in penultimate line of code.
6. TermWithCoefficientMonoid._element_constructor_: what is the point of catching and immediately re-raising an exception in

   try:
   	return self.element_class(self, data, coefficient)
   except:
   	raise
   

7. AsymptoticRing.__init__: why is an Asymptoticring now a poset?