Opened 6 years ago

Closed 6 years ago

#19071 closed enhancement (fixed)

Construct lattice polytope faces as polytopes

Reported by: novoselt Owned by:
Priority: major Milestone: sage-6.9
Component: geometry Keywords: toric
Cc: vbraun Merged in:
Authors: Andrey Novoseltsev Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: 6547b5b (Commits, GitHub, GitLab) Commit: 6547b5bda352f8f1f7e9d3011b41224d9fc76434
Dependencies: #19070 Stopgaps:

Status badges

Description (last modified by novoselt)

As opposed to a separate class with different methods. Advantages:

  • uniform behaviour with cones
  • all polytope methods are available to their faces as well
  • less dependence on a particular backend

Since there is now lattice_polytope.ambient() returning "the canonical" containing polytope, amibient_dim was renamed to lattice_dim to avoid confusion. Unfortunately, there is now less consistency in names with generic polyhedra (for which lattice_dim makes no sense), but they are very different anyway.

There is some performance penalty associated with the new way of constructing faces (#19077 improves things somewhat), but it is mostly due to constructing face lattice as a poset. So less speed, but more features. Plus "more speed" was available only through the use of batch methods that few people use/are aware of.

Change History (7)

comment:1 Changed 6 years ago by novoselt

  • Branch set to u/novoselt/19071

comment:2 Changed 6 years ago by git

  • Commit set to 9cee82bee9d44099987899dc7c3d2043a73e505b

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

9cee82bWIP

comment:3 Changed 6 years ago by git

  • Commit changed from 9cee82bee9d44099987899dc7c3d2043a73e505b to 6547b5bda352f8f1f7e9d3011b41224d9fc76434

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

6547b5bStop using deprecated methods in other modules.

comment:4 Changed 6 years ago by novoselt

  • Cc vbraun added
  • Description modified (diff)
  • Keywords toric added
  • Status changed from new to needs_review

comment:5 Changed 6 years ago by vbraun

  • Reviewers set to Volker Braun
  • Status changed from needs_review to positive_review

comment:6 Changed 6 years ago by novoselt

Thank you Volker!

comment:7 Changed 6 years ago by vbraun

  • Branch changed from u/novoselt/19071 to 6547b5bda352f8f1f7e9d3011b41224d9fc76434
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.