Opened 6 years ago

Closed 6 years ago

#19070 closed enhancement (fixed)

Remove deprecated stuff for lattice polytopes.

Reported by: novoselt Owned by:
Priority: major Milestone: sage-6.9
Component: geometry Keywords:
Cc: vbraun Merged in:
Authors: Andrey Novoseltsev Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: 8ba83c4 (Commits, GitHub, GitLab) Commit: 8ba83c4a80db37491dbfcc2d2b3985976184aaa9
Dependencies: Stopgaps:

Status badges

Description

Follow up to #15240.

Change History (7)

comment:1 Changed 6 years ago by novoselt

  • Branch set to u/novoselt/drop_pc_suffix

comment:2 Changed 6 years ago by novoselt

  • Authors set to Andrey Novoseltsev
  • Cc vbraun added
  • Commit set to 098b29b0611dfc3919b0af9adeb6e6d3c7eb8595
  • Status changed from new to needs_review

New commits:

098b29bDrop #15240 deprecations in lattice_polytope.

comment:3 Changed 6 years ago by chapoton

  • Status changed from needs_review to needs_work

one failing doctest, see patchbot report

comment:4 Changed 6 years ago by git

  • Commit changed from 098b29b0611dfc3919b0af9adeb6e6d3c7eb8595 to 8ba83c4a80db37491dbfcc2d2b3985976184aaa9

Branch pushed to git repo; I updated commit sha1. New commits:

8ba83c4Fix one more points_pc.

comment:5 Changed 6 years ago by novoselt

  • Status changed from needs_work to needs_review

Fixed!

comment:6 Changed 6 years ago by vbraun

  • Reviewers set to Volker Braun
  • Status changed from needs_review to positive_review

comment:7 Changed 6 years ago by vbraun

  • Branch changed from u/novoselt/drop_pc_suffix to 8ba83c4a80db37491dbfcc2d2b3985976184aaa9
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.