Opened 4 years ago
Closed 4 years ago
#19047 closed enhancement (fixed)
let QQ.some_elements return more than one element
Reported by:  dkrenn  Owned by:  

Priority:  major  Milestone:  sage6.9 
Component:  categories  Keywords:  
Cc:  Merged in:  
Authors:  Daniel Krenn  Reviewers:  Benjamin Hackl 
Report Upstream:  N/A  Work issues:  
Branch:  695f08d (Commits)  Commit:  695f08d2dd5d98589dfc10b3f2da89ce4e7dd908 
Dependencies:  Stopgaps: 
Description
This ticket is to write QQ.some_elements
, which should return an iterable of many. At the moment the standard implementation is used, which gives [QQ.an_element()]
.
(FYI: ZZ
already has an extended some_elements()
gotten from sage.sets.categories.EnumeratedSet
)
Change History (11)
comment:1 Changed 4 years ago by
 Summary changed from let QQ.some_elements more than one element to let QQ.some_elements return more than one element
comment:2 Changed 4 years ago by
 Branch set to u/dkrenn/rings/QQsomeelements
comment:3 Changed 4 years ago by
 Commit set to d65f0333bbb73b3fed0c1576c390747b2cc4148c
 Status changed from new to needs_review
comment:4 Changed 4 years ago by
 Commit changed from d65f0333bbb73b3fed0c1576c390747b2cc4148c to 9b6b1b7ddb9521a2feb664fc45113430031e87f6
Branch pushed to git repo; I updated commit sha1. New commits:
9b6b1b7  some more "Returns" > "Return"

comment:5 Changed 4 years ago by
I'd change the short description of your some_elements()
method to
Return some elements of `\QQ`.
(just for the sake of consistency; see, e.g. random_element
).
Other than that: LGTM, the documentation builds and I'm currently testing make ptestlong
.
comment:6 Changed 4 years ago by
 Commit changed from 9b6b1b7ddb9521a2feb664fc45113430031e87f6 to c9f731569fc58d0ea06ef97f9ffeda5cd5f6f847
Branch pushed to git repo; I updated commit sha1. New commits:
c9f7315  change docstring

comment:7 Changed 4 years ago by
 Commit changed from c9f731569fc58d0ea06ef97f9ffeda5cd5f6f847 to 695f08d2dd5d98589dfc10b3f2da89ce4e7dd908
Branch pushed to git repo; I updated commit sha1. New commits:
695f08d  replace "of" by "over" in docstring

comment:8 Changed 4 years ago by
 Status changed from needs_review to positive_review
Thanks! Also, passes make ptestlong
. Thus: positive_review
.
comment:9 Changed 4 years ago by
 Status changed from positive_review to needs_work
reviewer name missing
comment:10 Changed 4 years ago by
 Reviewers set to Benjamin Hackl
 Status changed from needs_work to positive_review
sorry  mea culpa; fixed.
comment:11 Changed 4 years ago by
 Branch changed from u/dkrenn/rings/QQsomeelements to 695f08d2dd5d98589dfc10b3f2da89ce4e7dd908
 Resolution set to fixed
 Status changed from positive_review to closed
New commits:
implement QQ.some_elements()
docstring oneliner: remove "s"