Opened 4 years ago

Closed 4 years ago

#19035 closed enhancement (fixed)

Improve assumption documentation and doctest recent improvements

Reported by: rws Owned by:
Priority: major Milestone: sage-6.10
Component: symbolics Keywords:
Cc: Merged in:
Authors: Ralf Stephan Reviewers: Vincent Delecroix
Report Upstream: N/A Work issues:
Branch: 3f00cf9 (Commits) Commit: 3f00cf951135867df76a55e81ad03269df826789
Dependencies: #19312 Stopgaps:

Description (last modified by rws)

With pynac-0.5 this will no longer give wrong results:

sage: assume(x,'integer')
sage: x.is_integer()
False

sage: assume(x>0)
sage: x.is_positive()
False

sage: f=function('f')(x)
sage: assume(f>0)
sage: f.is_positive()
False

Change History (10)

comment:1 Changed 4 years ago by rws

  • Branch set to u/rws/sync_elementary_assumptions_on_symbols_functions_with_pynac

comment:2 Changed 4 years ago by rws

  • Commit set to ee70688802c8569df0eeac1f85188f4c22db2d0a
  • Dependencies set to pynac-0.4.4

Example working with current Pynac master:

sage: assume(x>0)
sage: x.is_real()
True
sage: x.is_positive()
True
sage: forget(x>0)
sage: x.is_positive()
False
sage: x.is_real()
False
sage: assume(x,"real")
sage: x.is_real()
True
sage: x.is_positive()
False

New commits:

ee7068819035: sync elementary assumptions on symbols/functions with Pynac

comment:3 Changed 4 years ago by rws

  • Branch u/rws/sync_elementary_assumptions_on_symbols_functions_with_pynac deleted
  • Commit ee70688802c8569df0eeac1f85188f4c22db2d0a deleted
  • Dependencies changed from pynac-0.4.4 to #19312
  • Description modified (diff)
  • Milestone changed from sage-6.9 to sage-6.10
  • Summary changed from sync elementary assumptions on symbols/functions with Pynac to doctest syncing of elementary assumptions on symbols/functions with Pynac

comment:4 Changed 4 years ago by rws

  • Branch set to u/rws/doctest_syncing_of_elementary_assumptions_on_symbols_functions_with_pynac

comment:5 Changed 4 years ago by rws

  • Commit set to b198a3f0f2128016aefeb0134c61ee357a115bc9
  • Description modified (diff)
  • Status changed from new to needs_review
  • Summary changed from doctest syncing of elementary assumptions on symbols/functions with Pynac to Improve assumption documentation and doctest recent improvements
  • Type changed from defect to enhancement

New commits:

b198a3f19035: document syncing of generic assumptions on symbols/functions with Pynac

comment:6 Changed 4 years ago by vdelecroix

  • Reviewers set to Vincent Delecroix
  • Status changed from needs_review to needs_work

I guess :meth:`assume` should be :func:`assume`. And similarly :meth:`forget()`.

In the complex plain do you mean the complex plane?

comment:7 Changed 4 years ago by git

  • Commit changed from b198a3f0f2128016aefeb0134c61ee357a115bc9 to 3f00cf951135867df76a55e81ad03269df826789

Branch pushed to git repo; I updated commit sha1. New commits:

3f00cf9fix typos

comment:8 Changed 4 years ago by rws

  • Status changed from needs_work to needs_review

Valid complaint.

comment:9 Changed 4 years ago by vdelecroix

  • Status changed from needs_review to positive_review

comment:10 Changed 4 years ago by vbraun

  • Branch changed from u/rws/doctest_syncing_of_elementary_assumptions_on_symbols_functions_with_pynac to 3f00cf951135867df76a55e81ad03269df826789
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.