Opened 5 years ago
Closed 5 years ago
#19028 closed enhancement (fixed)
ExponentialGrowthGroup
Reported by:  behackl  Owned by:  

Priority:  major  Milestone:  sage6.9 
Component:  asymptotic expansions  Keywords:  asymptotics, gsoc15 
Cc:  dkrenn, cheuberg  Merged in:  
Authors:  Benjamin Hackl  Reviewers:  Daniel Krenn 
Report Upstream:  N/A  Work issues:  
Branch:  09221f0 (Commits)  Commit:  09221f0e4cffd3802ec574f84a846a399560badf 
Dependencies:  #18587  Stopgaps: 
Change History (20)
comment:1 Changed 5 years ago by
 Commit changed from 290ce06f47c508498e6493c857b52bd2e0baff58 to f7dd2b5934e696c8a07224c8642fd302aec19bb4
comment:2 Changed 5 years ago by
 Commit changed from f7dd2b5934e696c8a07224c8642fd302aec19bb4 to c6e49c19eef6bb2aaca17ff170d90b69475e10be
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
18a292a  docstrings of Variable and i small improvment on error output

f43d197  variable_names

316cac1  Merge branch 'u/dkrenn/asy/growthgroupcartesian' into asy/growthgroupcartesian and resolved some merge conflicts

20f1916  merge changes from asy/growthgroupcartesian into this branch and resolve merge conflicts

2a111cf  doctests fixed

1815847  two minor modifications of docstrings

6e33615  modify to to make things running...

62fc735  write docstings of cartesian factory

8b812e4  Merge branch 'u/dkrenn/asy/growthgroupcartesian' of git://trac.sagemath.org/sage into asy/growthgroupcartesian

c6e49c1  Merge branch 'asy/growthgroupcartesian' into asy/growthGroupexponential

comment:3 Changed 5 years ago by
 Branch changed from u/behackl/asy/growthGroupexponential to u/dkrenn/asy/growthGroupexponential
comment:4 Changed 5 years ago by
 Commit changed from c6e49c19eef6bb2aaca17ff170d90b69475e10be to 5acd44418d715b07de2c9a44ff54c71191a865ce
comment:5 Changed 5 years ago by
 Commit changed from 5acd44418d715b07de2c9a44ff54c71191a865ce to dca196c2e9e6d2767b55cbbb2819058b6427f03b
comment:6 Changed 5 years ago by
 Commit changed from dca196c2e9e6d2767b55cbbb2819058b6427f03b to 1428b6989f7b091753464374aea43406fc540f26
comment:7 Changed 5 years ago by
 Commit changed from 1428b6989f7b091753464374aea43406fc540f26 to 65faee543a33262fad19bc407e251d3fa1387387
comment:8 Changed 5 years ago by
 Reviewers set to Daniel Krenn
 Status changed from new to needs_review
Looks fine.
comment:9 Changed 5 years ago by
 Commit changed from 65faee543a33262fad19bc407e251d3fa1387387 to 96f71013edd2feb232516c7e2bfd0896f0985e8f
Branch pushed to git repo; I updated commit sha1. New commits:
3a05be7  Merge tag '6.9.beta5' into t/17600/asy/growthGroup

58f931d  add asymptotic_expansions index

9d6f2da  Merge branch 't/17600/asy/growthGroup' into t/18930/asy/growthGroupfactory

ca5da4a  Merge branch 't/18930/asy/growthGroupfactory' into t/18587/asy/growthgroupcartesian

ac80aeb  add growth_group_cartesian to index

96f7101  Merge branch 't/18587/asy/growthgroupcartesian' into t/19028/asy/growthGroupexponential

comment:10 Changed 5 years ago by
Merge in 6.9.beta5
comment:11 Changed 5 years ago by
 Component changed from symbolics to asymptotic expansions
comment:12 Changed 5 years ago by
 Branch changed from u/dkrenn/asy/growthGroupexponential to u/behackl/asy/growthGroupexponential
 Commit changed from 96f71013edd2feb232516c7e2bfd0896f0985e8f to c097434eae9f7e7ea129cca6fc9eaf6d64eafbc3
Merged positively reviewed dependencies.
Last 10 new commits:
65166c8  use relative paths for imports

8c8c1b5  fix doctest coverage

9c9604c  Merge branch 'u/behackl/asy/growthgroupcartesian' into u/behackl/asy/growthGroupexponential

65faee5  fix doctest coverage

ca5da4a  Merge branch 't/18930/asy/growthGroupfactory' into t/18587/asy/growthgroupcartesian

ac80aeb  add growth_group_cartesian to index

96f7101  Merge branch 't/18587/asy/growthgroupcartesian' into t/19028/asy/growthGroupexponential

55c78e2  Merge branch 'asy/growthGroupfactory' into asy/growthgroupcartesian

4a6174f  improved a short description

c097434  Merge branch 'asy/growthgroupcartesian' into asy/growthGroupexponential

comment:13 Changed 5 years ago by
 Status changed from needs_review to needs_work
Merge conflict since dependencies have changed.
comment:14 Changed 5 years ago by
 Commit changed from c097434eae9f7e7ea129cca6fc9eaf6d64eafbc3 to e56459a5a4027406d40e56428a6fb16b520e7f6b
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
f88d3ea  MonomialGrowthGroup._convert_: let SR parse string + take care of '1' (comment 6)

dea3c96  Trac #18587: additional doctest

6d3e4f4  Trac #18587: nicer output of one link target

66759bb  Revert "remove unreachable ValueError (comment 2)"

0642564  doctest added

7f209ea  improved error message (equal or disjoint var.)

65ce848  Merge branch 'asy/growthgroupcartesian' into asy/growthGroupexponential and resolve merge conflicts

bd93e37  fix doctests

7ec7e7d  fix indentation of one block

e56459a  : > ::

comment:15 Changed 5 years ago by
 Status changed from needs_work to needs_review
comment:16 Changed 5 years ago by
 Status changed from needs_review to positive_review
Everything looks fine (dependency is not yet positive, but this ticket is; see also cleanup ticket #19083).
comment:17 Changed 5 years ago by
 Branch changed from u/behackl/asy/growthGroupexponential to u/dkrenn/asy/growthGroupexponential
comment:18 Changed 5 years ago by
 Commit changed from e56459a5a4027406d40e56428a6fb16b520e7f6b to 09221f0e4cffd3802ec574f84a846a399560badf
Merged dependency #18587 (which is now positive); made very small changes in code....is now again a positive_review.
New commits:
70aa9c4  rename CartesianProductPosets to CartesianProductPoset

f21990d  codesimplify CartesianProduct assignment

8f9a619  add a doctest dealing with coercion while comparing

3b923b7  Merge branch 'u/dkrenn/cat/cartesianproductposets' of trac.sagemath.org:sage into t/18587/asy/growthgroupcartesian

74547e6  fix code after changes by previous merge

23c9a49  Merge branch 't/18587/asy/growthgroupcartesian' into t/19028/asy/growthGroupexponential

09221f0  fixup due to changes in #18587 (coming from #18223)

comment:19 Changed 5 years ago by
 Dependencies changed from #17600, #18930, #18587 to #18587
comment:20 Changed 5 years ago by
 Branch changed from u/dkrenn/asy/growthGroupexponential to 09221f0e4cffd3802ec574f84a846a399560badf
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
Merge branch 'asy/growthgroupcartesian' into asy/growthGroupexponential
doctest added
added more doctests (exp. growth group in cartesian products), improved
fixed an issue with conversion of log(var)
Merge branch 'asy/growthgroupcartesian' into asy/growthGroupexponential
error with the element constructor fixed, doctest added
Merge branch 'asy/growthGroup' into asy/growthGroupfactory
Merge branch 'asy/growthGroupfactory' into asy/growthgroupcartesian
element constructor of cartesian products simplified; helper method implemented
Merge branch 'asy/growthgroupcartesian' into asy/growthGroupexponential