Opened 4 years ago

Closed 4 years ago

#19028 closed enhancement (fixed)

ExponentialGrowthGroup

Reported by: behackl Owned by:
Priority: major Milestone: sage-6.9
Component: asymptotic expansions Keywords: asymptotics, gsoc15
Cc: dkrenn, cheuberg Merged in:
Authors: Benjamin Hackl Reviewers: Daniel Krenn
Report Upstream: N/A Work issues:
Branch: 09221f0 (Commits) Commit: 09221f0e4cffd3802ec574f84a846a399560badf
Dependencies: #18587 Stopgaps:

Description

On this ticket we implement another type of growth group (see #17600 or meta-ticket #17601): the exponential growth group.

The elements of this group represent expressions of the form basevariable.

Change History (20)

comment:1 Changed 4 years ago by git

  • Commit changed from 290ce06f47c508498e6493c857b52bd2e0baff58 to f7dd2b5934e696c8a07224c8642fd302aec19bb4

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

00c958bMerge branch 'asy/growth-group-cartesian' into asy/growthGroup-exponential
ea92f36doctest added
eac64d9added more doctests (exp. growth group in cartesian products), improved
f33ba27fixed an issue with conversion of log(var)
140895bMerge branch 'asy/growth-group-cartesian' into asy/growthGroup-exponential
c6d8584error with the element constructor fixed, doctest added
3564d23Merge branch 'asy/growthGroup' into asy/growthGroup-factory
dfbe937Merge branch 'asy/growthGroup-factory' into asy/growth-group-cartesian
8352429element constructor of cartesian products simplified; helper method implemented
f7dd2b5Merge branch 'asy/growth-group-cartesian' into asy/growthGroup-exponential

comment:2 Changed 4 years ago by git

  • Commit changed from f7dd2b5934e696c8a07224c8642fd302aec19bb4 to c6e49c19eef6bb2aaca17ff170d90b69475e10be

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

18a292adocstrings of Variable and i small improvment on error output
f43d197variable_names
316cac1Merge branch 'u/dkrenn/asy/growth-group-cartesian' into asy/growth-group-cartesian and resolved some merge conflicts
20f1916merge changes from asy/growth-group-cartesian into this branch and resolve merge conflicts
2a111cfdoctests fixed
1815847two minor modifications of docstrings
6e33615modify to to make things running...
62fc735write docstings of cartesian factory
8b812e4Merge branch 'u/dkrenn/asy/growth-group-cartesian' of git://trac.sagemath.org/sage into asy/growth-group-cartesian
c6e49c1Merge branch 'asy/growth-group-cartesian' into asy/growthGroup-exponential

comment:3 Changed 4 years ago by dkrenn

  • Branch changed from u/behackl/asy/growthGroup-exponential to u/dkrenn/asy/growthGroup-exponential

comment:4 Changed 4 years ago by git

  • Commit changed from c6e49c19eef6bb2aaca17ff170d90b69475e10be to 5acd44418d715b07de2c9a44ff54c71191a865ce

Branch pushed to git repo; I updated commit sha1. New commits:

d57e99bmove methods to GenericGrowthGroup
ac0083amerge parent methods of growth groups
383f713deal with categories: CartesianProductPosets should be in Posets()
febf372make everything work again
5acd444fix doctests

comment:5 Changed 4 years ago by git

  • Commit changed from 5acd44418d715b07de2c9a44ff54c71191a865ce to dca196c2e9e6d2767b55cbbb2819058b6427f03b

Branch pushed to git repo; I updated commit sha1. New commits:

9352031change one word in docstring
ef15d6cdeal with categories: CartesianProductPosets should be in Posets()
dca196cMerge branch 't/18223/cat/cartesian-product-posets' into u/behackl/asy/growthGroup-exponential

comment:6 Changed 4 years ago by git

  • Commit changed from dca196c2e9e6d2767b55cbbb2819058b6427f03b to 1428b6989f7b091753464374aea43406fc540f26

Branch pushed to git repo; I updated commit sha1. New commits:

7ce6c0bdeal with _repr_
1428b69post-class-merge doctest cleanup

comment:7 Changed 4 years ago by git

  • Commit changed from 1428b6989f7b091753464374aea43406fc540f26 to 65faee543a33262fad19bc407e251d3fa1387387

Branch pushed to git repo; I updated commit sha1. New commits:

65166c8use relative paths for imports
8c8c1b5fix doctest coverage
9c9604cMerge branch 'u/behackl/asy/growth-group-cartesian' into u/behackl/asy/growthGroup-exponential
65faee5fix doctest coverage

comment:8 Changed 4 years ago by dkrenn

  • Reviewers set to Daniel Krenn
  • Status changed from new to needs_review

Looks fine.

comment:9 Changed 4 years ago by git

  • Commit changed from 65faee543a33262fad19bc407e251d3fa1387387 to 96f71013edd2feb232516c7e2bfd0896f0985e8f

Branch pushed to git repo; I updated commit sha1. New commits:

3a05be7Merge tag '6.9.beta5' into t/17600/asy/growthGroup
58f931dadd asymptotic_expansions index
9d6f2daMerge branch 't/17600/asy/growthGroup' into t/18930/asy/growthGroup-factory
ca5da4aMerge branch 't/18930/asy/growthGroup-factory' into t/18587/asy/growth-group-cartesian
ac80aebadd growth_group_cartesian to index
96f7101Merge branch 't/18587/asy/growth-group-cartesian' into t/19028/asy/growthGroup-exponential

comment:10 Changed 4 years ago by dkrenn

Merge in 6.9.beta5

comment:11 Changed 4 years ago by dkrenn

  • Component changed from symbolics to asymptotic expansions

comment:12 Changed 4 years ago by behackl

  • Branch changed from u/dkrenn/asy/growthGroup-exponential to u/behackl/asy/growthGroup-exponential
  • Commit changed from 96f71013edd2feb232516c7e2bfd0896f0985e8f to c097434eae9f7e7ea129cca6fc9eaf6d64eafbc3

Merged positively reviewed dependencies.


Last 10 new commits:

65166c8use relative paths for imports
8c8c1b5fix doctest coverage
9c9604cMerge branch 'u/behackl/asy/growth-group-cartesian' into u/behackl/asy/growthGroup-exponential
65faee5fix doctest coverage
ca5da4aMerge branch 't/18930/asy/growthGroup-factory' into t/18587/asy/growth-group-cartesian
ac80aebadd growth_group_cartesian to index
96f7101Merge branch 't/18587/asy/growth-group-cartesian' into t/19028/asy/growthGroup-exponential
55c78e2Merge branch 'asy/growthGroup-factory' into asy/growth-group-cartesian
4a6174fimproved a short description
c097434Merge branch 'asy/growth-group-cartesian' into asy/growthGroup-exponential

comment:13 Changed 4 years ago by dkrenn

  • Status changed from needs_review to needs_work

Merge conflict since dependencies have changed.

comment:14 Changed 4 years ago by git

  • Commit changed from c097434eae9f7e7ea129cca6fc9eaf6d64eafbc3 to e56459a5a4027406d40e56428a6fb16b520e7f6b

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

f88d3eaMonomialGrowthGroup._convert_: let SR parse string + take care of '1' (comment 6)
dea3c96Trac #18587: additional doctest
6d3e4f4Trac #18587: nicer output of one link target
66759bbRevert "remove unreachable ValueError (comment 2)"
0642564doctest added
7f209eaimproved error message (equal or disjoint var.)
65ce848Merge branch 'asy/growth-group-cartesian' into asy/growthGroup-exponential and resolve merge conflicts
bd93e37fix doctests
7ec7e7dfix indentation of one block
e56459a: --> ::

comment:15 Changed 4 years ago by behackl

  • Status changed from needs_work to needs_review

comment:16 Changed 4 years ago by dkrenn

  • Status changed from needs_review to positive_review

Everything looks fine (dependency is not yet positive, but this ticket is; see also cleanup ticket #19083).

comment:17 Changed 4 years ago by dkrenn

  • Branch changed from u/behackl/asy/growthGroup-exponential to u/dkrenn/asy/growthGroup-exponential

comment:18 Changed 4 years ago by dkrenn

  • Commit changed from e56459a5a4027406d40e56428a6fb16b520e7f6b to 09221f0e4cffd3802ec574f84a846a399560badf

Merged dependency #18587 (which is now positive); made very small changes in code....is now again a positive_review.


New commits:

70aa9c4rename CartesianProductPosets to CartesianProductPoset
f21990dcode-simplify CartesianProduct assignment
8f9a619add a doctest dealing with coercion while comparing
3b923b7Merge branch 'u/dkrenn/cat/cartesian-product-posets' of trac.sagemath.org:sage into t/18587/asy/growth-group-cartesian
74547e6fix code after changes by previous merge
23c9a49Merge branch 't/18587/asy/growth-group-cartesian' into t/19028/asy/growthGroup-exponential
09221f0fixup due to changes in #18587 (coming from #18223)

comment:19 Changed 4 years ago by dkrenn

  • Dependencies changed from #17600, #18930, #18587 to #18587

comment:20 Changed 4 years ago by vbraun

  • Branch changed from u/dkrenn/asy/growthGroup-exponential to 09221f0e4cffd3802ec574f84a846a399560badf
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.