Opened 4 years ago

Closed 4 years ago

#19017 closed enhancement (fixed)

improving the big_oh interface + passing keywords

Reported by: behackl Owned by:
Priority: major Milestone: sage-6.9
Component: commutative algebra Keywords: gsoc15
Cc: dkrenn Merged in:
Authors: Benjamin Hackl, Daniel Krenn Reviewers: Benjamin Hackl, Daniel Krenn
Report Upstream: N/A Work issues:
Branch: d7b7d9e (Commits) Commit: d7b7d9ef50a46c49d2b3b3e45589685f4b6ec4ee
Dependencies: Stopgaps:

Description

In order to have an easy-to-use interface for constructing O-Terms (including objects that are not explicitly mentioned in big_oh.py, e.g. Asymptotic Expressions as implemented in #17716), this ticket implements the following:

If O(x) is called and cannot be constructed by the "old" implementation, the code also tries to call x.O().

Additionally, keywords can be passed to the actual constructor.

Finally, the code of the old implementation is slightly reformatted (to match PEP 8).

Change History (6)

comment:1 Changed 4 years ago by behackl

  • Status changed from new to needs_review
  • Summary changed from improving the big_oh interface to improving the big_oh interface + passing keywords

comment:2 Changed 4 years ago by behackl

  • Keywords gsoc15 added

comment:3 Changed 4 years ago by dkrenn

  • Branch changed from u/behackl/asy/big_oh to u/dkrenn/asy/big_oh

comment:4 Changed 4 years ago by dkrenn

  • Authors changed from Benjamin Hackl to Benjamin Hackl, Daniel Krenn
  • Commit changed from 3145afd634e3b8512090e2052af50a8cda16488c to d7b7d9ef50a46c49d2b3b3e45589685f4b6ec4ee
  • Reviewers set to Daniel Krenn

Patch looks fine.

I've added a small reviewer patch, which improves the error messages. Please do a cross-review and if satisfied set it to positive_review.

New commits:

​d7b7d9eimprove error message

comment:5 Changed 4 years ago by behackl

  • Reviewers changed from Daniel Krenn to Benjamin Hackl, Daniel Krenn
  • Status changed from needs_review to positive_review

LGTM. Also, passes make ptestlong => positive_review.

comment:6 Changed 4 years ago by vbraun

  • Branch changed from u/dkrenn/asy/big_oh to d7b7d9ef50a46c49d2b3b3e45589685f4b6ec4ee
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.