Opened 5 years ago

Closed 5 years ago

#18988 closed enhancement (fixed)

Orthogonal Polar graphs in strongly_regular_graph

Reported by: ncohen Owned by:
Priority: major Milestone: sage-6.9
Component: graph theory Keywords:
Cc: dimpase, vdelecroix Merged in:
Authors: Nathann Cohen Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: 4566752 (Commits) Commit: 45667527d6baa86a4eb07c52c6d1d7593dbb51a8
Dependencies: #18948, #18934, #18960 Stopgaps:

Description

As reported by Dima in #18948, a family was missing from the general constructor. This branch adds it.

Nathann

Change History (5)

comment:1 Changed 5 years ago by ncohen

  • Branch set to u/ncohen/18988
  • Commit set to 7fb7d790959135cb6b96a938a5eee33da3cff93c
  • Status changed from new to needs_review
  • Summary changed from Orthogonal Poar graphs in strongly_regular_graph to Orthogonal Polar graphs in strongly_regular_graph

Last 10 new commits:

​4f51703trac #18948: DOcstring
​a75774ftrac #18948: take into account the BIBD from #18934
​cf50d70trac #18948: Merged with 6.8
​6390dd9trac #18960: Strongly Regular Graphs from two-weight codes
​3eee1e7trac #18960: Merge 6.9.beta0
​606d15ftrac #18960: Adding nonzero somewhere
​83ed332trac #18960: Again...
​dc2d326trac #18960: Lint -> vLint
​6071efctrac #18960: Merge with updated #18948
​7fb7d79trac #18988: Orthogonal Polar graphs in strongly_regular_graph

comment:2 Changed 5 years ago by dimpase

  • Reviewers set to Dima Pasechnik
  • Status changed from needs_review to positive_review

LGTM

comment:3 Changed 5 years ago by git

  • Commit changed from 7fb7d790959135cb6b96a938a5eee33da3cff93c to 45667527d6baa86a4eb07c52c6d1d7593dbb51a8
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. Last 10 new commits:

​e46b058trac #18934: New (v,6,1)-BIBD with v=201
​a04a2fbtrac #18934: Broken doctests
​11e9f1ftrac #18934: Last one -> (126,6,1)-BIBD
​796bcdetrac #18934: Merged with 6.8.rc1
​6ed1abftrac #18934: Fixed credits
​62ce12ctrac #18934: Merged with beta0
​f4f5566trac #18948: Merge with updated #18934
​d1d25a0trac #18948: Broken doctest
​8b899abtrac #18960: Merged with updated #18948
​4566752trac #18988: Merged with updated #18960

comment:4 Changed 5 years ago by ncohen

  • Dependencies set to #18948, #18934, #18960
  • Status changed from needs_review to positive_review

comment:5 Changed 5 years ago by vbraun

  • Branch changed from u/ncohen/18988 to 45667527d6baa86a4eb07c52c6d1d7593dbb51a8
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.