Opened 4 years ago
Last modified 2 years ago
#18983 needs_work enhancement
Implementation of Lemke Howson
Reported by:  ptigwe  Owned by:  

Priority:  minor  Milestone:  sage7.5 
Component:  game theory  Keywords:  lemkehowson, game theory 
Cc:  dimpase, jcampbell, kcrisman, ncohen, vinceknight  Merged in:  
Authors:  Tobenna P. Igwe  Reviewers:  
Report Upstream:  N/A  Work issues:  
Branch:  u/ptigwe/lemke_howson (Commits)  Commit:  debb6510c30954d0198ab286d093611e15b898f7 
Dependencies:  Stopgaps: 
Description
This ticket addresses the implementation of the LemkeHowson (LH) algorithm and serves a sage alternative to the gambit implementation of the same algorithm (i.e. the 'LCP' solver).
Change History (12)
comment:1 Changed 4 years ago by
 Commit changed from 3a13899ab8cf4f93598f3e383ae5436f74281922 to 7d3426f40ffc7c27b86b3859fb89e1d41a667869
comment:2 Changed 4 years ago by
 Commit changed from 7d3426f40ffc7c27b86b3859fb89e1d41a667869 to 4c8df31b52d1d47f21043d93af3b59bc8ba487f9
Branch pushed to git repo; I updated commit sha1. New commits:
4c8df31  Updated docs

comment:3 Changed 4 years ago by
 Commit changed from 4c8df31b52d1d47f21043d93af3b59bc8ba487f9 to dd65c128a6beb6faf1217d85853787d53466dbc0
Branch pushed to git repo; I updated commit sha1. New commits:
dd65c12  Merge branch 'develop' into lemke_howson

comment:4 Changed 4 years ago by
 Status changed from new to needs_review
comment:5 followup: ↓ 7 Changed 3 years ago by
You need to add doctests to all the new functions: there are 2 functions missing doctests.
see patchbot report
+Decreased doctests in game_theory/normal_form_game.py: from 28 / 28 = 100% to 43 / 45 = 95% +Coverage went from 40228 / 42093 = 95.569% to 40243 / 42110 = 95.566% +==================== game_theory/normal_form_game.py: 100.0% (28 of 28) +game_theory/normal_form_game.py: 95.6% (43 of 45)
comment:6 Changed 3 years ago by
 Commit changed from dd65c128a6beb6faf1217d85853787d53466dbc0 to a223c8262a8fa83b1c8f6f2c88fa27d0b6496377
Branch pushed to git repo; I updated commit sha1. New commits:
a223c82  Updated the doctests

comment:7 in reply to: ↑ 5 Changed 3 years ago by
Thanks. I've updated the two referenced functions.
Replying to chapoton:
You need to add doctests to all the new functions: there are 2 functions missing doctests.
see patchbot report
+Decreased doctests in game_theory/normal_form_game.py: from 28 / 28 = 100% to 43 / 45 = 95% +Coverage went from 40228 / 42093 = 95.569% to 40243 / 42110 = 95.566% +==================== game_theory/normal_form_game.py: 100.0% (28 of 28) +game_theory/normal_form_game.py: 95.6% (43 of 45)
comment:8 Changed 3 years ago by
 Status changed from needs_review to needs_work
please use python3compatible syntax for print, namely print("stuff")
see patchbot report
comment:9 Changed 3 years ago by
 Commit changed from a223c8262a8fa83b1c8f6f2c88fa27d0b6496377 to debb6510c30954d0198ab286d093611e15b898f7
comment:10 Changed 3 years ago by
 Status changed from needs_work to needs_review
comment:11 Changed 3 years ago by
 Milestone changed from sage6.9 to sage7.5
Branch pushed to git repo; I updated commit sha1. New commits:
Updated docs
Updated docs
Removed debugging
Updated plot
Updated docs
Updated front matter and return results of lh
Minor typos
Merge branch 'lemke_howson' of github.com:theref/sagegametheory into lemke_howson