Opened 6 years ago

Closed 6 years ago

#18980 closed defect (fixed)

upgrade to Pynac-0.3.9.5

Reported by: rws Owned by:
Priority: major Milestone: sage-6.9
Component: packages: standard Keywords:
Cc: Merged in:
Authors: Ralf Stephan Reviewers: Vincent Delecroix
Report Upstream: N/A Work issues:
Branch: cf975f5 (Commits, GitHub, GitLab) Commit: cf975f5a9309d01544fe9605d5053b0c715d534e
Dependencies: Stopgaps:

Status badges

Description (last modified by rws)

The new version claims:

  • fix regression in arithmetic with positive characteristic ring elements (comment 17 of #18787)
  • fix performance issue with real/imag of powers (#18952)
  • more rational multiples of pi as argument to sin,cos,tan expanded (#18954)
  • fix dbgprinttree() of functions (#19194)
  • performance fixes

https://github.com/pynac/pynac/releases/download/pynac-0.3.9.5/pynac-0.3.9.5.tar.bz2

Change History (11)

comment:1 Changed 6 years ago by rws

  • Branch set to u/rws/upgrade_to_pynac_0_3_9_3

comment:2 Changed 6 years ago by rws

  • Authors set to Ralf Stephan
  • Commit set to e2cda8bf48e7beef7648d11ff423a114376f842e
  • Description modified (diff)
  • Status changed from new to needs_review
  • Type changed from enhancement to defect

New commits:

705277818979: avoid Maxima on creation of symbolic matrices
0aae07f18980: upgrade to Pynac-0.3.9.3
d03d84d18980: avoid proving of symbolic equality
95b4a3618980: raise exception with relations Pynac claims are undecidable; part of 17700
e2cda8b18980: fix doctests

comment:3 Changed 6 years ago by git

  • Commit changed from e2cda8bf48e7beef7648d11ff423a114376f842e to aeeddfef1362cdd72ba1a663cff21aceaf315b00

Branch pushed to git repo; I updated commit sha1. New commits:

df4bd8cMerge branch 'develop' into t/18980/upgrade_to_pynac_0_3_9_3
aeeddferecent 19026 made this change necessary

comment:4 Changed 6 years ago by git

  • Commit changed from aeeddfef1362cdd72ba1a663cff21aceaf315b00 to 06c9f882dc80b488adc04b4aa14d43473bce71a0

Branch pushed to git repo; I updated commit sha1. New commits:

06c9f8818980: revert previous commit, different solution needed

comment:5 Changed 6 years ago by rws

  • Dependencies set to #19040
  • Status changed from needs_review to needs_work

Actually it would be better to first implement #19040 somehow, even with suboptimal Pynac decision functionality, in order to have the right interface first---with all necessary changes to doctests.

EDIT: It might be even better to revert the logic changes and do a Pynac release without them, but plus some fixes and enhancements.

Last edited 6 years ago by rws (previous) (diff)

comment:6 Changed 6 years ago by rws

  • Description modified (diff)
  • Summary changed from upgrade to Pynac-0.3.9.3 to upgrade to Pynac-0.3.9.4

comment:7 Changed 6 years ago by rws

  • Branch changed from u/rws/upgrade_to_pynac_0_3_9_3 to u/rws/18980

comment:8 Changed 6 years ago by rws

  • Commit changed from 06c9f882dc80b488adc04b4aa14d43473bce71a0 to cf975f5a9309d01544fe9605d5053b0c715d534e
  • Dependencies #19040 deleted
  • Description modified (diff)
  • Status changed from needs_work to needs_review
  • Summary changed from upgrade to Pynac-0.3.9.4 to upgrade to Pynac-0.3.9.5

New commits:

1433408version, chksum
cf975f5doctest fixes

comment:9 Changed 6 years ago by vdelecroix

  • Reviewers set to Vincent Delecroix
  • Status changed from needs_review to positive_review

Build fine. All test pass.

comment:10 Changed 6 years ago by rws

Thanks for the review.

comment:11 Changed 6 years ago by vbraun

  • Branch changed from u/rws/18980 to cf975f5a9309d01544fe9605d5053b0c715d534e
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.