Opened 4 years ago

Closed 4 years ago

#18966 closed enhancement (fixed)

New Method: Automaton.complement

Reported by: cheuberg Owned by:
Priority: major Milestone: sage-6.9
Component: finite state machines Keywords:
Cc: skropf, dkrenn, slabbe Merged in:
Authors: Clemens Heuberger Reviewers: Daniel Krenn
Report Upstream: N/A Work issues:
Branch: b1a6b60 (Commits) Commit: b1a6b604b8ed5c98eb5499446958eca68b5323a2
Dependencies: Stopgaps:


Implement the automaton recognizing the complement of the language recognized by an automaton.

Change History (7)

comment:1 Changed 4 years ago by cheuberg

  • Branch set to u/cheuberg/fsm/complement
  • Commit set to c67540a6f2e01badd023957b37ce560c059b9d60
  • Status changed from new to needs_review

Last 10 new commits:

fee74b1Trac #18557: Remark on alternative notation in documentation
2583d43Trac #18973: New automaton recognizing a word
cb888a6Trac #18965: Merge #18557 and #18973
b4a7317Trac #18965: Implement FiniteStateMachine.concatenation
d0dd6d6Trac #18964: Implement FiniteStateMachine.kleene_star
cb6516eTrac #18981: New Method: FiniteStateMachine.completion
70d37e1Trac #18965: run determine_alphabets by default
23c9573Trac #18966: Merge #18964 (Kleene star), #18981 (completion), #18965 (concatenation)
5dceb30Trac #18966: Implement Automaton.complement
c67540aFix doctests

comment:2 Changed 4 years ago by git

  • Commit changed from c67540a6f2e01badd023957b37ce560c059b9d60 to b1a6b604b8ed5c98eb5499446958eca68b5323a2

Branch pushed to git repo; I updated commit sha1. New commits:

b1a6b60Trac #18966: Fix doctests

comment:3 follow-up: Changed 4 years ago by slabbe

  • Status changed from needs_review to needs_work

The branch does not apply cleanly.

comment:4 in reply to: ↑ 3 Changed 4 years ago by dkrenn

  • Status changed from needs_work to needs_review

Replying to slabbe:

The branch does not apply cleanly.

Branch merges without any problems. This is a "problem" of trac (git-plugin or something similar), which does not detect that git merge will be successful. No extra merge commit of 6.9.beta1 is needed; thus set back to "needs review"

comment:5 Changed 4 years ago by dkrenn

  • Status changed from needs_review to positive_review

Looks fine. (6.9.beta6 merges).

comment:6 Changed 4 years ago by dkrenn

  • Reviewers set to Daniel Krenn

comment:7 Changed 4 years ago by vbraun

  • Branch changed from u/cheuberg/fsm/complement to b1a6b604b8ed5c98eb5499446958eca68b5323a2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.