Opened 4 years ago

Closed 4 years ago

#18965 closed enhancement (fixed)

New Method: FiniteStateMachine.concatenation

Reported by: cheuberg Owned by:
Priority: major Milestone: sage-6.9
Component: finite state machines Keywords:
Cc: skropf, dkrenn, slabbe Merged in:
Authors: Clemens Heuberger Reviewers: Daniel Krenn
Report Upstream: N/A Work issues:
Branch: 76e05d6 (Commits) Commit: 76e05d6b41f9829af1666bec6c2eee8bda7121a6
Dependencies: #18557, #18973 Stopgaps:

Description

Implement concatenation of two finite state machines as method .concatenation as well as __mul__.

Change History (10)

comment:1 Changed 4 years ago by cheuberg

  • Branch set to u/cheuberg/fsm/concatenation
  • Commit set to b4a7317bdedd93ad9c31265d8f77177d2811ff52
  • Dependencies set to #18557, #18973
  • Status changed from new to needs_review

New commits:

ea021ccTrac #18556: FiniteStateMachine.is_deterministic: several initial states
ff3a5d8Trac #18557: Implement FiniteStateMachine.disjoint_union (and .__or__)
a89d3eaTrac #18557: One typo
fee74b1Trac #18557: Remark on alternative notation in documentation
2583d43Trac #18973: New automaton recognizing a word
cb888a6Trac #18965: Merge #18557 and #18973
b4a7317Trac #18965: Implement FiniteStateMachine.concatenation

comment:2 Changed 4 years ago by git

  • Commit changed from b4a7317bdedd93ad9c31265d8f77177d2811ff52 to 70d37e150750d45e54fee05cfba46f4e76beeb3b

Branch pushed to git repo; I updated commit sha1. New commits:

70d37e1Trac #18965: run determine_alphabets by default

comment:3 Changed 4 years ago by cheuberg

  • Status changed from needs_review to needs_work
  • Work issues set to input alphabet

The input alphabet should be the union of the two input alphabets (instead of determine_alphabets).

comment:4 Changed 4 years ago by git

  • Commit changed from 70d37e150750d45e54fee05cfba46f4e76beeb3b to cdbe026a999486b107129555e5a3291d6f49d120

Branch pushed to git repo; I updated commit sha1. New commits:

e926533Revert "Trac #18965: run determine_alphabets by default"
cdbe026Trac #18965: Handle input_alphabet as in disjoint_union (#18989)

comment:5 Changed 4 years ago by cheuberg

  • Status changed from needs_work to needs_review
  • Work issues input alphabet deleted

comment:6 follow-up: Changed 4 years ago by slabbe

  • Status changed from needs_review to needs_work

The branch does not apply cleanly (marked in red above).

comment:7 in reply to: ↑ 6 Changed 4 years ago by dkrenn

  • Status changed from needs_work to needs_review

Replying to slabbe:

The branch does not apply cleanly (marked in red above).

Branch merges without any problems. This is a "problem" of trac (git-plugin or something similar), which does not detect that git merge will be successful. No extra merge commit of 6.9.beta1 is needed; thus set back to "needs review"

comment:8 Changed 4 years ago by dkrenn

  • Branch changed from u/cheuberg/fsm/concatenation to u/dkrenn/fsm/concatenation

comment:9 Changed 4 years ago by dkrenn

  • Commit changed from cdbe026a999486b107129555e5a3291d6f49d120 to 76e05d6b41f9829af1666bec6c2eee8bda7121a6
  • Reviewers set to Daniel Krenn
  • Status changed from needs_review to positive_review

One minor reviewer commit (docstring). Is fine --> positive.


New commits:

76e05d6minor corrections (spacings, .) in docstring

comment:10 Changed 4 years ago by vbraun

  • Branch changed from u/dkrenn/fsm/concatenation to 76e05d6b41f9829af1666bec6c2eee8bda7121a6
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.