Opened 4 years ago

Closed 4 years ago

#18964 closed enhancement (fixed)

New Method: FiniteStateMachine.kleene_star

Reported by: cheuberg Owned by:
Priority: major Milestone: sage-6.9
Component: finite state machines Keywords:
Cc: skropf, dkrenn, slabbe Merged in:
Authors: Clemens Heuberger Reviewers: Daniel Krenn
Report Upstream: N/A Work issues:
Branch: d0dd6d6 (Commits) Commit: d0dd6d6bc3227271ab2464cbda5b8c18ddd92cc7
Dependencies: #18557, #18973, #18965 Stopgaps:

Description

Implement kleene_star for Automata and Transducer.

Change History (6)

comment:1 Changed 4 years ago by cheuberg

  • Branch set to u/cheuberg/fsm/kleene_star
  • Commit set to d0dd6d6bc3227271ab2464cbda5b8c18ddd92cc7
  • Status changed from new to needs_review

New commits:

ea021ccTrac #18556: FiniteStateMachine.is_deterministic: several initial states
ff3a5d8Trac #18557: Implement FiniteStateMachine.disjoint_union (and .__or__)
a89d3eaTrac #18557: One typo
fee74b1Trac #18557: Remark on alternative notation in documentation
2583d43Trac #18973: New automaton recognizing a word
cb888a6Trac #18965: Merge #18557 and #18973
b4a7317Trac #18965: Implement FiniteStateMachine.concatenation
d0dd6d6Trac #18964: Implement FiniteStateMachine.kleene_star

comment:2 Changed 4 years ago by cheuberg

  • Dependencies set to #18557, #18973, #18965

comment:3 follow-up: Changed 4 years ago by slabbe

  • Status changed from needs_review to needs_work

The branch does not apply cleanly (marked in red above).

comment:4 in reply to: ↑ 3 Changed 4 years ago by dkrenn

  • Status changed from needs_work to needs_review

Replying to slabbe:

The branch does not apply cleanly (marked in red above).

Branch merges without any problems. This is a "problem" of trac (git-plugin or something similar), which does not detect that git merge will be successful. No extra merge commit of 6.9.beta1 is needed; thus set back to "needs review"

comment:5 Changed 4 years ago by dkrenn

  • Reviewers set to Daniel Krenn
  • Status changed from needs_review to positive_review

Looks good :)

comment:6 Changed 4 years ago by vbraun

  • Branch changed from u/cheuberg/fsm/kleene_star to d0dd6d6bc3227271ab2464cbda5b8c18ddd92cc7
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.