Opened 8 years ago

Closed 8 years ago

#18950 closed enhancement (fixed)

Remove make_dlxwrapper from the sage namespace

Reported by: slabbe Owned by:
Priority: major Milestone: sage-6.8
Component: combinatorics Keywords:
Cc: ncohen Merged in:
Authors: Sébastien Labbé Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: 1197483 (Commits, GitHub, GitLab) Commit: 11974832bf3c6d13ed758a109f537033f56394fb
Dependencies: #11814 Stopgaps:

GitHub link to the corresponding issue

Description (last modified by slabbe)

make_dlxwrapper is used for creating a dlx_solver from a pickled list:

 $ sage -grep make_dlxwrapper
sage/combinat/matrices/all.py:from dancing_links import make_dlxwrapper
sage/combinat/matrices/dancing_links.pyx:            sage: x = make_dlxwrapper(dumps(rows))
sage/combinat/matrices/dancing_links.pyx:            sage: print make_dlxwrapper(dumps(rows)).__str__()
sage/combinat/matrices/dancing_links.pyx:            sage: x = make_dlxwrapper(dumps(rows))
sage/combinat/matrices/dancing_links.pyx:        return sage.combinat.matrices.dancing_links.make_dlxwrapper, (dumps(self.rows),)
sage/combinat/matrices/dancing_links.pyx:def make_dlxwrapper(s):
sage/combinat/matrices/dancing_links.pyx:        sage: x = make_dlxwrapper(dumps(rows))

This is a follow-up for #11814.

Change History (9)

comment:1 Changed 8 years ago by slabbe

Description: modified (diff)
Summary: Fix the segmentation fault in dlx_solverRemove make_dlxwrapper from the sage namespace

Since the segmentation fault is now fixed in #11814, I am changing the goal of this ticket (still as a follow-up for #11814).

comment:2 Changed 8 years ago by slabbe

Type: defectenhancement

comment:3 Changed 8 years ago by slabbe

Description: modified (diff)

comment:4 Changed 8 years ago by ncohen

Cc: ncohen added

comment:5 Changed 8 years ago by slabbe

Branch: u/slabbe/18950
Commit: 11974832bf3c6d13ed758a109f537033f56394fb
Dependencies: #11814
Status: newneeds_review

I suggest to not use deprecation for this unpickle function.


New commits:

8ee8dd8Trac #11814: Catch the segmentation fault in dancing links
25741dfTrac #11814: Merge with 6.8.rc1
35f074cTrac #11814: Added not tested flag for segmentation fault
5495759Trac #11814: Fix segmentation Fault raised by an assert
392b62cSimplify dancing links code
3a3dd8bRemoved cimport Integer from dancing links
56c74edBetter __repr__ for dancing links, added rows method
e2b82a4Fix doctest in games/quantumino.py
119748318950: Remove make_dlxwrapper from sage namespace

comment:6 Changed 8 years ago by slabbe

Sorry for the long commit list from #11814: only commit ​1197483 needs to be reviewed here.

comment:7 Changed 8 years ago by jdemeyer

Authors: Sébastien Labbé
Reviewers: Jeroen Demeyer

Running doctests now...

comment:8 Changed 8 years ago by jdemeyer

Status: needs_reviewpositive_review

comment:9 Changed 8 years ago by vbraun

Branch: u/slabbe/1895011974832bf3c6d13ed758a109f537033f56394fb
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.