Opened 4 years ago

Closed 4 years ago

#18949 closed enhancement (fixed)

a doc typo in graph.py

Reported by: chapoton Owned by:
Priority: minor Milestone: sage-6.8
Component: graph theory Keywords:
Cc: ncohen Merged in:
Authors: Frédéric Chapoton Reviewers: Nathann Cohen
Report Upstream: N/A Work issues:
Branch: 3b9cb9c (Commits) Commit: 3b9cb9c7eccebbe96da6e08a0fd779fa53842ae6
Dependencies: Stopgaps:

Description

let us correct that typo

Change History (5)

comment:1 Changed 4 years ago by chapoton

  • Branch set to u/chapoton/18949
  • Cc ncohen added
  • Commit set to 3b9cb9c7eccebbe96da6e08a0fd779fa53842ae6
  • Status changed from new to needs_review

New commits:

3b9cb9cjust a few details in graph.py

comment:2 Changed 4 years ago by ncohen

  • Reviewers set to Nathann Cohen
  • Status changed from needs_review to positive_review

Thanks !

comment:3 follow-up: Changed 4 years ago by wluebbe

Maybe this citation from PEP 8 (https://www.python.org/dev/peps/pep-0008/) applies:

Don't compare boolean values to True or False using  ==  . 
Yes:   if greeting:
No:    if greeting == True:
Worse: if greeting is True:

comment:4 in reply to: ↑ 3 Changed 4 years ago by ncohen

Maybe this citation from PEP 8 (https://www.python.org/dev/peps/pep-0008/) applies:

You can set the ticket to needs_work if you want.

Nathann

comment:5 Changed 4 years ago by vbraun

  • Branch changed from u/chapoton/18949 to 3b9cb9c7eccebbe96da6e08a0fd779fa53842ae6
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.