Opened 7 years ago
Closed 7 years ago
#18939 closed enhancement (fixed)
allow conversion of Arc objects to Bezier paths
Reported by: | Frédéric Chapoton | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-6.9 |
Component: | graphics | Keywords: | arc bezier path plot |
Cc: | Merged in: | ||
Authors: | Frédéric Chapoton | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | e94cf83 (Commits, GitHub, GitLab) | Commit: | e94cf83e5699cca28746cdf70f201f3080440b18 |
Dependencies: | Stopgaps: |
Description (last modified by )
As a first step towards hyperbolic polygons in the Poincaré disk model, let us introduce the possibility to convert Arc objects to Bezier paths.
Another ticket will use this for hyperbolic polygons.
Change History (10)
comment:1 Changed 7 years ago by
Authors: | → Frédéric Chapoton |
---|---|
Branch: | → u/chapoton/18939 |
Commit: | → 1eb53c38e523f7850b27f8d0e6d07c0e013b7e6f |
comment:2 Changed 7 years ago by
Status: | new → needs_review |
---|
comment:3 Changed 7 years ago by
Status: | needs_review → needs_work |
---|
no working correctly, proportions are not correct
comment:4 Changed 7 years ago by
Commit: | 1eb53c38e523f7850b27f8d0e6d07c0e013b7e6f → b262d972aa792e70bb0f3c1afded2aaeb102dd77 |
---|
comment:5 Changed 7 years ago by
Description: | modified (diff) |
---|---|
Keywords: | arc bezier path plot added |
Status: | needs_work → needs_review |
This is now working, I think.
I have taken the opportunity to clean up the unique changed file, putting everything into pep8 format and pyflakes standard.
Back to needs review.
comment:6 Changed 7 years ago by
Milestone: | sage-6.8 → sage-6.9 |
---|
comment:7 Changed 7 years ago by
Reviewers: | → Travis Scrimshaw |
---|
Positive review modulo making the alpha non-zero so we can see the drawn line.
comment:8 Changed 7 years ago by
Commit: | b262d972aa792e70bb0f3c1afded2aaeb102dd77 → e94cf83e5699cca28746cdf70f201f3080440b18 |
---|
comment:9 Changed 7 years ago by
Status: | needs_review → positive_review |
---|
ok, I did set alpha to 1 in the example.
Thanks Travis.
comment:10 Changed 7 years ago by
Branch: | u/chapoton/18939 → e94cf83e5699cca28746cdf70f201f3080440b18 |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
New commits:
adding conversion from Arc class to Bezier paths.