Opened 6 years ago
Closed 6 years ago
#18939 closed enhancement (fixed)
allow conversion of Arc objects to Bezier paths
Reported by: | chapoton | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-6.9 |
Component: | graphics | Keywords: | arc bezier path plot |
Cc: | Merged in: | ||
Authors: | Frédéric Chapoton | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | e94cf83 (Commits, GitHub, GitLab) | Commit: | e94cf83e5699cca28746cdf70f201f3080440b18 |
Dependencies: | Stopgaps: |
Description (last modified by )
As a first step towards hyperbolic polygons in the Poincaré disk model, let us introduce the possibility to convert Arc objects to Bezier paths.
Another ticket will use this for hyperbolic polygons.
Change History (10)
comment:1 Changed 6 years ago by
- Branch set to u/chapoton/18939
- Commit set to 1eb53c38e523f7850b27f8d0e6d07c0e013b7e6f
comment:2 Changed 6 years ago by
- Status changed from new to needs_review
comment:3 Changed 6 years ago by
- Status changed from needs_review to needs_work
no working correctly, proportions are not correct
comment:4 Changed 6 years ago by
- Commit changed from 1eb53c38e523f7850b27f8d0e6d07c0e013b7e6f to b262d972aa792e70bb0f3c1afded2aaeb102dd77
comment:5 Changed 6 years ago by
- Description modified (diff)
- Keywords arc bezier path plot added
- Status changed from needs_work to needs_review
This is now working, I think.
I have taken the opportunity to clean up the unique changed file, putting everything into pep8 format and pyflakes standard.
Back to needs review.
comment:6 Changed 6 years ago by
- Milestone changed from sage-6.8 to sage-6.9
comment:7 Changed 6 years ago by
- Reviewers set to Travis Scrimshaw
Positive review modulo making the alpha non-zero so we can see the drawn line.
comment:8 Changed 6 years ago by
- Commit changed from b262d972aa792e70bb0f3c1afded2aaeb102dd77 to e94cf83e5699cca28746cdf70f201f3080440b18
comment:9 Changed 6 years ago by
- Status changed from needs_review to positive_review
ok, I did set alpha to 1 in the example.
Thanks Travis.
comment:10 Changed 6 years ago by
- Branch changed from u/chapoton/18939 to e94cf83e5699cca28746cdf70f201f3080440b18
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
adding conversion from Arc class to Bezier paths.