Opened 2 years ago

Closed 2 years ago

#18930 closed enhancement (fixed)

GrowthGroup: short notation factory

Reported by: behackl Owned by:
Priority: major Milestone: sage-6.9
Component: asymptotic expansions Keywords: asymptotics, gsoc15
Cc: dkrenn, cheuberg Merged in:
Authors: Benjamin Hackl, Daniel Krenn Reviewers: Daniel Krenn, Clemens Heuberger
Report Upstream: N/A Work issues:
Branch: 4f99031 (Commits) Commit: 4f99031a4c1ae9d57ed653f4b6c9e8296f58ade6
Dependencies: #17600 Stopgaps:

Description (last modified by behackl)

For the sake of usability we have introduced a short notation for growth groups (implemented at #17600).

For various reasons, having a factory that is able to generate a growth group from such a "short representation string" is desireable: for example, such a factory enables us to implement a user-friendly way of interacting with the AsymptoticRing (implemented at #17716).

This ticket provides an implementation for such a factory (which can be extended easily to cover cartesian products of growth groups as well).

See #17601 for a roadmap and the planned structure.

Change History (19)

comment:1 Changed 2 years ago by behackl

  • Branch set to u/behackl/asy/growthGroup-factory
  • Commit set to ae0fff31e1319c091539a21542c7deeb6dbe4d11
  • Dependencies set to #17600

Last 10 new commits:

73017abconversion from multivariate polynomial rings and multivariate power
a4d5c5f_coerce_map_from_ --> has_coerce_map_from in doctests
ee8272cfixed conversion from multivariate power series rings; replaced PolynomialRing and PowerSeriesRing in doc by bracket-notation
5538893added @experimental to parents
627884cintroduce _repr_short_ for nicer representation
907e82ddocstrings for _repr*_ methods
6c8b543changed default representation to short representation
2903a9ahelper method for short representation implemented
c916514implemented a helper method for the growth group factory
ae0fff3factory for growth groups implemented

comment:2 Changed 2 years ago by behackl

  • Authors set to Benjamin Hackl

comment:3 Changed 2 years ago by behackl

  • Description modified (diff)

comment:4 Changed 2 years ago by behackl

  • Description modified (diff)

comment:5 Changed 2 years ago by dkrenn

  • Branch changed from u/behackl/asy/growthGroup-factory to u/dkrenn/asy/growthGroup-factory

comment:6 Changed 2 years ago by dkrenn

  • Authors changed from Benjamin Hackl to Benjamin Hackl, Daniel Krenn
  • Commit changed from ae0fff31e1319c091539a21542c7deeb6dbe4d11 to e60a325b6191aa07d107f2f7c9be554318bad6de
  • Reviewers set to Daniel Krenn

Last 10 new commits:

30cde4dextend docstring of parent_to_string
1deeeffMerge branch 'asy/6.7/growthGroup' into asy/group-factory
1299e4fextend docstring of string_to_parent
5bc0596small rewritings
ed03ca1rename to parent_to_repr_short
45a37b8rewrite docstring
96435ceMerge branch 'asy/6.7/growthGroup' into asy/group-factory
b7d2273repair
655ec12rename to repr_short_to_parent
e60a325rewrite growth group factory

comment:7 Changed 2 years ago by behackl

  • Branch changed from u/dkrenn/asy/growthGroup-factory to u/behackl/asy/growthGroup-factory
  • Commit changed from e60a325b6191aa07d107f2f7c9be554318bad6de to 62d824fa78dcda33e98ac4e636434a67a6bec201

Last 10 new commits:

45a37b8rewrite docstring
96435ceMerge branch 'asy/6.7/growthGroup' into asy/group-factory
b7d2273repair
655ec12rename to repr_short_to_parent
e60a325rewrite growth group factory
ea8ae66repr-option to suppress words "Growth Group"
b7f5c73rename repr-option-keyword and minor change in output
c0ec9fdminor change in output of repr
f141775typos in module description fixed
62d824fMerge branch 'asy/growthGroup' into asy/growthGroup-factory

comment:8 Changed 2 years ago by git

  • Commit changed from 62d824fa78dcda33e98ac4e636434a67a6bec201 to ba16c0f55c92af3c3162de77f9a77e6912d944c0

Branch pushed to git repo; I updated commit sha1. New commits:

164d21ecompare exponents directly instead with is_le_one
baa8f7cimplemented gens_monomial and adapted gen, gens, ngens
b477c62merge branch 'asy/growthGroup' into asy/growthGroup-factory and resolve a minor conflict
3749fa1refactored handling of generators
ba16c0fMerge branch 'asy/growthGroup' into asy/growthGroup-factory

comment:9 Changed 2 years ago by git

  • Commit changed from ba16c0f55c92af3c3162de77f9a77e6912d944c0 to 3564d2346af4ec50c1c34d9d23b8b6c53a7de2c8

Branch pushed to git repo; I updated commit sha1. New commits:

c6d8584error with the element constructor fixed, doctest added
3564d23Merge branch 'asy/growthGroup' into asy/growthGroup-factory

comment:10 Changed 2 years ago by behackl

  • Status changed from new to needs_review

comment:11 Changed 2 years ago by dkrenn

During the project #17601 (the last months in course of GSOC2015 as mentor) I did a very careful reviewing of all code. This includes the code of this ticket. Now this is clearly a positive_review from my side.

comment:12 Changed 2 years ago by git

  • Commit changed from 3564d2346af4ec50c1c34d9d23b8b6c53a7de2c8 to 032d8b8a539dba5e14aa170f1f04096f0632b633

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

1688a84Merge branch 'asy/growthGroup' into asy/growthGroup-factory
d5fdd04collect asymptotic code in one directory
e8662cdcollect asymptotic code in one directory
c5f0dacMerge branch 'asy/growthGroup' into asy/growthGroup-factory
7774ff2fixed doctests
878ef2afixed documentation build
5fd9662Merge branch 'asy/growthGroup' into asy/growthGroup-factory
f20c42efixing doctests
1c81c12language oddities fixed
032d8b8Merge branch 'asy/growthGroup' into asy/growthGroup-factory

comment:13 Changed 2 years ago by dkrenn

  • Branch changed from u/behackl/asy/growthGroup-factory to u/dkrenn/asy/growthGroup-factory

comment:14 Changed 2 years ago by dkrenn

  • Commit changed from 032d8b8a539dba5e14aa170f1f04096f0632b633 to 9d6f2da6d5c1693209c17cf43fc453ade64d676b

Merged 6.9.beta5


New commits:

3a05be7Merge tag '6.9.beta5' into t/17600/asy/growthGroup
58f931dadd asymptotic_expansions index
9d6f2daMerge branch 't/17600/asy/growthGroup' into t/18930/asy/growthGroup-factory

comment:15 Changed 2 years ago by dkrenn

  • Component changed from symbolics to asymptotic expansions

comment:16 Changed 2 years ago by cheuberg

  • Branch changed from u/dkrenn/asy/growthGroup-factory to u/cheuberg/asy/growthGroup-factory

comment:17 Changed 2 years ago by cheuberg

  • Commit changed from 9d6f2da6d5c1693209c17cf43fc453ade64d676b to eaa14537a97ab3129bf462098a3a6ed8582190b0
  • Milestone changed from sage-6.8 to sage-6.9
  • Reviewers changed from Daniel Krenn to Daniel Krenn, Clemens Heuberger

I reviewed this and added two reviewer commits.

Doctests pass and documentation builds and is adequate, code seems to be fine.

Please cross-review my changes and set the ticket to positive_review if you are satisfied.


New commits:

b89fa2dTrac #18930: expand docstring of repr_short_to_parent
eaa1453Trac #18930: tuple for format to be on the safe side

comment:18 Changed 2 years ago by behackl

  • Branch changed from u/cheuberg/asy/growthGroup-factory to u/behackl/asy/growthGroup-factory
  • Commit changed from eaa14537a97ab3129bf462098a3a6ed8582190b0 to 4f99031a4c1ae9d57ed653f4b6c9e8296f58ade6
  • Status changed from needs_review to positive_review

I cross-reviewed your changes, and merged the final version of the positively reviewed ticket #17600 into this branch. LGTM; thanks for the review!


Last 10 new commits:

c4dca20Trac #17600: Punctuation
1ab1334Trac #17600: fix incorrect link
1c7a521corrected INPUT-section of parent_to_repr_short
6dee8b7abstract implementation --> basic implementation
3f88a9aduplicate doctest removed
9489badelement_constructor: input clarification; doctests marked as indirect
053ee33type(...) == ... --> isinstance(...)
7b49489clarification gens vs. gens_monomial
2bf6868prevent strange NotImplementedError from PowerSeriesRing
4f99031Merge branch 'asy/growthGroup' into asy/growthGroup-factory

comment:19 Changed 2 years ago by vbraun

  • Branch changed from u/behackl/asy/growthGroup-factory to 4f99031a4c1ae9d57ed653f4b6c9e8296f58ade6
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.