Opened 4 years ago

Closed 4 years ago

#18925 closed enhancement (fixed)

Poset documentation polishing: covers

Reported by: jmantysalo Owned by:
Priority: minor Milestone: sage-6.9
Component: documentation Keywords:
Cc: chapoton Merged in:
Authors: Jori Mäntysalo Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 8688fd9 (Commits) Commit: 8688fd919f3079de88ac889a5298e49bddedbe13
Dependencies: Stopgaps:

Description

Do some polishing to upper_covers(), cover_relations_iterator() and so on at posets.py.

Change History (8)

comment:1 Changed 4 years ago by jmantysalo

  • Branch set to u/jmantysalo/poset_documentation_polishing__covers

comment:2 Changed 4 years ago by git

  • Commit set to 259de0cd6c57603abee281e704f4abdc5d721907

Branch pushed to git repo; I updated commit sha1. New commits:

259de0cDocumentation changes. No (real) code changes.

comment:3 Changed 4 years ago by git

  • Commit changed from 259de0cd6c57603abee281e704f4abdc5d721907 to 8688fd919f3079de88ac889a5298e49bddedbe13

Branch pushed to git repo; I updated commit sha1. New commits:

8688fd9Forgot one '<'.

comment:4 Changed 4 years ago by jmantysalo

  • Milestone changed from sage-wishlist to sage-6.8
  • Status changed from new to needs_review

Happen this one never be reviewed, no animals will be harm.

comment:5 Changed 4 years ago by jmantysalo

  • Cc chapoton added

Frédéric, want to review another part of The Great Poset Polishing project? :=)

comment:6 Changed 4 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:7 Changed 4 years ago by jmantysalo

  • Milestone changed from sage-6.8 to sage-6.9

comment:8 Changed 4 years ago by vbraun

  • Branch changed from u/jmantysalo/poset_documentation_polishing__covers to 8688fd919f3079de88ac889a5298e49bddedbe13
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.