Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#18921 closed defect (fixed)

propagate integer variable domain to Pynac

Reported by: rws Owned by:
Priority: major Milestone: sage-6.8
Component: symbolics Keywords:
Cc: Merged in:
Authors: Ralf Stephan Reviewers: Vincent Delecroix
Report Upstream: N/A Work issues:
Branch: fcb445d (Commits, GitHub, GitLab) Commit:
Dependencies: #18695 Stopgaps:

Status badges

Description 

sage: _ = var('n', domain='integer')
sage: n.is_integer()
False

All sorts of logic within Pynac depends on this.

See also ​https://github.com/pynac/pynac/issues/11

Change History (7)

comment:1 Changed 6 years ago by rws

  • Branch set to u/rws/propagate_integer_variable_domain_to_pynac

comment:2 Changed 6 years ago by rws

  • Authors set to Ralf Stephan
  • Commit set to 4130107970dbc2aef3cb0fc7858a83be6d38b756
  • Status changed from new to needs_review

New commits:

​413010718921: propagate integer variable domain to Pynac

comment:3 Changed 6 years ago by rws

  • Dependencies set to #18695

comment:4 Changed 6 years ago by git

  • Commit changed from 4130107970dbc2aef3cb0fc7858a83be6d38b756 to fcb445dd65d011ec60f1546a2601c6e558244a51

Branch pushed to git repo; I updated commit sha1. New commits:

​fcb445dMerge branch 'develop' into t/18921/propagate_integer_variable_domain_to_pynac

comment:5 Changed 6 years ago by vdelecroix

  • Reviewers set to Vincent Delecroix
  • Status changed from needs_review to positive_review

Good to go.

comment:6 Changed 6 years ago by vbraun

  • Branch changed from u/rws/propagate_integer_variable_domain_to_pynac to fcb445dd65d011ec60f1546a2601c6e558244a51
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:7 Changed 6 years ago by rws

  • Commit fcb445dd65d011ec60f1546a2601c6e558244a51 deleted

Thanks for the reviews!

Note: See TracTickets for help on using tickets.