Opened 11 years ago

Closed 9 years ago

Last modified 9 years ago

#1891 closed task (wontfix)

remove workaround when Pari > 2.3.3 is released

Reported by: craigcitro Owned by: craigcitro
Priority: trivial Milestone: sage-duplicate/invalid/wontfix
Component: packages: standard Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by mabshoff)

To fix trac #1083, I added a workaround due to a bug in Pari. The code is fixed in their svn version, but it's unlikely that we'll see a new release terribly soon. However, when one comes along, someone should go to sage/rings/number_field/number_field.py and undo the following patch:

-        g = self.__rnf.rnfeltabstorel(pari(f))
+        if self.__K.degree() == 1:
+            g = -1*self.__rnf[0][0]*f[1] + f[0]
+        else:
+            g = self.__rnf.rnfeltabstorel(pari(f))

Or, if whoever is updating the pari spkg sends me an email, I'll take care of this.

Change History (7)

comment:1 Changed 11 years ago by mabshoff

  • Description modified (diff)
  • Milestone set to sage-2.10.1

comment:2 Changed 9 years ago by mpatel

  • Report Upstream set to N/A

Is this already fixed? According to

$ grep rnfeltabstorel `find -name \*.py\*`
./libs/pari/gen.pyx:    def rnfeltabstorel(self, x):
./rings/number_field/number_field_rel.py:        poly_xy = self.pari_rnf().rnfeltabstorel( self(element)._pari_() )
./rings/number_field/maps.py:        g = self.__rnf.rnfeltabstorel(pari(f))

But I don't see nearby code similar to that in the description. However, I'm definitely not an expert.

comment:3 Changed 9 years ago by craigcitro

Well, the workaround is for the case where the degree of the relative number field is one, and it's definitely still present -- several of us fought with that code just a few weeks ago. So I think we still need this ticket.

comment:4 Changed 9 years ago by mpatel

Oops! I apologize. Time for me to read a book...

comment:5 Changed 9 years ago by lftabera

Is this still valid?

sage: gp.version()
((2, 3, 5), 'GP/PARI CALCULATOR Version 2.3.5 (released)')

comment:6 Changed 9 years ago by craigcitro

  • Resolution set to wontfix
  • Status changed from new to closed

Well, I don't think this ticket is valid anymore -- but not because Pari fixed the issue. Does anyone know if this works in Pari unstable (2.4.x)?

comment:7 Changed 9 years ago by mvngu

  • Milestone changed from sage-4.5 to sage-duplicate/invalid/wontfix
Note: See TracTickets for help on using tickets.