Opened 6 years ago

Closed 6 years ago

Last modified 2 years ago

#18887 closed defect (fixed)

latte_int does not build with NTL 9

Reported by: dimpase Owned by:
Priority: major Milestone: sage-6.8
Component: packages: optional Keywords:
Cc: mkoeppe, ncohen Merged in:
Authors: Dima Pasechnik Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: e90e367 (Commits) Commit:
Dependencies: Stopgaps:

Description

The upgrade in #18875 has broken building of latte_int.

Change History (9)

comment:1 Changed 6 years ago by dimpase

  • Cc mkoeppe added

comment:2 Changed 6 years ago by dimpase

  • Branch set to u/dimpase/18887
  • Cc ncohen added
  • Commit set to 9638ecec60aa0b7f797e2f3e3d988a34f57c17f5
  • Status changed from new to needs_review

apparently the new NTL does not set its C++ namespace explicitly...


New commits:

9638eceneeds CXXFLAGS=-DNTL_STD_CXX now

comment:3 Changed 6 years ago by dimpase

  • Authors set to Dima Pasechnik

comment:4 Changed 6 years ago by jdemeyer

  • Status changed from needs_review to needs_work

Append to flags, do not replace:

export CXXFLAGS="-DNTL_STD_CXX $CXXFLAGS"

comment:5 Changed 6 years ago by git

  • Commit changed from 9638ecec60aa0b7f797e2f3e3d988a34f57c17f5 to e90e3670dbed9ad4bb012bd1c95469c5f59b318b

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

e90e367needs CXXFLAGS="-DNTL_STD_CXX ..." now

comment:6 Changed 6 years ago by dimpase

  • Status changed from needs_work to needs_review

comment:7 Changed 6 years ago by jdemeyer

  • Reviewers set to Jeroen Demeyer
  • Status changed from needs_review to positive_review

comment:8 Changed 6 years ago by vbraun

  • Branch changed from u/dimpase/18887 to e90e3670dbed9ad4bb012bd1c95469c5f59b318b
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:9 Changed 2 years ago by mkoeppe

  • Commit e90e3670dbed9ad4bb012bd1c95469c5f59b318b deleted

Follow up: #26190 Upgrade latte_int to 1.7.5

Note: See TracTickets for help on using tickets.