Opened 6 years ago

Closed 5 years ago

#18874 closed defect (fixed)

Fix simon scripts for gp2c usage

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-6.8
Component: misc Keywords:
Cc: cremona Merged in:
Authors: Jeroen Demeyer Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: a6e0513 (Commits, GitHub, GitLab) Commit: a6e05136840a9755085cf65ab84cf0aa905ed4a7
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

Various fixes which are required for gp2c, but which do not otherwise change the functionality of these scripts.

Change History (7)

comment:1 Changed 6 years ago by jdemeyer

  • Branch set to u/jdemeyer/fix_braces_in_simon_scripts

comment:2 Changed 6 years ago by jdemeyer

  • Commit set to 50085c5e414da77b16f763013d678c865148656f
  • Status changed from new to needs_review

New commits:

​50085c5Fix braces in Simon's scripts for gp2c usage

comment:3 Changed 6 years ago by jdemeyer

  • Description modified (diff)
  • Status changed from needs_review to needs_work
  • Summary changed from Fix braces in simon scripts to Fix simon scripts for gp2c usage

comment:4 Changed 6 years ago by git

  • Commit changed from 50085c5e414da77b16f763013d678c865148656f to a6e05136840a9755085cf65ab84cf0aa905ed4a7

Branch pushed to git repo; I updated commit sha1. New commits:

​a6e0513Remove duplicate global variables

comment:5 Changed 6 years ago by jdemeyer

  • Status changed from needs_work to needs_review

comment:6 Changed 5 years ago by vbraun

  • Reviewers set to Volker Braun
  • Status changed from needs_review to positive_review

comment:7 Changed 5 years ago by vbraun

  • Branch changed from u/jdemeyer/fix_braces_in_simon_scripts to a6e05136840a9755085cf65ab84cf0aa905ed4a7
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.